8 Commits

Author	SHA1	Message	Date
ReStartercc	0963f59955	Fix baggage.NewMember to decode the accepted value (#3226) ... * Fix baggage.NewMember to decode the accepted value `value` is decoded and stored after validating the input parameters. Corresponding test cases are modified so that we can make sure `value` is properly encoded before creating Member. * fix md lint * add function document to NewMember for value encoding and decoding * remove redundant comments and fix CHANGELOG.md * fix wrong PR number in the changelog * fix wrong PR number * fix md-lint Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>	2022-10-18 12:45:04 -07:00
Chester Cheung	30fcf786c3	bugfix: fix baggage set member failed (#3165) ... * fix baggage set member failed * add unittest * fix unittest * rewrite unittest code	2022-09-17 12:54:12 -07:00
Tyler Yahn	1f5b159161	Use already enabled revive linter and add depguard (#2883) ... * Refactor golangci-lint conf Order settings alphabetically. * Add revive settings to golangci conf * Check blank imports * Check bool-literal-in-expr * Check constant-logical-expr * Check context-as-argument * Check context-key-type * Check deep-exit * Check defer * Check dot-imports * Check duplicated-imports * Check early-return * Check empty-block * Check empty-lines * Check error-naming * Check error-return * Check error-strings * Check errorf * Stop ignoring context first arg in tests * Check exported comments * Check flag-parameter * Check identical branches * Check if-return * Check increment-decrement * Check indent-error-flow * Check deny list of go imports * Check import shadowing * Check package comments * Check range * Check range val in closure * Check range val address * Check redefines builtin id * Check string-format * Check struct tag * Check superfluous else * Check time equal * Check var naming * Check var declaration * Check unconditional recursion * Check unexported return * Check unhandled errors * Check unnecessary stmt * Check unnecessary break * Check waitgroup by value * Exclude deep-exit check in example*_test.go files	2022-05-19 15:15:07 -05:00
Damien Mathieu	cb76cf1b0d	Validate members once, in NewMember (#2522) ... * use NewMember, or specify if the member is not validated when creating new ones * expect members to already be validated when creating a new package * add changelog entry * add an isEmpty field to member and property for quick validation * rename isEmpty to hasData So by default, an empty struct really is marked as having no data * Update baggage/baggage_test.go Co-authored-by: Aaron Clawson <Aaron.Clawson@gmail.com> * don't validate the member in parseMember, we alredy ran that validation We also don't want to use NewMember, as that runs the property validation again, making the benchmark quite slower * move changelog entry to the fixed section * provide the member/property data when returning an invalid error Co-authored-by: Aaron Clawson <Aaron.Clawson@gmail.com>	2022-02-04 08:19:39 -08:00
Aaron Clawson	5f41868675	Un-escape url coding when parsing baggage. (#2529) ... * un-escape url coding when parsing baggage. * Added changelog Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>	2022-01-24 09:17:45 -08:00
Tyler Yahn	4bf6150fa9	Add baggage implementation based on the W3C and OpenTelemetry specification (#1967) ... * Rename baggage context file * Initial baggage implementation * Initial tests * More tests * Update baggage context functionality * Add New method to baggage pkg * Update namedtracer example * URL encode baggage values * Refactor and use internal baggage pkg * Update OpenTracing bridge * Update baggage propagator * Fix lint and test errors * Add changes to changelog * Apply suggestions from code review * Rename testcase field per suggestion * Update test to verify last-one-wins semantics * Explicitly seed random numbers with static seed in tests * Parse Member key/value with string split * Add test for member parse with equal signs in value * Trim whitespaces for member key/value	2021-06-08 08:06:37 -07:00
Punya Biswal	ecf65d7968	Rename otel/label -> otel/attribute (#1541) ... * Rename otel/label -> otel/attr Leave the imported name alone, to avoid a large diff and conflicts * Better import comment * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * otel/attr -> otel/attribute * Missed the changelog entry * Get rid of import renaming * Merge remaining conflicts Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>	2021-02-18 12:59:37 -05:00
Krzesimir Nowak	63a11144cf	Move baggage and propagation to separate packages (#1325) ... * Move propagation code to propagation package * Move baggage code to baggage package * Update changelog * Make docs of baggage.Set more clear Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>	2020-11-13 07:34:24 -08:00