1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-12 10:04:29 +02:00
Commit Graph

989 Commits

Author SHA1 Message Date
Tyler Yahn
0fec28040d
Update trace API TracerOption (#1109)
* Update Tracer configuration.

Conform to API option design outlined in #536.

Add tests to validate new TracerConfigure function

Drop the `instrumentation` prefix.

* Stick with instrumentationVersion for now

* Propagate changes

* Add changes to Changelog
2020-09-02 07:20:52 -07:00
Trevor Foster
a304e8280d
Add reconnecting udp connection type to jaeger exporter (#1063)
* port reconnecting udp client from jaeger-client-go

* Fix precommit issues

* Fix license check

* Add initial value for max packet size

* Fix for atomic usage on 386 arch

* Modify reconnecting option to an affirmative

* Add changelog entry

* Dont hold rlock for writes

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-01 09:08:11 -07:00
Andrei Ozerov
e3abf31b0b
Make trace testhelpers public (#1111)
* Make trace testhelpers public

Move MockSpan and MockTracer out of internal package into the api/trace
directory.

* Do not move internal/trace/parent into testing dir

Leave internal/trace/parent/parent.go in the internal directory.

* Fix MockTracer Start method comments

Fix "TraceID".

* Run make precommit to cleanup go.mod

Cleanum go.mod and go.sum.

* Fix tracetest MockSpan structure alignment

Make MockSpan 80 bytes instead of 88 by fixing its alignment.

* Revert bridge/opentracing/internal/mock.go imports

Do not change imports lines in bridge/opentracing/internal/mock.go.
2020-09-01 08:16:05 -07:00
Tyler Yahn
1ab708e4b8
Rename global SetTraceProvider and TraceProvider (#1102)
* Rename global {Set,}TraceProvider

Resolves #1101

* Rename unexported and testing vars
2020-08-31 10:02:04 -07:00
Tyler Yahn
f36759aa47
Add @XSAM as project approver (#1110)
Requirements
- [X] >=10 substantive contributions
- [X] Active >1mo
- [X] add to CODEOWNERS  (done in this pull)
- [X] Add to CONTRIBUTING.md (done in this pull)
- [X] Maintainer nomination: @MrAlias
- [X] Other maintainer(s) (@Aneurysm9) sign-off
- [X]  Add to @open-telemetry/go-approvers
2020-08-28 17:05:48 -04:00
Andrew
1c3626e636
#872 Make metric test helpers public (#1040)
* Make metric test helpers public

* Move everything metric test related to api/metric/metrictest

* Unify metric measurement assertions

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-27 13:03:56 -07:00
dependabot[bot]
5d9daf0654
Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /sdk (#1105)
* Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /sdk

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.0...v1.31.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-27 12:19:01 -07:00
Tyler Yahn
06a0be789a
Update README.md (#1106)
* Update README.md

Replace `Installation` and `Compatible Libraries` sections with a more
comprehensive `Getting Started` section to address the two actions most
users will want to know about: instrumenting and exporting.

Remove the code example.

Add links to project boards and milestones to address project status
questions.

* Fix spelling error

* Apply suggestions from code review

Co-authored-by: ET <evantorrie@users.noreply.github.com>

Co-authored-by: ET <evantorrie@users.noreply.github.com>
2020-08-27 12:14:37 -07:00
Tyler Yahn
3b3c263d9a
Update dependabot config (#1100)
Add check for github-actions.
Add missing examples and SDK go.mod
Remove redundant comments.
Change check to be weekly on Sunday to reduce load and churn.
Sort alphanumerically.
Add check to Makefile to ensure if there is a `go.mod` file there is a dependabot entry for that directory.
2020-08-26 16:34:41 -07:00
dependabot[bot]
737d81208b
Bump github.com/google/go-cmp from 0.5.1 to 0.5.2 (#1093)
* Bump github.com/google/go-cmp from 0.5.1 to 0.5.2

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.1...v0.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-26 11:39:41 -07:00
dependabot[bot]
170b6c6986
Bump github.com/google/go-cmp from 0.5.1 to 0.5.2 in /exporters/otlp (#1095)
* Bump github.com/google/go-cmp from 0.5.1 to 0.5.2 in /exporters/otlp

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.1...v0.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-26 11:31:47 -07:00
dependabot[bot]
2351c8cf7d
Bump github.com/google/go-cmp from 0.5.1 to 0.5.2 in /exporters/trace/jaeger (#1097)
* Bump github.com/google/go-cmp in /exporters/trace/jaeger

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.1...v0.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-26 11:10:58 -07:00
dependabot[bot]
9ce71fe2e5
Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/trace/zipkin (#1096)
* Bump google.golang.org/grpc in /exporters/trace/zipkin

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.0...v1.31.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-26 10:46:20 -07:00
dependabot[bot]
b933f31a20
Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/trace/jaeger (#1098)
* Bump google.golang.org/grpc in /exporters/trace/jaeger

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.0...v1.31.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-26 10:27:55 -07:00
dependabot[bot]
750848e993
Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/stdout (#1099)
* Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/stdout

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.0...v1.31.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-26 10:06:17 -07:00
dependabot[bot]
35bc9e7877
Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/otlp (#1094)
* Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/otlp

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.0...v1.31.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-08-26 09:52:28 -07:00
Anthony Mirabella
1f2eba2cdb
Release v0.11.0 (#1089)
* Prepare for releasing v0.11.0

* Update CHANGELOG.md to reflect scope of v0.11.0 release

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-24 22:38:37 -04:00
Anthony Mirabella
cd1a868dde
Merge pull request #1079 from TMeireOqton/remove-orphaned-spanprocessor-funcs
Remove the orphaned RegisterSpanProcessor and UnregisterSpanProcessor
2020-08-24 17:53:20 -04:00
Tyler Yahn
3471177368
Merge branch 'master' into remove-orphaned-spanprocessor-funcs 2020-08-24 10:29:39 -07:00
dependabot[bot]
21726e26d1
Bump github.com/itchyny/gojq from 0.11.0 to 0.11.1 in /tools (#1081)
* Bump github.com/itchyny/gojq from 0.11.0 to 0.11.1 in /tools

Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.11.0 to 0.11.1.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/master/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.11.0...v0.11.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-24 09:54:13 -07:00
ET
c691e72a76
Merge branch 'master' into remove-orphaned-spanprocessor-funcs 2020-08-24 09:52:19 -07:00
Bogdan Drutu
9907328c5b
Export coverage report to codecov (#995)
* Export coverage report to codecov

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Use orb and individual coverage files per module

* Run go cover inside module directory to account for local rewrites

Still try to upload using a single file, since orb docs seem to
indicate if you have more than one file, you're going to need to run
the orb multiple times.

* Use correct filename

* Don't do anything silly like appending a file to itself

* Handle subtle differences between FreeBSD and Linux

* Ignore opentelemetry-proto-gen files in exporters/otlp/internal

* Does codecov orb leave current directory in a bad state?

* Copy instead of move

* Ignore generated protobuf code in jaeger exporter module

Co-authored-by: Evan Torrie <evantorrie@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-24 09:43:29 -07:00
Thomas Meire
e17e3caec8 Remove the orphaned RegisterSpanProcessor and UnregisterSpanProcessor #1077 2020-08-22 12:38:13 +02:00
Poga Po
0ba595bddb
fix broken example link by directly link to the example directory (#1071)
* fix broken example link to the example directory

* Update README.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-19 19:57:03 -07:00
dengliming
77b7778a54
Integration tests for OTel Collector Attributes. (#1062)
* Integration tests for OTel Collector Attributes.

* Update CHANGELOG.md

* Fix review

* Fix review.

* Fix test.

* Fix test.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-18 08:45:50 -07:00
Tyler Yahn
f995380e58
Unify api/label and api/kv in new label package (#1060)
* Move `api/label` to `label`

* Move `api/kv` package contents into `label` package

* Unify label package name

* Move `api/internal/rawhelpers.go` to `internal`

* Propagate replacing `api/kv` with `label` pkg

* golint

* Fix over-aggressive change

* Update Changelog
2020-08-17 20:25:03 -07:00
Anthony Mirabella
e44c9dee78
Remove example/README.md that referenced moved HTTP example (#1066)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-17 19:59:01 -07:00
Anthony Mirabella
576a131577
Merge pull request #1061 from dengliming/f_rename
Rename Callback Function.
2020-08-17 18:20:25 -04:00
Anthony Mirabella
dce4aec172
Merge branch 'master' into f_rename 2020-08-17 18:14:25 -04:00
ET
62d603f1a6
Build on newly released version of go, go 1.15 (#1064)
* Build on newly release version of go, go 1.15

Remove 1.13 build job per policy of supporting past two releases.

* String conversions in 1.15 require byte, rune or string.

Simply passing an integer now issues a warning.
2020-08-16 20:04:53 -07:00
dengliming
f8ed8332d6 Fix review. 2020-08-17 00:45:21 +08:00
dengliming
d94143ee13 Rename Callback Function. 2020-08-15 11:56:19 +08:00
dependabot[bot]
45b6a22cbb
Bump github.com/openzipkin/zipkin-go from 0.2.2 to 0.2.3 in /exporters/trace/zipkin (#1059)
* Bump github.com/openzipkin/zipkin-go in /exporters/trace/zipkin

Bumps [github.com/openzipkin/zipkin-go](https://github.com/openzipkin/zipkin-go) from 0.2.2 to 0.2.3.
- [Release notes](https://github.com/openzipkin/zipkin-go/releases)
- [Commits](https://github.com/openzipkin/zipkin-go/compare/v0.2.2...v0.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-14 08:04:21 -07:00
Tyler Yahn
f8b14d280e
Update project maintainers (#1058)
Replace @jmacd with @Aneurysm9 as maintainer of the project. Keep @jmacd
as a project approver.
2020-08-14 07:53:42 -07:00
Joshua MacDonald
5d1dd4ee23
Add a dimensionality-reducing metric Processor (#1057)
* Add a dimensionality-reducing metric processor

* Precommit

* Add package docs

* Remove dead code
2020-08-13 15:47:17 -07:00
Joshua MacDonald
1cdf4ee8e6
Create a export.Checkpointer API; refactor metric export pipeline test helpers (#1055)
* Add regexp filter in api/label, test

* Add regexp option to sdk.Config

* Return indistinct values only when keyRe != nil

* Filter in sdk

* Add an accumulator filter test

* SDK tests pass

* Precommit

* Undo set filters

* Backout related filter changes

* Add a new test

* Checkpoint

* Comments

* Comments in label.Set

* Lint

* Add Checkpointer

* Test refactor continues

* Refactor reducer test

* Checkpoint

* Update push_test

* Update pull controller

* Comment

* Remove pending PRs

* Remove exportertest pkg

* Revert basic changes

* Revert testing changes

* Restore processortest changes

* Precommit & comments

* Comments on pull semantics

* Comments

* Fix buggy test; incorrect expectation following error

* Finish this test

* Comments

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-13 13:12:32 -07:00
Joshua MacDonald
b7df5543e3
Add support for filtering metric label sets (#1047)
* Add support for filtering label sets

* Restore test

* Fix Value() bug

* Pass kv.KeyValue

* Apply suggestions from code review

Thank you @MrAlias.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-11 11:00:23 -07:00
Joshua MacDonald
3a05cd9325
Change Metric Processor to merge multiple observations (#1024)
* Add regexp filter in api/label, test

* Add regexp option to sdk.Config

* Return indistinct values only when keyRe != nil

* Filter in sdk

* Add an accumulator filter test

* SDK tests pass

* Precommit

* Undo set filters

* Backout related filter changes

* Add a new test

* Fix build

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update comments

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-11 10:25:47 -07:00
Tyler Yahn
8f9f2d84cf
Move OTLP to the OTLP exporter (#1050)
* Move proto to OTLP exporter

* Update OTLP exporter import of proto

* Use gogo protobuf

To stop using the deprecated github.com/golang/protobuf and match what
the collector is doing, switch to generating OTLP with the
github.com/gogo/protobuf/proto instead of
github.com/golang/protobuf/proto.

* Clean dependencies

Remove all protobuf dependencies from otel package and all of its
dependencies.

* Update CHANGELOG

* Clean OTLP exporter go mod

Remove submodule beforehand to avoid unneeded direct dependencies.

* Use default ref for GitHub workflow

* Update path that triggers proto gen action

* Correct license-check exclusion for OTLP

* Update commented location of the OTLP and code
2020-08-10 19:55:52 -07:00
Eundoo Song
4d0101ae12
Rename test packages (#1049)
* Rename processor/test to processortest

* Rename controller/test to controllertest

* Rename testharness to apitest

* Rename testtrace to tracetest
2020-08-10 13:35:15 -07:00
Tyler Yahn
efd4e3a383
Remove google.golang.org/grpc/codes dependency from API by adding an equivalent codes package (#1046)
* Add otel/codes package to replace google.golang.org/grpc/codes

* Replace google.golang.org/grpc/codes with otel/codes

* Update opentracing bridge to use OTel codes

* Update semconv to use OTel codes

* Update SDK to convert from OTel codes to gRPC

* go mod tidy

* Add change to CHANGELOG

* Fix word from feedback
2020-08-10 09:17:09 -07:00
Tyler Yahn
2dfa5e4fe1
Remove WithSpan method from Tracer interface (#1043)
* Remove WithSpan method from Tracer interface

Also remove implementation in SDK.

* Add panic event reporting to span End

* Update Changelog with changes

* Update CHANGELOG.md

* Update README.md

Fix code tabs

* Refactor span End

* Fix un-ended span from feedback.
2020-08-08 12:10:36 -07:00
Sam Xie
f9ba15f2d1
Replace WithSyncer with WithBatcher in examples (#1044)
* Replace `WithSyncer` with `WithBatcher` in examples

* update CHANGELOG

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-07 09:16:43 -07:00
Tyler Yahn
1dbc75bc2f
Clean stale indirect dependency requirements (#1041)
* Clean stale indirect dependency requirements

In the recent changes to isolate the main `otel` package there were many
indirect dependencies of the package that were removed, however, the
go.mod was not automatically cleaned of these. This removes those (and
similar ones in the otel-collector example and otel exporter) and prunes
the go.sum files accordingly.

* Run in a clean system to reproduce build
2020-08-07 09:05:22 -07:00
alrex
f88f5e4a1a
Renaming OTEL_RESOURCE_LABELS env var (#1042)
* Renaming OTEL_RESOURCE_LABELS env var

As per the specification here https://github.com/open-telemetry/opentelemetry-specification/pull/758

* update changelog
2020-08-06 17:05:11 -07:00
Tyler Yahn
799c178925
Make opentracing bridge into own Go module (#1038)
* Make opentracing bridge into own Go module

* Update dependabot config

* Clean dependencies of project

Now the bridge is a module, clean all upstream modules that no longer
implicitly depend on it.

* Update Changelog

* go mod tidy
2020-08-06 07:59:41 -07:00
Tyler Yahn
f0620dc0ad
Move grpctrace to contrib repo (#1027)
* Remove grpctrace package

This is being moved to the contrib repo with
https://github.com/open-telemetry/opentelemetry-go-contrib/pull/189
as part of #976.

* Update Changelog

* Remove the grpc example

Moved to contrib repo

* Fix spelling error

* Update Changelog
2020-08-05 20:24:39 -07:00
Matej Gera
ccfa2e7bdf
Fix instrumentation lib version in spanDataToThrift (#1037)
* Fix instrumentation lib version in spanDataToThrift

* Update CHANGELOG.md

* Use test value for lib version in accordance with the spec

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-05 15:42:00 -07:00
Anthony Mirabella
b40fdf174b
Move content length out of basic attributes (#1031)
* Move content length out of basic attributes

semconv.httpBasicAttributesFromHTTPRequest() was including the request's content length,
which is a high-cardinality label.  It ended up in metric labels through the use of that function
by semconv.HTTPServerMetricAttributesFromHTTPRequest().

* Add CHANGELOG entry

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-08-05 13:24:28 -07:00
Tyler Yahn
3780b80214
Remove the oterror package (#1026)
* Break up the oterror package

* Update use of ErrorHandler in project

* Update handler naming and comments
2020-08-05 10:31:42 -07:00