go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-12 10:04:29 +02:00
Code Issues Releases Activity
1,786 Commits 2 Branches 1,724 Tags 65 MiB
2fe8861a24
Commit Graph

1786 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Clawson
86ced11f2c
Bump go.opentelemetry.io/proto/otlp from 0.11.0 to 0.12.0 (#2546) 
* Update go.opentelemetry.io/proto/otlp to v0.12.0

* Changelog

* Update CHANGELOG.md

Fix's md linting

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2022-01-24 11:53:20 -08:00
Aaron Clawson
5f41868675
Un-escape url coding when parsing baggage. (#2529) 
* un-escape url coding when parsing baggage.

* Added changelog

Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2022-01-24 09:17:45 -08:00
Aaron Clawson
d1b6a7d66f
Bump github.com/google/go-cmp from 0.5.6 to 0.5.7 across the project (#2545) 
* update go-cmp to 0.5.7

* fixes go.sums

Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
 2022-01-24 08:35:53 -08:00
thinkgo
4ec3a3476f
Fix getting-started.md Run function (#2527) 
* Fix getting-started.md Run function, it assigns this new context to a variable shared between connections in to accept loop. Thus creating a growing chain of contexts. so every calculate fibonacci request, all spans in a trace.

* add a comment explaining the reason for that new variable

* update example fib
 2022-01-22 08:28:40 -08:00
Jeremy Kaplan
9407bf396e
Fix some typos in docs for Go libraries (#2520) 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2022-01-20 15:08:58 -08:00
Ben Wells
3c2e08ae0b
Fix typo in jaeger example (#2524) 2022-01-19 14:55:55 -05:00
jaychung
0c1f156b5b
emitBatchOverhead should only be used for splitting spans into batches (#2512) 
* emitBatchOverhead should only be used for splitting spans into batches (#2503)

* limit max packet size parameter
 2022-01-18 08:42:24 -08:00
dependabot[bot]
0b03aae0da
Bump github.com/openzipkin/zipkin-go from 0.3.0 to 0.4.0 in /exporters/zipkin (#2514) 
* Bump github.com/openzipkin/zipkin-go in /exporters/zipkin

Bumps [github.com/openzipkin/zipkin-go](https://github.com/openzipkin/zipkin-go) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/openzipkin/zipkin-go/releases)
- [Commits](https://github.com/openzipkin/zipkin-go/compare/v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: github.com/openzipkin/zipkin-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
 2022-01-17 09:06:31 -08:00
Tyler Yahn
73edf3dfcc
Remove old release bash scripts (#2506) 2022-01-11 17:50:58 -05:00
Aaron Clawson
f24f52aa06
Debug Logging for sdk/trace (#2500) 
* Debug Logging for sdk/trace

* Fixes spelling, adds marshaling to attribute sets

Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
 2022-01-10 19:58:01 -05:00
Eric Hsueh
c37f485678
added Float64 CounterObserver and UDCounterObserver tests (#2487) 
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
 2022-01-10 18:22:31 -05:00
Ben Ye
1e4a609495
support zipkin exporter endpoint env (#2490) 
* support zipkin exporter endpoint env

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

* update interface and changelog

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

* add pr number

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

* fix lint

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

* add import

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2022-01-06 08:28:42 -08:00
Tyler Yahn
11ce2ddd24
Fix sporadic test failure in otlp exporter http client tests (#2496) 
* Fix flaky TestTimeout in otlpmetrichttp

* Fix flaky TestTimeout in otlptracehttp
 2022-01-05 17:04:55 -08:00
Chester Cheung
1c1e84614d
fix specify explicit buckets in example (#2493) 
* fix specify explicit buckets in example

* add changelog

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
 2022-01-04 10:33:18 -08:00
Chester Cheung
4b815ff70c
change UploadMetrics signature from slice to single Resource (#2491) 
* change UploadMetrics signature from slice to single Resource

* add changelog

* fix otlp exporter bug.

* Update exporters/otlp/otlpmetric/exporter_test.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2022-01-04 10:14:03 -08:00
Ben Ye
776bfdcb23
add additional batch overhead in jaeger agent udp exporter (#2489) 
* add additional batch overhead in jaeger agent udp exporter

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

* update changelog

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2022-01-04 10:01:53 -08:00
dependabot[bot]
c772d57950
Bump actions/setup-go from 2.1.4 to 2.1.5 (#2485) 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.4 to 2.1.5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v2.1.4...v2.1.5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-01-03 10:09:43 -08:00
Travis Jefferson
4769bbe7d8
Update docs: don't reference WithBuiltinDetectors (#2486) 
* Update docs: don't reference `WithBuiltinDetectors`

The method was removed in 25d739b

* Update docs: use `WithFromEnv()` in example
 2021-12-28 11:34:41 -05:00
Phillip Carter
245f13baac
Add section in docs for initializing a tracer (#2481) 
* Add section in docs for initializing a tracer

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Change weird incomplete sentence

* update some of the bullets to be a tad less opinionated

* Rename section so it's open to different ways to acquire a tracer

* Remove guidance as it is orthogonal

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-23 09:18:08 -08:00
Phillip Carter
109d8531ea
Update relref link in manual instrumentation (#2482) 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-23 08:43:30 -08:00
Bogdan Drutu
9778aa328f
Remove Min/Max unused interfaces from the moved code (#2454) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-23 08:35:32 -08:00
Bogdan Drutu
4aedc1cdaf
Fixes the instrument kind for noop async instruments (#2461) 
* Fixes the instrument kind for noop async instruments

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-22 14:36:17 -08:00
Phillip Carter
49987ad852
Rename manual_instrumentation and add redirects (#2480) 
* Rename manual_instrumentation and add redirects

* Update

* More feedback + name adjustment

* Go back
 2021-12-21 16:11:19 -08:00
Phillip Carter
c555a7b592
Change markdown links to relref (#2479) 2021-12-21 10:49:18 -08:00
Phillip Carter
1e46549f61
Update relref link for manual instrumentation (#2478) 
Looks like this was missed in https://github.com/open-telemetry/opentelemetry-go/pull/2437
 2021-12-21 08:33:35 -08:00
Phillip Carter
69326eaef8
Add sections to docs for current span and nested spans (#2452) 
* Add sections to docs for current span and nested spans

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update based on review

* satisfy linter

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-20 14:00:14 -08:00
Aaron Clawson
8849597744
Dependabot bump (#2477) 
* Bump github.com/go-logr/stdr from 1.2.0 to 1.2.2

Bumps [github.com/go-logr/stdr](https://github.com/go-logr/stdr) from 1.2.0 to 1.2.2.
- [Release notes](https://github.com/go-logr/stdr/releases)
- [Commits](https://github.com/go-logr/stdr/compare/v1.2.0...v1.2.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/stdr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github.com/go-logr/logr from 1.2.1 to 1.2.2

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](https://github.com/go-logr/logr/compare/v1.2.1...v1.2.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github.com/go-logr/stdr from 1.2.0 to 1.2.2 in /example/namedtracer

Bumps [github.com/go-logr/stdr](https://github.com/go-logr/stdr) from 1.2.0 to 1.2.2.
- [Release notes](https://github.com/go-logr/stdr/releases)
- [Commits](https://github.com/go-logr/stdr/compare/v1.2.0...v1.2.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/stdr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump google.golang.org/grpc in /example/otel-collector

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump google.golang.org/grpc in /exporters/otlp/otlpmetric/otlpmetricgrpc

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump google.golang.org/grpc in /exporters/otlp/otlptrace

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump google.golang.org/grpc in /exporters/otlp/otlptrace/otlptracegrpc

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump google.golang.org/grpc in /exporters/otlp/otlpmetric

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-20 08:54:44 -08:00
Chester Cheung
7aba6f796f
update wrong doc comment with attribute value (#2476) 2021-12-20 08:10:34 -08:00
Aaron Clawson
134a610440
Fixes because of removal of exact type. (#2459) 
Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
 2021-12-16 15:22:53 -05:00
Bogdan Drutu
4654d78104
Move Aggregator interface to aggregator package (#2444) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-15 08:13:48 -08:00
Bogdan Drutu
4702f6fd6f
Deprecate and add warning to remove AtomicFieldOffsets, unnecessary public func (#2445) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-15 08:01:14 -08:00
Bogdan Drutu
8f4a47732f
nit: Simplify test condition in trace_test.go (#2448) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-15 07:42:37 -08:00
Sam Xie
24aecc561d
Update affiliation for Sam Xie (#2458) 2021-12-15 08:45:53 -06:00
Bogdan Drutu
44bb795e78
nit: Change metrics configs to have funcs on pointers (#2451) 
This avoids copying the whole object, also consistent with trace.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-14 13:15:53 -08:00
Bogdan Drutu
db762533f9
Remove unused internal interfaces (#2447) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
 2021-12-14 12:27:23 -08:00
Phillip Carter
43daab9cab
Add 'Using instrumentation libraries' page for docs (#2437) 
* Add automatic instrumentation page for docs

* Update website_docs/automatic_instrumentation.md

Co-authored-by: Sam Xie <xsambundy@gmail.com>

* Updates as per feedback

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update website_docs/using_instrumentation_libraries.md

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* fix docs build

Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
 2021-12-14 08:46:15 -08:00
Bogdan Drutu
01fe5328f7
Small nit in comments (#2446) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
 2021-12-14 08:27:56 -08:00
Bogdan Drutu
6cafa6a060
Remove sdk/export/metric module, embed into the sdk/metric (#2382) 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
 2021-12-13 12:13:03 -08:00
Anthony Mirabella
aedef05e95
Release prep v1.3.0 (#2441) 
* Update versions.yaml for release

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Prepare stable-v1 for version v1.3.0

* Prepare experimental-metrics for version v0.26.0

* Prepare bridge for version v0.26.0

* Update CHANGELOG

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
 2021-12-10 11:44:16 -05:00
Tyler Yahn
b46019a0b0
Fix Jaeger exporter status conversion (#2440) 
* Fix Jaeger exporter status conversion

The status tag needs to be a string of value `ERROR` or `OK` for Error
and Ok statuses respectively according to the OTel spec.

* Add PR number to changelog
 2021-12-10 11:36:56 -05:00
Tyler Yahn
931266483d
Fix per-signal endpoint parsing in OTLP exporters (#2433) 
* Fix per-signal endpoint parsing in otlptrace

* Add distinguishing non-per-signal env var value

* Fix per-signal endpoint parsing in otlpmetric

* Add changes to changelog

* Use else if to prevent unnecessary work

* Add spec link to otlptrace README
 2021-12-09 10:40:30 -08:00
Tyler Yahn
b177541239
Use host root CA set by default for OTLP exporter (#2432) 
* Use host CA set by default for otlptrace

* Remove test for invalid default certs

* Default to host CA for otlpmetric

* Add changes to changelog

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
 2021-12-09 08:44:20 -08:00
Aaron Clawson
2b7c650672
Merge pull request #2424 from MadVikingGod/refactor-errorhandler 
Refactor ErrorHandler
 2021-12-06 15:24:43 -06:00
Aaron Clawson
c3513021f4 Merge branch 'main' into refactor-errorhandler 2021-12-06 20:37:09 +00:00
Chester Cheung
a4f183be31
Remove metric MinMaxSumCount kind aggregation (#2423) 
* remove metric MinMaxSumCount kind aggregation

* remove related files

* fix unittest

* fix changelog

* remove reference the removed aggregation type

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
 2021-12-06 11:47:40 -08:00
dependabot[bot]
ee60bcc31b
Bump github.com/itchyny/gojq from 0.12.5 to 0.12.6 in /internal/tools (#2430) 
* Bump github.com/itchyny/gojq from 0.12.5 to 0.12.6 in /internal/tools

Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.5 to 0.12.6.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.12.5...v0.12.6)

---
updated-dependencies:
- dependency-name: github.com/itchyny/gojq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
 2021-12-06 08:51:55 -08:00
dependabot[bot]
a7b3c37988
Bump golang.org/x/tools from 0.1.7 to 0.1.8 in /internal/tools (#2429) 
* Bump golang.org/x/tools from 0.1.7 to 0.1.8 in /internal/tools

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.1.7 to 0.1.8.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.1.7...v0.1.8)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
 2021-12-06 08:09:04 -08:00
dependabot[bot]
ae76e71024
Bump github.com/go-logr/logr from 1.2.0 to 1.2.1 (#2428) 
* Bump github.com/go-logr/logr from 1.2.0 to 1.2.1

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](https://github.com/go-logr/logr/compare/v1.2.0...v1.2.1)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
 2021-12-06 07:59:58 -08:00
Tyler Yahn
31661dd6be
Centralize the retry package for the otlp exporters (#2427) 
* Centralize the retry package for the otlp exporters

* Add dependabot config

* Use unified internal/retry module in otlp exporters

* Remove otlpmetric and otlptrace internal/retry module

* Run go mod tidy in otlp{metric,trace}
 2021-12-06 07:47:49 -08:00
Tyler Yahn
f4b63f184d
Use gRPC ClientConn for otlpmetricgrpc client connection handling (#2425) 
* Use gRPC ClientConn for otlpmetricgrpc conn handling

* Update PR number

* Update otlpmetrichttp to use retry package

* Remove old commented code

* Add all other external changes to changelog
 2021-12-03 13:59:07 -08:00