1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-14 10:13:10 +02:00
Commit Graph

940 Commits

Author SHA1 Message Date
David Ashpole
304d4cdffc
ensure batch span processors are shutdown in examples (#1199) 2020-09-24 18:25:20 -04:00
Tyler Yahn
1e72b51b31
Add example test for a custom SpanProcessor (#1196)
* Add example test for a custom SpanProcessor

* Use existing test framework exporter

* Update example

* Add fixes from upstream
2020-09-24 18:20:18 -04:00
huikang
b97533a74b
Register/unregister in the fixed order (#1198)
- change the processors' map to array
- increase test coverage

Signed-off-by: Hui Kang <kangh@us.ibm.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-24 11:43:23 -07:00
Dan Rusei
559fecd73e
Update the attribute names for the OTel attributes for the zipkin exporter (#1201)
Based on the spec change: https://github.com/open-telemetry/opentelemetry-specification/pull/967
2020-09-23 22:42:05 -04:00
Tyler Yahn
7d71867644
Rename *Provider names (#1190)
* Rename *Provider names

There is overlap in naming with MeterProviders and TracerProviders. This
is means the specification is not implemented and these types can not
exist in the same package (#1179). This makes each type and related
functions and types explicit.

* Add changes to CHANGELOG
2020-09-23 18:16:13 -04:00
Cole Packingham
5dd2962202
Remove semantic convention for http status text (#1194)
* Remove http status text

* Updated changelog

* More descriptive changelog

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-23 14:52:44 -04:00
ET
038f505d12
Remove B3 propagator from otel repo (#1191)
* Remove B3 propagator

* Add to Changelog

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-22 11:02:31 -07:00
ET
e7e1dce982
Update sampling decision names (#1192)
* Rename SamplingDecision enum values

As prescribed in
https://github.com/open-telemetry/opentelemetry-specification/pull/938
and https://github.com/open-telemetry/opentelemetry-specification/pull/956.

* Include in Changelog

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-22 10:34:43 -07:00
Anthony Mirabella
b9357d7ee2
Remove flaky BatchSpanProcessor.ForceFlush() test (#1189)
It is unreliable with no clear good way to make it reliable.  The
ForceFlush() method is a simple passthrough to bsp.exportSpans() and the
existing tests of that method should suffice.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-21 13:30:49 -07:00
dependabot[bot]
fa741472e7
Bump google.golang.org/api from 0.31.0 to 0.32.0 in /exporters/trace/jaeger (#1188)
* Bump google.golang.org/api in /exporters/trace/jaeger

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.31.0 to 0.32.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.31.0...v0.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-21 12:06:05 -04:00
Tyler Yahn
4b46365d1d
Move api/unit to top level (#1185)
* Move api/unit to top level

* Add changes to CHANGELOG
2020-09-20 13:54:21 -04:00
huikang
930b4d01f6
Fix missing shutdown of the batch processor (#1186)
Signed-off-by: Hui Kang <kangh@us.ibm.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-20 13:40:47 -04:00
Anthony Mirabella
995be31f42
Add ForceFlush() method to SpanProcessor interface (#1166)
* Add ForceFlush() method to SpanProcessor interface

* Add a stub implementation to SimpleSpanProcessor
* Add a working implementation to BatchSpanProcessor

* add CHANGELOG.md entry

* Eliminate sleep from BatchSpanProcessor.ForceFlush() test

* Generating test spans serially should reduce test flakiness
2020-09-20 13:35:44 -04:00
Matej Gera
a12224a454
Ensure exported interfaces have named method parameters (#1172)
* Ensure exported interface types have named arguments

* Update Styling Guide

* update CHANGELOG
2020-09-16 09:09:45 -07:00
JBD
2621bd4847
Convert XConfigure into constructor for metrics (#1175)
* Convert XConfigure into constructor for metrics

A follow up of #1155.

* Add to CHANGELOG

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-15 07:49:18 -07:00
JBD
3de7a07089
Merge otel into one file and add package doc (#1176)
No need to split a tiny package into multiple files. Also adding package doc for the otel package.
2020-09-14 19:35:21 -04:00
Matej Gera
1f7c220652
Don't consider unset env var to be an error during resource detection (#1170)
* Don't consider unset env var an error during detection

* update CHANGELOG
2020-09-14 12:08:05 -04:00
Matej Gera
77de1998cf
Minor change: ParentSampler -> ParentBased in Zipkin example description (#1171)
* ParentSampler -> ParentBased in Zipkin example description

* update CHANGELOG
2020-09-13 14:45:46 -04:00
Sam Xie
6f048eb832
Add more semantic conventions for k8s as resource attributes (#1167)
* Add more semantic conventions for k8s

* Update CHANGELOG

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-11 14:46:24 -07:00
Anthony Mirabella
d91de437b2
Recommend use of initializers for config structs (#1163)
* Recommend use of initializers for config structs

Updates style guide and changes existing configure() implementations to
newConfig() as appropriate.

* Add CHANGELOG.md entry

* Update stdout exporter config initializer

* Add documentation to exported functions

* Convert otlp.Config to unexported otlp.config
2020-09-11 14:14:25 -07:00
ET
c9726efd60
Allow up to 0.5% coverage change before failing build (#1162)
Don't bother to add a report unless there has been a coverage change.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-10 12:49:08 -07:00
Matej Gera
0041e2d26e
Rename ParentOrElse sampler to ParentBased and enhance it according to the spec (#1153)
* Rename ParentOrElse to ParentBased and enhance it according to the spec

- Renaming of type and sampler function
- Enhancing ParentBased with sampler options
- Set default samplers for each applicable parent-based case
- Adjust ShouldSample(...) func accordingly

* Adjust existing tests for ParentBased and add new ones

- add tests for ParentBased sampler options and description
- renaming in trace_test.go

* Update CHANGELOG.md

* PR feedback

- More clearer naming of structs; add comments where missing
- Adhere to the configuration style guide

* PR feedback - punctuation
2020-09-10 12:39:04 -07:00
ET
34c02d1d24
Add Skip Changelog label to Dependabot-sourced PRs (#1161)
* Add "Skip Changelog" label to all dependabot PR requests

* Update CHANGELOG

* Include PR# in CHANGELOG

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-10 12:24:04 -07:00
JBD
9f4525847f
Convert XConfigure into constructors (#1155)
* Convert XConfigure into constructors

Previously, we discussed the possibility of converting
the config types into internal ones. But due to the
cyclic dependencies it introduces, we are only
converting XConfigure into constructors and document that
XConfig types are most likely are not going to be directly
used by developers.

In package documents, constructors will be nicely listed
under the config types and they won't be yet another
standalone symbol developers need to learn about.

Fixes #1130.

* Add the changes to the CHANGELOG
2020-09-10 15:15:17 -04:00
Anthony Mirabella
a787f09536
Update CONTRIBUTING.md to reflect PR process-as-applied (#1159) 2020-09-10 14:42:49 -04:00
JBD
36c323ffca
Add the missing vanity import path directive (#1157) 2020-09-10 06:29:21 -04:00
JBD
7fac2795b6
Rename package.go to doc.go for consistency (#1156) 2020-09-10 01:01:43 -04:00
JBD
4c5f8348c3
Document make test for testing (#1154)
Fixes #1140
2020-09-10 00:53:27 -04:00
Anthony Mirabella
06689a01bd
Rename CorrelationContext to Baggage (#1142)
* Rename 'correlation' to 'baggage'

* Rename CorrelationContext progator to Baggage

* Update CHANGELOG
2020-09-09 14:13:37 -04:00
dependabot[bot]
9a4981cc67
Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /sdk (#1145)
* Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /sdk

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.1...v1.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aneurysm9 <Aneurysm9@users.noreply.github.com>
Co-authored-by: Anthony J Mirabella <a9@aneurysm9.com>
2020-09-09 13:25:27 -04:00
Tyler Yahn
422188a85f
Correct SDK trace Exporter interface (#1078)
* Update trace export interface

Move to conforming to the specification.

* Update documentation in export trace

* Update sdk trace provider to support new trace exporter

* Update SpanProcessors

Support the Provider changes and new trace exporter.

* Update the SDK to support the changes

* Update trace Provider to not return an error

* Update sdk with new Provider return

Also fix the testExporter ExportSpans method

* Update exporters with changes

* Update examples with changes

* Update Changelog

* Move error handling to end of shutdown

* Update exporter interface

Rename to SpanExporter to match specification. Add an error return value
to the Shutdown method based on feedback. Propagate these changes.

Remove the Stop method from the OTLP exporter to avoid confusion and
redundancy.

* Add test to check OTLP Shutdown honors context

* Add Jaeger exporter test for shutdown

* Fix race in Jaeger test

* Unify shutdown behavior and testing

* Update sdk/trace/simple_span_processor.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 10:19:03 -07:00
dependabot[bot]
da96fd0c5e
Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/otlp (#1146)
* Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/otlp

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.1...v1.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 13:06:59 -04:00
dependabot[bot]
a1b43b4b03
Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/stdout (#1148)
* Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/stdout

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.1...v1.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 13:02:31 -04:00
dependabot[bot]
932638697a
Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/trace/jaeger (#1151)
* Bump google.golang.org/grpc in /exporters/trace/jaeger

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.1...v1.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 12:58:23 -04:00
dependabot[bot]
71a1b233b2
Bump github.com/golangci/golangci-lint from 1.30.0 to 1.31.0 in /internal/tools (#1152)
* Bump github.com/golangci/golangci-lint in /internal/tools

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.30.0...v1.31.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 12:49:55 -04:00
dependabot[bot]
e58e347f93
Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/trace/zipkin (#1149)
* Bump google.golang.org/grpc in /exporters/trace/zipkin

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.1...v1.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 12:41:45 -04:00
dependabot[bot]
dd3d4f2ae0
Bump github.com/openzipkin/zipkin-go from 0.2.3 to 0.2.4 in /exporters/trace/zipkin (#1150)
* Bump github.com/openzipkin/zipkin-go in /exporters/trace/zipkin

Bumps [github.com/openzipkin/zipkin-go](https://github.com/openzipkin/zipkin-go) from 0.2.3 to 0.2.4.
- [Release notes](https://github.com/openzipkin/zipkin-go/releases)
- [Commits](https://github.com/openzipkin/zipkin-go/compare/v0.2.3...v0.2.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-09-09 12:29:08 -04:00
dependabot[bot]
2f0538ac37
Bump google.golang.org/grpc in /example/otel-collector (#1147)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.31.1...v1.32.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-09 12:21:55 -04:00
Anthony Mirabella
2e221fdf3e
Move tools package under internal (#1141)
It is not user-facing, so there is no reason to leave it in an
importable location. Fixes #1126.
2020-09-09 09:14:03 -07:00
Anthony Mirabella
1d2189088d
Add workflow to check for presence of CHANGELOG changes on PRs (#1067) 2020-09-08 20:50:05 -04:00
JBD
a2c75c6d78
Unexport NoopXXX trace types (#1134)
* Unexport NoopXXX trace types

The change unexports the noop implementations and provide the NoopProvider function for user to construct noop providers. Users can access noop tracer and noop spans by using the provider.

This change removes the types users should never be directly using from the package. It improves the usability of the API by reducing the API surface to half and helping the user to focus on the canonical APIs.

Fixes #1133

* Provide noop tracer and span for internal use

* Remove obsolete doc

* Use noop span instead of nil

* Fix the broken  build
2020-09-08 20:43:35 -04:00
Tyler Yahn
f1dad21e47
Move propagators out of API and into their own package (#1118)
* Add new propagators package

* Move B3 propagator to propagators

Update all `api/trace` dependencies in the propagator.

Export the isDeferred and isDebug methods of the SpanContext. These are
needed by the B3 propagator to track trace state.

* Move W3C trace context propagator to propagators

* Update package docs with supported encodings

* Move unified propagators code to own file

* Update b3 exported documentation

* Update trace_context exported documentation

* Add code examples for B3 propagator

* Add TraceContext example code

* Remove internal package

Move common testing declarations to the propagators_test.go file.

* Add changes to Changelog

* Add test to check default propagators
2020-09-08 19:07:59 -04:00
Sam Xie
bc1a59274f
Add a test for jaeger udp client (#1137) 2020-09-08 18:38:17 -04:00
dependabot[bot]
224629bd0b
Bump google.golang.org/api from 0.30.0 to 0.31.0 in /exporters/trace/jaeger (#1124)
* Bump google.golang.org/api in /exporters/trace/jaeger

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.30.0 to 0.31.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.30.0...v0.31.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-08 09:03:17 -07:00
JBD
b0f978c307
Add receiver names to TraceContext methods (#1136)
Otherwise, they are no aligned together on godoc.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-08 08:20:14 -07:00
JBD
9ad4824394
Added missing package document and canonical import paths (#1125)
Also simplified the first lines of some package docs
to focus on what the package provides instead of
explaining the implementation details.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-08 08:15:28 -07:00
JBD
74357106b0
Add missing argument names to the Span interface (#1135)
Even though arbitrary-looking, new developers need to rely on docs
to figure out the arguments. Self document them by naming.
2020-09-08 08:07:53 -07:00
Tyler Yahn
d143b8fbf8
Unify API Span Start/End Options (#1108)
* Unify API Span Start/End Options

Replace both with `SpanOption`. Add a unified `SpanConfig` to match and
a `SpanConfigure` function to parse a `SpanConfig` from `SpanOption`s.

Update all the related options to use new `SpanOption`s.

* No non-zero SpanConfig defaults

The SDK uses an internal clock for the current time that cannot be use
if it does not know the time has not been set.

* Append attributes for WithAttributes

This preserves existing behavior.

* Add unit test for SpanConfigure

* Propagate changes

* Update append option documentation

* Update testing comments

* Move comments on guarantees to appropriate function

* Add documentation for SDK methods

Include SDK implementation specific information in the Tracer Start
method and Span End method.

* Add changes to Changelog

* Apply suggestions from code review

Co-authored-by: ET <evantorrie@users.noreply.github.com>

* Update the SpanKind comment in the  SpanConfig

Try for a less tautological comment.

Co-authored-by: ET <evantorrie@users.noreply.github.com>
2020-09-03 07:34:36 -07:00
ET
4d83d5b571
Change name of ProbabilitySampler to TraceIdRatioBased (#1115)
* Change name of ProbabilitySampler to TraceIdRatioBased

* Modify behavior to ignore parent span
* Add test for inclusivity property on TraceIdRatioBased sampler
* Modify tests in `trace_test.go` to reflect change in parent
  span behavior

* Add to CHANGELOG

* Satisfy golint

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-09-03 07:28:01 -07:00
ET
f38e1902f9
Add InstrumentationLibrary info to Zipkin/Jaeger exporters (#1119)
* Add InstrumentationLibrary info to Zipkin/Jaeger exporters

This addresses spec issues
 https://github.com/open-telemetry/opentelemetry-specification/pull/800
 https://github.com/open-telemetry/opentelemetry-specification/pull/801
and opentelemetry-go issues
 https://github.com/open-telemetry/opentelemetry-go/issues/1086
 https://github.com/open-telemetry/opentelemetry-go/issues/1087

* Reflect change in CHANGELOG
2020-09-03 07:22:05 -07:00