1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-01-14 02:33:21 +02:00
Commit Graph

16 Commits

Author SHA1 Message Date
Tyler Yahn
e8c22e6e71
Add TestSpanStartConfigAttributeMutability (#5591)
Follow up to #5567. Test the immutability of configured attributes.

Co-authored-by: Sam Xie <sam@samxie.me>
2024-07-10 12:02:01 -07:00
Damien Mathieu
83c61f521f
Extend trace config benchmarks to run each option individually (#5566)
This extends the trace API new traces, span and event benchmarks into
sub benchmarks, so each option is tested individually rather than all of
them together.

```
open-telemetry/opentelemetry-go/trace›  git:(extend-trace-config-benchmarks) go test -v -bench=Config -run Benchmark
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/trace
BenchmarkNewTracerConfig
BenchmarkNewTracerConfig/with_no_options
BenchmarkNewTracerConfig/with_no_options-10             558777036                2.021 ns/op           0 B/op          0 allocs/op
BenchmarkNewTracerConfig/with_an_instrumentation_version
BenchmarkNewTracerConfig/with_an_instrumentation_version-10             91590230                13.09 ns/op            0 B/op          0 allocs/op
BenchmarkNewTracerConfig/with_a_schema_url
BenchmarkNewTracerConfig/with_a_schema_url-10                           89374104                13.07 ns/op            0 B/op          0 allocs/op
BenchmarkNewSpanStartConfig
BenchmarkNewSpanStartConfig/with_no_options
BenchmarkNewSpanStartConfig/with_no_options-10                          288158400                4.187 ns/op           0 B/op          0 allocs/op
BenchmarkNewSpanStartConfig/with_attributes
BenchmarkNewSpanStartConfig/with_attributes-10                          26750458                45.20 ns/op           64 B/op          1 allocs/op
BenchmarkNewSpanStartConfig/with_attributes_set_multiple_times
BenchmarkNewSpanStartConfig/with_attributes_set_multiple_times-10       11745048               102.4 ns/op           192 B/op          2 allocs/op
BenchmarkNewSpanStartConfig/with_a_timestamp
BenchmarkNewSpanStartConfig/with_a_timestamp-10                         55898018                21.38 ns/op            0 B/op          0 allocs/op
BenchmarkNewSpanStartConfig/with_links
BenchmarkNewSpanStartConfig/with_links-10                               19950262                60.21 ns/op           96 B/op          1 allocs/op
BenchmarkNewSpanStartConfig/with_links_set_multiple_times
BenchmarkNewSpanStartConfig/with_links_set_multiple_times-10             8129803               141.6 ns/op           272 B/op          2 allocs/op
BenchmarkNewSpanStartConfig/with_new_root
BenchmarkNewSpanStartConfig/with_new_root-10                            43815543                27.46 ns/op            0 B/op          0 allocs/op
BenchmarkNewSpanStartConfig/with_span_kind
BenchmarkNewSpanStartConfig/with_span_kind-10                           43276576                27.49 ns/op            0 B/op          0 allocs/op
BenchmarkNewSpanEndConfig
BenchmarkNewSpanEndConfig/with_no_options
BenchmarkNewSpanEndConfig/with_no_options-10                            286546008                4.155 ns/op           0 B/op          0 allocs/op
BenchmarkNewSpanEndConfig/with_a_timestamp
BenchmarkNewSpanEndConfig/with_a_timestamp-10                           55678317                21.26 ns/op            0 B/op          0 allocs/op
BenchmarkNewSpanEndConfig/with_stack_trace
BenchmarkNewSpanEndConfig/with_stack_trace-10                           57029929                20.80 ns/op            0 B/op          0 allocs/op
BenchmarkNewEventConfig
BenchmarkNewEventConfig/with_no_options
BenchmarkNewEventConfig/with_no_options-10                              25571608                46.08 ns/op            0 B/op          0 allocs/op
BenchmarkNewEventConfig/with_attributes
BenchmarkNewEventConfig/with_attributes-10                              13868670                80.87 ns/op           64 B/op          1 allocs/op
BenchmarkNewEventConfig/with_attributes_set_multiple_times
BenchmarkNewEventConfig/with_attributes_set_multiple_times-10            8357275               143.2 ns/op           192 B/op          2 allocs/op
BenchmarkNewEventConfig/with_a_timestamp
BenchmarkNewEventConfig/with_a_timestamp-10                             80229771                14.77 ns/op            0 B/op          0 allocs/op
BenchmarkNewEventConfig/with_a_stacktrace
BenchmarkNewEventConfig/with_a_stacktrace-10                            21965215                54.93 ns/op            0 B/op          0 allocs/op
PASS
ok      go.opentelemetry.io/otel/trace  24.862s
```

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
2024-07-08 16:14:15 +02:00
Robert Pająk
7dea232a46
[chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
Charlie Le
1b55281859
docs(typos): Run codespell to fix typos (#3980)
* docs(typos): Run codespell to fix typos

There were a lot of typos through the repository, so I ran
[codespell][], a tool for automatically fixing typos, to fix them.

```console
make codespell
```

There's already a tool called [misspell][] that's supposed to take care
of this, but misspell hasn't been updated for 6 years, and it doesn't
seem to be catching any of the typos that codespell can.

[codespell]: https://github.com/codespell-project/codespell
[misspell]: https://github.com/client9/misspell

* Revert and ignore spelling for Consequentially

* Add GH workflow for codespell

* Revert GH Workflow and Makefile for codespell

Per @pellared, since there's no instructions for setting up codespell,
it was suggested that the changes for setting up a workflow and section
in Makefile include instructions for setting up codespell as well.

* Revert spelling on consequently

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-04-11 17:28:13 -07:00
Tyler Yahn
99ec432679
Accept scope attributes during Tracer creation (#3739)
* Accept scope attributes during Tracer creation

The OTel specification requires the instrumentation attributes are
accepted by the API for the Tracer. This adds a TracerOption to satisfy
that requirement.
2023-02-21 13:31:37 -06:00
Aaron Clawson
7aba25d651
Revert Adding attributes to the instrumentation scope.
Revert "Add instrumentation scope attributes (#3131)" (#3154)

This reverts commit 0078faeb0e.

Revert "Add WithScopeAttributes MeterOption to metric API package (#3132)"

This reverts commit 81a9bab814.
2022-09-09 09:06:58 -05:00
Tyler Yahn
0078faeb0e
Add instrumentation scope attributes (#3131)
* Add WithScopeAttributes TracerOption to trace API

* Add Attributes field to instrumentation Scope

* Use scope attributes for new Tracer

* Fix stdouttrace expected test output

* Allow unexported Set fields in sdk/trace test

* Export instrumentation scope attrs in OTLP

* Add changes to the changelog

* Fix imports with make lint

* Add unit tests for WithScopeAttributes

* Fix English in Scope documentation
2022-08-31 15:19:50 -07:00
Tyler Yahn
bd817df68c
Change Options to accept type not pointer (#2558)
* Change trace options to accept type not pointer

Add benchmark to show allocation improvement.

* Update CONTRIBUTING.md guidelines

* Update all Option iface

* Fix grammar in CONTRIBUTING
2022-02-01 15:51:23 -06:00
Tyler Yahn
1f527a52ab
Update trace API config creation functions (#2212)
* Update trace API config creation funcs

Follow our style guide and return the config struct instead of pointers.

* Update changelog with changes

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-09-01 15:44:13 -04:00
Bhautik Pipaliya
dfc866bd03
Support capturing stack trace (#2163)
* capturing stack trace support

* added changelog entry

* remove error package stack trace support

* modified unnecessary changes to go.sum files

* added EventOption to enable stack trace capturing

* added tests

* added runtime.Stack method and minor changes

* minor changes

* remove redundant line

* fix gihub check on linter

* fix tests

* fix tests

* Update sdk/trace/trace_test.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update sdk/trace/trace_test.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-08-13 17:44:18 -04:00
Tigran Najaryan
bd935866f4
Add schema URL support to Tracer (#1889)
This adds support for schema URL to the Tracer according to the specification:
https://github.com/open-telemetry/opentelemetry-specification/pull/1666
(Link to replaced by the link to the spec after that PR is merged)

For the future: once the proto is updated we will need to populate the
schema_url field in the messages.
2021-05-27 15:22:38 -04:00
Aaron Clawson
c1f460e097
Update API configs. (#1921)
* Added Reason to Contributing and Updated TracerConfig

* PR comment fixup

* Changed how span Options work.

* Fix Markdown linting

* Added meter configs.

* Fixes from PR comments

* fix for missing instrument

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-05-27 07:53:56 -07:00
ET
3684191338
Remove WithRecord() option from trace.SpanOption when starting a span (#1660)
* Remove `WithRecord()` option from SpanConfig options

This brings the trace API into conformance with the specification.

* Add entry to CHANGELOG

Fixes #192

* Updated CHANGELOG with PR#

* Cleaned up CHANGELOG notes

* fixup! Merge remote-tracking branch 'upstream/main' into remove-with-record

* Use new spanContext API to set traceflags, tracestate

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-03-09 09:45:09 -08:00
Anthony Mirabella
e88a091a72
Make SpanContext Immutable (#1573)
* Make SpanContext Immutable

* Adds NewSpanContext() constructor and SpanContextConfig{} struct for
constructing a new SpanContext when all fields are known
* Adds With<field>() methods to SpanContext for deriving a SpanContext
with a single field changed.
* Updates all uses of SpanContext to use the new API

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Update CHANGELOG.md

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Add tests for new SpanContext constructor and derivation

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Address PR feedback

* Fix new uses of SpanContext from main
2021-03-09 08:17:29 -08:00
Punya Biswal
ecf65d7968
Rename otel/label -> otel/attribute (#1541)
* Rename otel/label -> otel/attr

Leave the imported name alone, to avoid a large diff and conflicts

* Better import comment

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* otel/attr -> otel/attribute

* Missed the changelog entry

* Get rid of import renaming

* Merge remaining conflicts

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-02-18 12:59:37 -05:00
Krzesimir Nowak
3268501910
Move tracing code to trace package (#1307)
* Move tracing code to trace package

* Update changelog
2020-11-06 17:13:31 -05:00