1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-12 10:04:29 +02:00
Commit Graph

997 Commits

Author SHA1 Message Date
Kanji Yomoda
e6537c6aa6
Fix typo in comment (#951)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-20 08:49:35 -07:00
YANYZP
99c299877d
OT resource detector (#939)
* first

* all included

* constant

* res keys

* env detector

* Update sdk/detect/env.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* new test cases and strings operation to handle labels

* solved conflict

* typo

* corrected comments

* deleted env var handling

* push again

* rerun

* restructuring

* new way to aggregate errors

* all in resources package and verbose comments

* solved merge conflicts

* included new error types

* improved error handling

* updated changelog.md

* updated changelog

* updated changelog.md

* updated changelog

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-20 08:43:51 -07:00
Liz Fong-Jones
b2b23e15e5
supports marshaling values as json (#948) 2020-07-17 16:10:19 -04:00
Michal Hruby
d6ad4d4d6e
[jaeger] Stop ignoring uints (#945)
* Stop ignoring uints

* Ignore values that overflow
2020-07-17 09:00:58 -07:00
ET
4f3fab3ba7
Remove github.com/open-telemetry/opentelemetry-collector dependency (#943) 2020-07-16 17:18:45 -04:00
ET
166c703bd0
Import open-telemetry/opentelemetry-proto submodule and generate protobuf bindings locally (#942)
* Import open-telemetry/opentelemetry-proto submodule under internal

* Commit changes in updated/new protobuf files

* Refer to new location of .pb.go files after rewrite from import

* Describe in CHANGELOG
2020-07-16 13:59:14 -07:00
ET
dd79483e20
Create protobuf generation GitHub action (#938)
* Add protogen workflow

* Move out protobuf generation to Makefile.proto

* Include in Changelog

* Update Makefile.proto

Move file-local mode variable to line by itself.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-16 10:07:59 -07:00
dependabot[bot]
31dd06af9d
Bump github.com/golangci/golangci-lint from 1.28.2 to 1.28.3 in /tools (#936)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-07-14 12:03:45 -04:00
Tyler Yahn
9edcad3829
Backport tag script from contrib repo (#934)
Also, update the releasing docs to match new command and clean up new
structure.
2020-07-13 16:09:59 -04:00
Tyler Yahn
aff7a80d5a
Release v0.8.0 (#929)
* Prepare for releasing v0.8.0

* Update Changelog

* Update Changelog
2020-07-10 09:23:53 -07:00
dependabot[bot]
9e99b441d2
Bump github.com/golangci/golangci-lint from 1.28.1 to 1.28.2 in /tools (#930)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
2020-07-10 10:35:48 -04:00
Michal Hruby
4dec0addb0
[jaeger] Added WithBatchMaxCount as an option (#931) 2020-07-10 10:28:45 -04:00
Tyler Yahn
d979977a40
Add semantic conventions for OS process as resource attributes (#919)
* Add sem-conv for OS process as resource attr keys

Resolves #891

* Add PR number to Changelog

* Apply suggestions from code review

Co-authored-by: ET <evantorrie@users.noreply.github.com>

* Update comments to Linux

Co-authored-by: ET <evantorrie@users.noreply.github.com>
2020-07-09 15:02:03 -07:00
Tyler Yahn
54fffd6467
Update grpctrace instrumentation span names (#922)
* Update grpctrace instrumentation span names

Span names MUST not contain the leading slash (`/`) that the grpc
package prepends to all `FullMethod` values. This replaces the
`serviceFromFullMethod` function with a parsing function. This parsing
function returns an span name adhering to the OpenTelemetry semantic
conventions as well as formatted span attributes.

Additionally, the service name needs to include the package if one
exists. This updates that attribute accordingly.

Once #900 is merged the method attributes can be added by uncommenting.

Resolves #916

* Update Changelog

* Update comment to plural

* Switch from regexp to string parsing

* Consolidate attributes before creating span

* Update Changelog with addition of rpc.method in grpctrace

* Fix test spanMap lookup key

* Update instrumentation/grpctrace/interceptor.go

Co-authored-by: ET <evantorrie@users.noreply.github.com>

* Unify on explicit typed return value

* Fix copy paste error

Co-authored-by: ET <evantorrie@users.noreply.github.com>
2020-07-09 13:12:00 -07:00
dependabot[bot]
d2913b735c
Bump google.golang.org/api from 0.28.0 to 0.29.0 in /exporters/trace/jaeger (#925)
* Bump google.golang.org/api in /exporters/trace/jaeger

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.28.0...v0.29.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-09 12:09:18 -07:00
Anthony Mirabella
c719588733
Avoid replacing existing correlation map data in context when correlation context extractor does not find any valid data (#923)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-09 12:02:49 -07:00
Tyler Yahn
fab431e455
Fix api/standard constant names and documentation (#920)
* Update spec version sem-conv implement in doc.go

* Update FaaS key const names to match convention

* Add PR number to Changelog
2020-07-09 11:56:47 -07:00
dependabot[bot]
cf6462c01e
Bump github.com/itchyny/gojq from 0.10.4 to 0.11.0 in /tools (#926)
* Bump github.com/itchyny/gojq from 0.10.4 to 0.11.0 in /tools

Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.10.4 to 0.11.0.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/master/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.10.4...v0.11.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-07-09 10:26:53 -07:00
Sam Xie
03cd779f0e
Add http content size semantic conventions (#905)
* Add http content size to standard package

Signed-off-by: Sam Xie <xsambundy@gmail.com>

* Include `http.request_content_length` in HTTP request basic attributes

Signed-off-by: Sam Xie <xsambundy@gmail.com>

* Add test for api.standard package

Signed-off-by: Sam Xie <xsambundy@gmail.com>

* Update CHANGELOG

Signed-off-by: Sam Xie <xsambundy@gmail.com>

* Fix http content size naming

Signed-off-by: Sam Xie <xsambundy@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-08 10:39:15 -07:00
Matej Gera
1c9aab619d
Extend semantic convetions for RPC (#900)
* Extend semantic convetions for RPC

* Update changelog

* make service attribute conform to spec

* Update api/standard/trace.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-08 08:26:09 -07:00
Tyler Yahn
918c6547c9
Update Changelog with omitted changes (#921) 2020-07-08 07:57:56 -07:00
Tyler Yahn
c506e99b01
Fix B3 propagator and add tests (#882)
* Correct B3 propagators and add tests

* Break up external integration and internal unit tests

* Add changes to Changelog.

* Update Changelog with PR number

* Fix lint issues

* Update trace flags

Add a new "not sampled" mask to complement the existing "sampled" one.

Rename `FlagsUnused` to `FlagsUnset`.

Add documentation for each of the flags to help understand their
purpose.

* Update extractSingle to support unset sampling

* Update existing tests to appropriately use FlagsUnset

* Remove bogus debug flag test

The B3 specification states "Debug is encoded as `X-B3-Flags: 1`. Absent
or any other values can be ignored", so testing of other values should
not result in an error.

* B3 Extract now supports parsing both headers

Remove test cases that would fail if the fallback header format was
expected to not be used.

* Feedback

* Switch to bitmask inject encoding field

Add the B3Encoding and valid HTTP based values. Change the B3 propagator
to use these bitmask fields to specify the inject encoding it will
propagate.

* Add comments

* Migrate B3 integration tests to existing testtrace

* Update comment

* Benchmark invalid B3 injects as well

* Update trace flags

Add a FlagsDebug and FlagsDeferred to track the B3 trace state.

Add helper methods to the SpanContext to check the debug and deferred
bit of the trace flags.

Update SpanContext.IsSampled to return if the sampling decision is to
sample rather than if the sample bit is set. This means that if the
debug bit is also set it will return true.

* Revert SpanContext.IsSampled back

* Add comment to b3 test data generation

* Update Changelog

* Fix trace flag name in Changelog

* Fix Changelog formatting

* Update Changelog

* Remove valid check at start of B3 injectg

This check makes sample only headers not propagate.

* Update B3 inject integration tests

Use the passed SpanContext and check directly the span ID.

* Update B3 integration tests

Run update checked SpanID to match sent.

Add tests to validate sample only transmissions and debug flag support.

* Rename injectTest parentSc to sc

This is no longer the parent.

* Update GetAllKeys for B3

* Un-Export the B3 headers

The B3SingleHeader name will conflict with the upcoming change to prefix
the SingleHeader encoding with "B3". There are a few options to address
this conflict, but in the end we do not need to be exporting these
values. They are duplicates of the OpenZipkin package and users should
use those.

* Rename B3 encodings and move support method to B3Encoding

Include a `B3` prefix to scope the encoding names.

Move the related support method to the B3Encoding itself, instead of the
B3 propagator.

Add tests to provide a sanity check for encoding bitmasks.

* Update span_context_test tests

Update test name to better describe how unused bits have no affect on
the sampling decision. Include the inverse of this test as well: not
sampled but has unused bits.

* Use named const for Single Header decoding widths

* Update api/trace/b3_propagator.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-07-07 16:38:52 -07:00
Joshua MacDonald
3475d5575e
Fix incorrect aggregation; Prometheus exporter behavior (#903)
* Avoid applying stale udpates; add a test

* Add Memory option to basic processor

* Always use memory in the pull controller

* Test the memory option

* Precommit

* Add a Prometheus-specific test

* More comment on Memory option

* Link to 862

* Remove sleep

* Update changelog

* Comment on stale and stateless aggregators

* Update sdk/metric/processor/basic/config.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-07 12:52:35 -07:00
Tyler Yahn
808345cbf6
Bump CircleCI instance size (#917)
Related to #907
2020-07-07 10:35:37 -07:00
Anthony Mirabella
c219029606
Update otel-collector example to use collector v0.5.0 (#915)
* Update otel-collector example to use collector v0.5.0

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-07 10:26:47 -07:00
Anthony Mirabella
1c6ca87dec
Ensure clientTracer closes http.headers span (#912)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-07 10:08:40 -07:00
ET
463c458daf
Add more database-specific semantic attributes (#899)
* Adds Database-specific semantic attributes.

* Add CHANGELOG

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-07 09:22:26 -07:00
Matej Gera
5a4b68c7bf
Add semantic convention for faas.coldstart and container.id (#909)
* Add semantic convention for faas coldstart and container ID

* Update Changelog

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-07 09:05:30 -07:00
Anthony Mirabella
eaa94e92b9
Avoid setting span status to Unknown when no HTTP status is provided; stdlib assumes it to be 200 OK (#908)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-07 09:00:21 -07:00
dependabot[bot]
9342eb24f1
Bump github.com/golangci/golangci-lint from 1.28.0 to 1.28.1 in /tools (#913)
* Bump github.com/golangci/golangci-lint from 1.28.0 to 1.28.1 in /tools

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.28.0 to 1.28.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.28.0...v1.28.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-07-07 08:27:12 -07:00
Joshua MacDonald
27e892aad2
Remove -v from Go tests (#904)
Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
2020-07-06 11:41:12 -04:00
ET
bd1e174e60
Add "peer.service" semantic to standard attributes (#898)
Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
2020-07-06 11:36:49 -04:00
dependabot[bot]
8d1f448ade
Bump github.com/golangci/golangci-lint from 1.27.0 to 1.28.0 in /tools (#901)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-07-06 10:14:30 -04:00
Chen Yixiao
550d365c54
fix trace event time conversion from internal to otlp (#896)
* fix trace event time conversion from internal to otlp

* Enhance the effectiveness of SpanEvent test

* Empty
2020-07-05 09:32:40 -07:00
Liz Fong-Jones
f1e3536baf
Update opentracing dependency (#885)
Co-authored-by: lizthegrey <lizthegrey@users.noreply.github.com>
2020-07-01 17:51:06 -04:00
dependabot[bot]
f4b156823c
Bump github.com/itchyny/gojq from 0.10.3 to 0.10.4 in /tools (#883)
* Bump github.com/itchyny/gojq from 0.10.3 to 0.10.4 in /tools

Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.10.3 to 0.10.4.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/master/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.10.3...v0.10.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-07-01 08:49:10 -07:00
Tyler Yahn
8205b0b1e0
Update B3 header names (#881)
* Update B3 header names

Correct the B3 single header name from `X-B3` to `b3`.

Use the lowercase version of the B3 multiple headers. This is based on
the fact that HTTP headers are case-insensitive, however, other
protocols may not be.

* Update Changelog
2020-06-30 18:21:13 -07:00
Anthony Mirabella
2635f96eba
Ask for changelog updates with PRs (#879)
* Ask for changelog updates with PRs

* Add PR ID to changelog entry

* move changelog entry to unreleased
2020-06-26 17:50:19 -07:00
Tyler Yahn
01b6452652
Update Changelog (#878)
Include last merge for the release.
2020-06-26 14:56:48 -07:00
Tyler Yahn
49ac8eb238
Prepare for the v0.7.0 release (#876)
* Prepare for releasing v0.7.0

* Update Changelog for v0.7.0 release

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
2020-06-26 13:54:33 -07:00
Andrew
e8226c4e1d
Add default metrics to othttp instrumentation Fixes #542 (#861)
* Add default metrics to othttp instrumentation

* Changed metrics names, add tests, add standard labels to metrics

* Initialization global error handling, remove requests count metric, tuneup test

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-06-26 12:19:57 -07:00
Tyler Yahn
85c32d5024
Add Changelog (#873)
* Initial CHANGELOG

* v0.1.2

* v0.2.0

* v0.2.1

* v0.2.1.1

* v0.2.2

* Format with inline code objects

* v0.2.3

* v0.3.0

* v0.4.0

* v0.4.1

* v0.4.2

* v0.4.2

* v0.5.0

* v0.6.0

* Unreleased

* Fixes -> Fixed
2020-06-26 08:39:45 -07:00
ET
0594313fca
Update google.golang.org/grpc from 1.27.1 to 1.30.0 (#870)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-06-24 16:07:08 -07:00
Mujtaba Ahmed
5be82c0e47
Added support array attributes (#798)
* Added support array attributes

* Changed function signature for AsArray attribute

* Fixed code comments for array attributes

* Fixed typos in comments in value.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-06-24 15:58:08 -07:00
Tyler Yahn
7d631dbfaa
Upgrade OTLP exporter to opentelemetry-proto matching the opentelemetry-collector v0.4.0 release (#866)
* Update OTLP to v0.4.0

* Update attribute transforms to use new KeyValue

* Update metric transforms

The labels are no longer included in the MetricDescriptor

Use new types.

* Fix OTLP integration tests

* Update example otel-collector go.sum

* Update metric integration testing

* Fix type error introduced in conflict resolution

* Deep clean of go.sum

Recreate go.sum for otel-collector example and OTLP exporter.
2020-06-24 14:02:13 -07:00
ET
2f59a27a28
Allow changes to go.sum *and* go.mod when running dependabot tidy-up (#871)
Transitive dependency changes sometimes do require a change to go.mod
files as well as go.sum. This is already live in the
opentelemetry-go-contrib repo, and this PR brings it here.
2020-06-24 13:35:14 -07:00
dependabot[bot]
9cdfdb2d3a
Bump github.com/stretchr/testify from 1.4.0 to 1.6.1 (#824)
* Bump github.com/stretchr/testify from 1.4.0 to 1.6.1

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.4.0 to 1.6.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.4.0...v1.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Update go.mod

* math.Inf(1)+math.Inf(-1)=NaN

Math is hard

* Remove indirect transitive dependency

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
Co-authored-by: Evan Torrie <evantorrie@users.noreply.github.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
2020-06-24 11:16:21 -07:00
dependabot[bot]
18b096208c
Bump github.com/prometheus/client_golang from 1.7.0 to 1.7.1 in /exporters/metric/prometheus (#867)
* Bump github.com/prometheus/client_golang in /exporters/metric/prometheus

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.7.0...v1.7.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2020-06-24 10:10:41 -07:00
ET
a8faf8cacc
Eliminate Uint64NumberKind from API (#864)
fixes #851

This includes all of the associated methods, such as
  AsUint64, AsUint64Atomic, AsUint64Ptr, CoerceToUint64, SetUint64
  SetUint64Atomic, SwapUint64, SwapUint64Atomic, AddUint64,
  AddUint64Atomic, CompamreAndSwapUint64, CompareUint64

Only significant change as a result was converting the histogram
aggregator's `count` state field into an int64 from a `metric.Number`.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-06-23 16:28:04 -07:00
ET
665c0de552
Fix affiliation of reviewer Evan Torrie (#865) 2020-06-23 15:49:24 -07:00