Mikhail Mazurskiy
5e1c62a2d5
Modernize ( #7089 )
...
Use
https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize
to update code to new style.
---------
Co-authored-by: Flc゛ <four_leaf_clover@foxmail.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
2025-07-29 10:19:11 +02:00
Robert Pająk
d7ebb7aa85
log: Add ValueFromAttribute and KeyValueFromAttribute ( #6180 )
...
Fixes https://github.com/open-telemetry/opentelemetry-go/issues/6158
Related spec PR:
https://github.com/open-telemetry/opentelemetry-specification/pull/4373
Benchmark results:
```
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/log
cpu: 13th Gen Intel(R) Core(TM) i7-13800H
BenchmarkKeyValueFromAttribute/Empty-20 72029505 16.47 ns/op 0 B/op 0 allocs/op
BenchmarkKeyValueFromAttribute/Bool-20 68560222 16.99 ns/op 0 B/op 0 allocs/op
BenchmarkKeyValueFromAttribute/BoolSlice-20 14647401 76.21 ns/op 50 B/op 2 allocs/op
BenchmarkKeyValueFromAttribute/Int64-20 70737378 16.92 ns/op 0 B/op 0 allocs/op
BenchmarkKeyValueFromAttribute/Int64Slice-20 16780069 96.87 ns/op 64 B/op 2 allocs/op
BenchmarkKeyValueFromAttribute/Float64-20 59299638 16.93 ns/op 0 B/op 0 allocs/op
BenchmarkKeyValueFromAttribute/Float64Slice-20 12691222 106.2 ns/op 64 B/op 2 allocs/op
BenchmarkKeyValueFromAttribute/String-20 63837711 16.97 ns/op 0 B/op 0 allocs/op
BenchmarkKeyValueFromAttribute/StringSlice-20 9251001 114.7 ns/op 80 B/op 2 allocs/op
PASS
ok go.opentelemetry.io/otel/log 14.776s
```
2025-01-22 08:26:46 +01:00
Matthieu MOREL
aef9e4fa2f
[chore]: enable bool-compare rule from testifylint ( #5829 )
...
#### Description
Testifylint is a linter that provides best practices with the use of
testify.
This PR enables
[bool-compare](https://github.com/Antonboom/testifylint?tab=readme-ov-file#bool-compare )
rule from [testifylint](https://github.com/Antonboom/testifylint )
It's linter provided by golangci-lint.
Here all available rules are activated except those who require to be
fixed. This PR only fixes bool-compare so the quantity of changes stays
reasonnable for reviewers.
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
2024-09-20 09:39:27 +02:00
Damien Mathieu
a3c512aa95
Fix gosec overflow alerts ( #5799 )
...
To allow the golangci-lint upgrade in #5796 .
---------
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2024-09-13 09:11:50 +02:00
Robert Pająk
e2b0751cd1
[chore] Add asasalint linter ( #5653 )
...
Add https://golangci-lint.run/usage/linters/#asasalint linter.
Fix the bugs detected by the linter.
PR in Contrib:
https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5957
2024-07-31 08:41:11 +02:00
Damien Mathieu
f6a5aa2c3f
Add unparam linter ( #5531 )
...
This adds the [unparam](https://github.com/mvdan/unparam ) linter.
Co-authored-by: Sam Xie <sam@samxie.me >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2024-06-21 16:02:07 -07:00
Damien Mathieu
08c8b3224a
log: Fix comparison of unordered map values ( #5306 )
2024-05-15 12:28:23 +02:00
Robert Pająk
e6e44dee90
log: Add String method to Value and KeyValue ( #5117 )
2024-04-02 10:50:07 +02:00
Sam Xie
47ac0d4df8
logs: Add empty value for KeyValue ( #5076 )
...
* Add empty value for KeyValue
* Update CHANGELOG
* Apply suggestions from code review
Co-authored-by: Robert Pająk <pellared@hotmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
* Fix comments
* Update log/keyvalue.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
2024-03-15 07:52:24 -07:00
Robert Pająk
7dea232a46
[chore] Simplify the license header ( #4987 )
2024-02-29 07:05:28 +01:00
Tyler Yahn
22a4f9cc55
Export internal/global.getLogger ( #4969 )
...
* Export getLogger
Refactor the declaration of globalLogger to incorporate the logic of
init() so there is no data race between GetLogger and init being called.
* Use GetLogger in log testing
* Restore logger in batch span processor testing
* Remove unused URL in globalLogger doc
2024-02-25 07:27:44 -08:00
Tyler Yahn
8df89f6aff
log: Remove Value.AsAny ( #4963 )
2024-02-22 20:56:07 +01:00
Tyler Yahn
7cc660fc0f
log: Add allocation tests ( #4957 )
2024-02-22 20:47:40 +01:00
Tyler Yahn
7b3382e4dc
log: Implement Value and KeyValue types ( #4949 )
...
* Implement `Value` and `KeyValue`
* Add tests for `Value` and `KeyValue`
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2024-02-21 13:19:41 -08:00