1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Commit Graph

6 Commits

Author SHA1 Message Date
Robert Pająk d7ebb7aa85 log: Add ValueFromAttribute and KeyValueFromAttribute (#6180)
Fixes https://github.com/open-telemetry/opentelemetry-go/issues/6158

Related spec PR:
https://github.com/open-telemetry/opentelemetry-specification/pull/4373

Benchmark results:

```
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/log
cpu: 13th Gen Intel(R) Core(TM) i7-13800H
BenchmarkKeyValueFromAttribute/Empty-20              72029505                16.47 ns/op            0 B/op          0 allocs/op
BenchmarkKeyValueFromAttribute/Bool-20               68560222                16.99 ns/op            0 B/op          0 allocs/op
BenchmarkKeyValueFromAttribute/BoolSlice-20          14647401                76.21 ns/op           50 B/op          2 allocs/op
BenchmarkKeyValueFromAttribute/Int64-20              70737378                16.92 ns/op            0 B/op          0 allocs/op
BenchmarkKeyValueFromAttribute/Int64Slice-20         16780069                96.87 ns/op           64 B/op          2 allocs/op
BenchmarkKeyValueFromAttribute/Float64-20            59299638                16.93 ns/op            0 B/op          0 allocs/op
BenchmarkKeyValueFromAttribute/Float64Slice-20       12691222               106.2 ns/op            64 B/op          2 allocs/op
BenchmarkKeyValueFromAttribute/String-20             63837711                16.97 ns/op            0 B/op          0 allocs/op
BenchmarkKeyValueFromAttribute/StringSlice-20         9251001               114.7 ns/op            80 B/op          2 allocs/op
PASS
ok      go.opentelemetry.io/otel/log    14.776s
```
2025-01-22 08:26:46 +01:00
Sam Xie 5b2ce02911 Stabilize benchmark result of BenchmarkValueEqual (#5717)
`BenchmarkValueEqual` does not run the target code with `b.N`, as
https://pkg.go.dev/testing#hdr-Benchmarks states. Thus, it cannot
produce a stable benchmark result. And, it would fail the benchmark:
https://github.com/open-telemetry/opentelemetry-go/actions/runs/10412186663.
This PR fixes this issue.

Here is the result of `benchstat`

```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/log
                       │       old.txt        │                      new.txt                       │
                       │        sec/op        │       sec/op        vs base                        │
ValueEqual/2_with_1-10   0.0000002000n ± 100%   3.1450000000n ± 1%  +1572499900.00% (p=0.000 n=10)

                       │  old.txt   │            new.txt             │
                       │    B/op    │    B/op     vs base            │
ValueEqual/2_with_1-10   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                       │  old.txt   │            new.txt             │
                       │ allocs/op  │ allocs/op   vs base            │
ValueEqual/2_with_1-10   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal
```
2024-08-16 09:33:36 -07:00
Damien Mathieu 08c8b3224a log: Fix comparison of unordered map values (#5306) 2024-05-15 12:28:23 +02:00
Robert Pająk 7dea232a46 [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
Tyler Yahn 8df89f6aff log: Remove Value.AsAny (#4963) 2024-02-22 20:56:07 +01:00
Tyler Yahn 6ea99afaa0 log: Add benchmark tests (#4958) 2024-02-22 18:15:43 +01:00