Warnar Boekkooi
8fbaa97084
Reduce newEvictedQueueLink and newEvictedQueueEvent memory allocations ( #5858 )
...
Good day,
While doing some profile with pprof on one of our services I notices
that `sync.OnceFunc` was allocating a nice amount of objects. These
`sync.OnceFunc` calls where done by `newEvictedQueueEvent` and
`newEvictedQueueLink`.
So to avoid these extra allocation I created this PR which replaces the
`sync.OnceFunc` with `sync.Once` which is now part of the evictedQueue.
This resulted in the following benchstat result (commit
baad07e574
2024-10-08 09:43:14 +02:00
ttoad
30e82e01b6
trace: Use non-generic to replace newEvictedQueue in trace.start to reduce memory usage. ( #5497 )
...
benchstat:
```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/trace
│ old │ new │
│ sec/op │ sec/op vs base │
TraceStart-10 950.6n ± 1% 641.0n ± 0% -32.57% (p=0.000 n=10)
│ old │ new │
│ B/op │ B/op vs base │
TraceStart-10 1040.0 ± 0% 704.0 ± 0% -32.31% (p=0.000 n=10)
│ old │ new │
│ allocs/op │ allocs/op vs base │
TraceStart-10 20.00 ± 0% 14.00 ± 0% -30.00% (p=0.000 n=10)
```
---------
Co-authored-by: Damien Mathieu <damien.mathieu@elastic.co>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2024-06-17 07:39:03 -07:00
Tyler Yahn
5bfa9c55be
Log warning when a trace attribute/event/link is discarded due to limits ( #5434 )
...
Fix #5343
- Update the `evictionQueue` to log when it drops a value
- Update the `evictionQueue` to be declared over an `[T any]` parameter
so it knows what to log when it is dropping a value and to reduce the
`interface{}` allocation
- Add a `clone` method to replace the now unneeded
`interfaceArrayTo*Array` functions.
- Update the `recordingSpan` to log once that is dropped an attribute
when limits are reached.
2024-05-30 11:40:08 -07:00
Robert Pająk
7dea232a46
[chore] Simplify the license header ( #4987 )
2024-02-29 07:05:28 +01:00
Tyler Yahn
0d0a7320e6
Update span limits to comply with specification ( #2637 )
...
* PoC for span limit refactor
* Rename config.go to span_limits.go
* Add unit tests for truncateAttr
* Add unit tests for non-string attrs
* Add span limit benchmark tests
* Fix lint
* Isolate span limit tests
* Clean span limits test
* Test limits on exported spans
* Remove duplicate test code
* Fix lint
* Add WithRawSpanLimits option
* Add test for raw and orig span limits opts
* Add changes to changelog
* Add tests for span resource disabled
* Test unlimited instead of default limit
* Update docs
* Add fix to changelog
* Fix option docs
* Do no mutate attribute
* Fix truncateAttr comment
* Remake NewSpanLimits to be newEnvSpanLimits
Update and unify documentation accordingly.
* Update truncateAttr string slice update comment
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2022-03-03 07:56:07 -08:00
Tyler Yahn
d3bb03883b
Optimize evictedQueue implementation and use ( #2556 )
...
* Optimize evictedQueue impl and use
Avoid unnecessary allocations in the recordingSpan by using an
evictedQueue type instead of a pointer to one.
Lazy allocate the evictedQueue queue to prevent unnecessary operations
for spans without any use of the queue.
Document the evictedQueue
* Fix grammar
2022-01-27 13:55:21 -08:00
José Carlos Chávez
e22a48de5a
chore: adds vanity import for files that don't have it. ( #1297 )
2020-11-04 09:10:58 -08:00
Tyler Yahn
a485d0ec64
Update License header for all source files ( #586 )
...
* Update License header for all source files
- Add Apache 2.0 header to source files that did not have one.
- Update all existing headers dated to 2019 to be 2020
- Remove comma from License header to comply with the Apache 2.0
guidelines.
* Update Copyright notice
Use the standard Copyright notices outlined by the
[CNCF](https://github.com/cncf/foundation/blob/master/copyright-notices.md#copyright-notices )
2020-03-23 22:41:10 -07:00
rghetia
0f32efcdaa
Trace sdk ( #65 )
...
* trace sdk initial commit.
* fix imports and comments.
* remove tracestate
* split trace.go
* add attribute over limit test.
* add comments and restructure span.go and tracer.go
* refactor MessageEvent
* defer unlock
* some more cleanup in span.go
* rename *MessageEvent* to *Event*
* cleanup comments in trace_test.go
* fix typos.
* return full string ID for traceID and spanID.
2019-08-02 13:52:55 -07:00
Warnar Boekkooi
ttoad
Tyler Yahn
Robert Pająk
José Carlos Chávez
rghetia