* Remove Old SDK and dependent code on that SDK (#2802)
* Remove prometheus example code
* Remove prometheus exporter code
* Remove stdoutmetric code
* Remove sdk/metric/* packages
* Remove opencensus example code
* Remove otlpmetric exporter code
* Remove OpenCensus bridge code
* go mod tidy
* Remove empty modules
* Remove the number and aggregator from the metric SDK (#2840)
* Add MeterProvider/meter structure to new SDK (#2822)
* Remove prometheus example code
* Remove prometheus exporter code
* Remove stdoutmetric code
* Remove sdk/metric/* packages
* Remove opencensus example code
* Remove otlpmetric exporter code
* Remove OpenCensus bridge code
* go mod tidy
* Remove empty modules
* Add MeterProvider/meter structure to new SDK
* Add vanity imports
* go mod tidy
* Add MeterProvider Flush/Shutdown required by spec
* Cast nil ptr instead of alloc for comp time check
* Apply suggestions from code review
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Apply suggested Shutdown comment
* Apply fixes from feedback
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add sdk/metric/view structure (#2838)
* Add sdk/metric/view package structure
* Vanity import
* Define the reader interface, and create a manual reader (#2885)
* Add the manual reader to the sdk.
* Incoperate feedback from PR.
* additional PR comments
* Fix lint
* Fixes for PR.
* Unexport ManualReader
fix a few comments
* Refactor reader testing into a harness (#2910)
* Refactor reader testing into a harness
* Run lint
* Removed merge leftover
* Use opentracing bridge from main
* go mod tidy
* crosslink
* Remove Prometheus exporter from README for now
* Run make with new tool set
* Replace testReaderHarness with testify suite (#2915)
* Add the periodic reader (#2909)
* Add the metric.Exporter interface
* Move the reader errors to reader.go
* Update Reader.Collect docs
Remove TODO being addressed in this PR and restate purpose of method.
* Initial draft of the periodic reader
* Refer to correct config in periodic reader opts
* Refactor reader testing into a harness
* Move wait group handling out of run
* Refactor ticker creation to allow testing
* Honor export timeout in run
* Fix wait group wait bug
* Add periodic reader tests
* Fix lint
* Update periodic reader comments
* Add concurrency test for readers
* Simplify the ticker stop deferral
* Only register once
* Restrict build of metric sdk to Go>1.16
* Clean up ShutdownBeforeRegister test
* Test duplicate Reader registration (#2914)
The specification requires the SDK prevent duplicate registrations for
readers. This adds a test for that and fixes this for the manualReader.
* Add WithReader and WithResource Options (#2905)
* Add WithReader and WithResource Options
* Run lint
* Update WithReader fn signature based on feedback
* crosslink
* Remove zero-len check in unify
* Restrict build to Go > 1.16
* Add bench test for reader collect methods (#2922)
* Unify reader implementations (#2923)
* Unify reader implementations
Use an atomic.Value to manage concurrency without a lock.
* Lint
* Merge main into new sdk main (#2925)
* Use already enabled revive linter and add depguard (#2883)
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
* Move the minimum version to go 1.17 (#2917)
* Move the minimum version to go 1.17
* Update readme and changelog
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Make lint
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Add view to metrics. (#2926)
* WIP views public
* Add attribute filters and comments.
* Fixes for lint
* Address comments
* Fix lint
* Changed view matching to expand end
Removed the dscriptor, it was moved in previous patch
* change wildcards into regex
* Update comments
* address comments.
* Address more PR comments
* renamed WithDescription to WithSetDescription.
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Implement MeterProvider's Meter method (#2945)
* Implement stubbed meter create method
* Rename return value to avoid comment
* Encapsulate meterRegistry tests with identifying name
* Run lint fix
* Comment meterRegistry being concurrent safe
* Remove ordered meter tracking in the meterRegistry
* Test range completeness instead of order
* Remove provider field from meter
* Initialize MeterProvider readers field for new (#2948)
* Introduce Temporality, WithTemporality Reader options and InstrumentKind (#2949)
* Introduce Temporality and InstrumentKind
Because Temporality is the responsibility of the Reader additional methods
are added to the Reader interface. And New options are created to
configure the temporality selector.
* Addresses comments, and adds tests.
* Fix addition PR comment
* Add aggregation package and reader/view options (#2958)
* Add aggregation pkg and options
* Update documentation for the aggregation pkg
* Test Aggregation.Err
* Fix aggregation pkg comment
* Add WithAggregation comment
* Add default aggregation
* Rename WithAggregation and add AggregationSelector
* Fix DefaultAggregationSelector use and decl
* Replace Aggregation struct with iface
* Add Copy method to hist and fix Err method
* Additional test for monotonic bounds
* Add aggregation method to Reader
* Use AggregationSelector instead of inline func type
* Switch RecordMinMax to NoMinMax
* Deep copy and validate in options
* Test the DefaultAggregationSelector
* nolint for import-shadow of method
* Fix Default aggregation comment
* Test the explicit bucket histogram deep copy
* Update temporality selector option (#2967)
Match the WithAggregationSelector option pattern: define a
TemporalitySelector type, export the DefaultTemporalitySelector
function, and name the option with a Selector suffix.
* Minor NewMeterProvider and producer docs fix (#2983)
* Add internal package structure for aggregation (#2954)
* Add the aggtor package
* Restrict to Go 1.18
* Add missing build block to view_test.go
* Comment Aggregator iface
* Use Go 1.18 as the default ci version
* Update Aggregator iface from feedback
* Accept hist conf
* Flatten aggtor into just internal
* Add Cycler interface
Separate the duties of aggregation and maintaining state across
aggregation periods.
* Remove build flags for doc.go
* Clarify Cycler documentation
* Remove aggregation fold logic
* Rename Number to Atomic
* Add tests for Atomic impls
* Remove unneeded Atomic implementation
Add back when filling in structures.
* Fix article in Float64 docs
* Remove Atomic
This is an implementation detail.
* Add aggregator_example_test
* Fix hist example
* Add issue numbers to all TODO and FIXME
* Remove zero parameter comment
* Combine the cycler into the aggregators
* Remove the drop aggregator
* Fix lint
* Use attribute.Set instead of ptr to it
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Merge main into new_sdk/main (#2996)
* Use already enabled revive linter and add depguard (#2883)
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
* Move the minimum version to go 1.17 (#2917)
* Move the minimum version to go 1.17
* Update readme and changelog
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Use ByteSliceToString from golang.org/x/sys/unix (#2924)
Use unix.ByteSliceToString to convert Utsname []byte fields to strings.
This also allows to drop the charsToString helper which serves the same
purpose and matches ByteSliceToString's implementation.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* docs: fix typo (#2935)
* add timeout to grpc connection in otel-collector example (#2939)
* Closes: #2951 (#2952)
This PR updates the example listed in the getting started doc
so that it will compile without error. It also makes this
example consistent with the code found in
https://github.com/open-telemetry/opentelemetry-go/blob/main/example/fib/main.go
Signed-off-by: Brad Topol <btopol@us.ibm.com>
* fix data-model link (#2955)
* Bump go.opentelemetry.io/proto/otlp from v0.16.0 to v0.18.0 (#2960)
* Move to using Instrumentation Scope (#2976)
* Move to using Instrumentation Scope
* Use type alias, not definition
* Add a changelog entry
* docs(website_docs): fix exporting_data.md and getting-started.md toc (#2930)
* docs(website_docs): fix toc
* docs(website_docs): fix toc
* update exporting_data.md for rerun check-links
* update exporting_data.md for rerun check-links
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update getting-started.md (#2984)
grammar edit for line 175 of readme
* fix typo (#2986)
* fix typo
* spell fix
* typo fix (#2991)
* added traces.txt to gitignore for fib (#2993)
* Deprecate Library and move all uses to Scope (#2977)
* Deprecate Library and move all uses to Scope
* Add PR number to changelog
* Don't change signatures in stable modules
* Revert some changes
* Rename internal struct names
* A bit more renaming
* Update sdk/trace/span.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update based on feedback
* Revert change
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Feat/bridge support text map (#2911)
* feat: support TextMap
* doc: add comment
* test: support for ot.TextMap
* Retrieve lost code due to merge
* fix: retrieve lost code due to merge. test: support for ot.HTTPHeaders
* go mod tidy
* Optimized code style, add changelog
* doc: Restore comments
* wip: add test cases
* test: fix args error
* delete empty line
* Fix syntax and changelog errors
* Fix formatting errors
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add a release template (#2863)
* Add a release template
* Update the about field
Co-authored-by: Damien Mathieu <42@dmathieu.com>
* Fix linting Issues
* Add ignore for template link
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Fix merge of CHANGELOG.md
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tobias Klauser <tobias.klauser@gmail.com>
Co-authored-by: petrie <244236866@qq.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Brad Topol <btopol@us.ibm.com>
Co-authored-by: Craig Pastro <pastro.craig@gmail.com>
Co-authored-by: Kshitija Murudi <kmurudi@ncsu.edu>
Co-authored-by: Petrie Liu <lpfvip2008@gmail.com>
Co-authored-by: Guangya Liu <gyliu513@gmail.com>
Co-authored-by: Craig Pastro <craig.pastro@auth0.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: ttoad <qq530901331@outlook.com>
* Add structure to the export data. (#2961)
* Add structure to the export data.
* Fix comments.
* Apply suggestions from code review
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Address PR comments.
* Updated optional historgram parameters.
* Address PR comments.
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Use export.Aggregation instead of internal.Aggregation (#3007)
* Use export.Aggregation instead of internal
* Return an export.Aggregation instead of a slice
* Use attribute Sets instead of KeyValues for export data (#3012)
Attribute Sets have stronger guarantees about the uniqueness of their
keys and more functionality. We already ensure attributes are stored as
Sets by the aggregator which will produce these data types. Instead of
converting to a KeyValue slice, keep the data as a Set.
Any user of the data can always call the ToSlice method to use the data
as a slice of KeyValues.
* Change Instrument Library to Instrument Scope (#3016)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* move temporality to export/temporality (#3017)
* move temporality to export/temporality
* fix lint errors
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Rename Package sdk/metric/export into sdk/metric/metricdata (#3014)
* fix unrelated changes
* fix quote code
* fix format
* rebase pr
* rebase pr
* change usage of export to metricdata
* Add metricdatatest package (#3025)
* Use export.Aggregation instead of internal
* Return an export.Aggregation instead of a slice
* Use attribute Sets instead of KeyValues for export data
Attribute Sets have stronger guarantees about the uniqueness of their
keys and more functionality. We already ensure attributes are stored as
Sets by the aggregator which will produce these data types. Instead of
converting to a KeyValue slice, keep the data as a Set.
Any user of the data can always call the ToSlice method to use the data
as a slice of KeyValues.
* Add export data type comparison testing API
* Add Aggregation and Value comparison funcs
* Move export testing to own pkg
* Move exporttest to metricdatatest
* Add licenses headers to files missing them
* Use metricdata instead of export
Fix merge of new_sdk/main
* Rename exporttest pkg to metricdatatest
* Fix spelling errors
* Fix lint issues
* Use testing pkg to error directly
Include Helper() method calls to correct the call-stack.
* Fix CompareAggregations
Set equal to true by default
* Generalize assertions and unexport equal checks
* Abstract assert tests
* Rename all exp var to r
* Test AssertAggregationsEqual
* Comment why Value and Aggregation are separate
* Test AssertValuesEqual
* Revert changes to metricdata/temporality.go
* Expand pkg doc sentence
* Add license header to assertion.go
* Update assertion docs
* Consolidate comparisons funcs into one file
* Consolidate and fix docs
* Consolidate assertion.go
* Consolidate comparisons.go
* make lint
* Test with relatively static times
* Update sdk/metric/metricdata/metricdatatest/comparisons.go
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Drop equal return from comparison funcs
* Refactor AssertEqual
* Remove reasN from testDatatype func params
* Consolidate AssertEqual type conversions
* Fix assertion error message
* Add assertion failure tests
* Remove unneeded strings join
* Make comment include a possessive
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Adds a pipeline for creating reader's output (#3026)
* Adds a pipeline for creating reader's output
* fix metricdata move
* fix lint
* Apply suggestions from code review
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Address PR comments
* Added resource test
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Use generic Sum, Gauge, and DataPoint value removing Value, Int64, and Float64 from metricdata (#3036)
* Use generic DataPoint value
* Fix assertion_fail_test.go
* Declare Sum and DataPoints type in pipeline_test
* Add MatchInstrumentKind filter for Views. (#3037)
* Move InstrumentKind to view, Add view filter
* remove TODO
* Add the Option function, fix lint
* use local var over 0
* Fix missing undefinedInstrumnet
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Change View Attribute Filter to detect if not set. (#3039)
* Change View Attribute Filter to detect if not set.
* Fix PR comments.
* Rework test for no filter logic.
* Add implementation of last-value aggregator (#3008)
* Add last-value aggregator
* Add test of last-value reset of unseen attrs
* Add benchmark
* Use generic DataPoint value
* Fix assertion_fail_test.go
* Fix tests
* Remove unused test increment values
* View.New() miss InstrumentKind check (#3043)
Signed-off-by: liupengfei <lpfvip2008@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add delta/cumulative histogram implementation (#3045)
* Add delta/cumulative histogram implementation
* Add histogram unit tests
* Fix histValues Aggregate
Store the new buckets value back to the values map.
Ensure min/max are measured values, not zero values.
* Fix lint
* Add benchmarks
* Test histograms internal functionality
* Fix lint
* Add TODO to look at memory use for cumu hist
* Update sdk/metric/internal/histogram.go
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* use TemporalitySelector (#3050)
Signed-off-by: Petrie <lpfvip2008@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add implementation of Sum aggregators (#3000)
* Implement the sum aggregators
* Add unit tests for delta/cumulative sums
* Add benchmarks
* Merge sum tests into one
* Remove unused start time from cumulative sum
* Refactor benchmark tests
Split benchmarks for the Aggregations and Aggregate methods so
computational resource use can be determined.
* goimports
* Move timestamp out of lock
* Refactor testing
* Fix spelling mistake
* Name param of expectFunc
* Reset delta sum to zero instead of delete
* Revert to deleting unused attr sets
* Refactor testing to allow use across other aggs
* Add TODO to bound cumulative sum mem usage
* Fix misspelling
* Unify aggregator benchmark code in aggregator_test
* Use generic DataPoint value
* Fix assertion_fail_test.go
* Use generic metricdata types
* Fix tests
* Fix benchmarks
* Fix lint
* Update sum documentation
* Remove leftover encapsulating test run
* Use t.Cleanup to mock time
* Consolidate expecter logic into funcs
* Move errNegVal closer to use
* Run the agg test
* Add tests for monotonic sum Aggregate err
* Run make lint
* Make monotonic an arg of creation funcs
* Remove Aggregate monotonic validation
* Rename sum to valueMap
The term sum is a good variable name that we do not want to take and
valueMap better describes the type as the storage of the aggregator.
* Adds a filter Aggregator. (#3040)
* Adds a filter Aggregator.
* Add lock and tests
* Add Concurrency tests
* fix lint errors
* Add memory constrained todo.
* Update filter comment.
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add back the stdoutmetric exporter (#3057)
* PoC stdoutmetric exporter
* Use stringer to generate String for Temporality
* Add vanity imports
* Update Temporality string expected output
* Do not return error from newConfig
* Add shutdown unit tests
* Fix spelling error
* Unify testing of ctx errors and test ForceFlush
* Add unit test for Export handle of ctx errs
* Clarify documentation about alt OTLP exporter
* Remove unused ErrUnrecognized
A third party encoder can produce their own errors. This code does
nothing unique with this error, therefore, it is removed.
* Lint exporter_test.go
* Refactor example_test.go removing FIXME
* Add test for Export shutdown err
* Add a discard encoder for testing
* Acknowledged error is returned from Shutdown
* Remove unexpected SchemaURL from stdouttrace test
* Remove unneeded *testing.T arg from testEncoderOption
* Fix the location of now
* Revise and edit docs
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Remove stale TODO from metricdata/data.go (#3064)
* Merge main into new_sdk/main (#3082)
* Use already enabled revive linter and add depguard (#2883)
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
* Move the minimum version to go 1.17 (#2917)
* Move the minimum version to go 1.17
* Update readme and changelog
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Use ByteSliceToString from golang.org/x/sys/unix (#2924)
Use unix.ByteSliceToString to convert Utsname []byte fields to strings.
This also allows to drop the charsToString helper which serves the same
purpose and matches ByteSliceToString's implementation.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* docs: fix typo (#2935)
* add timeout to grpc connection in otel-collector example (#2939)
* Closes: #2951 (#2952)
This PR updates the example listed in the getting started doc
so that it will compile without error. It also makes this
example consistent with the code found in
https://github.com/open-telemetry/opentelemetry-go/blob/main/example/fib/main.go
Signed-off-by: Brad Topol <btopol@us.ibm.com>
* fix data-model link (#2955)
* Bump go.opentelemetry.io/proto/otlp from v0.16.0 to v0.18.0 (#2960)
* Move to using Instrumentation Scope (#2976)
* Move to using Instrumentation Scope
* Use type alias, not definition
* Add a changelog entry
* docs(website_docs): fix exporting_data.md and getting-started.md toc (#2930)
* docs(website_docs): fix toc
* docs(website_docs): fix toc
* update exporting_data.md for rerun check-links
* update exporting_data.md for rerun check-links
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update getting-started.md (#2984)
grammar edit for line 175 of readme
* fix typo (#2986)
* fix typo
* spell fix
* typo fix (#2991)
* added traces.txt to gitignore for fib (#2993)
* Deprecate Library and move all uses to Scope (#2977)
* Deprecate Library and move all uses to Scope
* Add PR number to changelog
* Don't change signatures in stable modules
* Revert some changes
* Rename internal struct names
* A bit more renaming
* Update sdk/trace/span.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update based on feedback
* Revert change
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Feat/bridge support text map (#2911)
* feat: support TextMap
* doc: add comment
* test: support for ot.TextMap
* Retrieve lost code due to merge
* fix: retrieve lost code due to merge. test: support for ot.HTTPHeaders
* go mod tidy
* Optimized code style, add changelog
* doc: Restore comments
* wip: add test cases
* test: fix args error
* delete empty line
* Fix syntax and changelog errors
* Fix formatting errors
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add a release template (#2863)
* Add a release template
* Update the about field
Co-authored-by: Damien Mathieu <42@dmathieu.com>
* Fix linting Issues
* Add ignore for template link
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add workflow to automate bundling dependabot PRs (#2997)
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Release prep 1.8.0 (#3001)
* Update CHANGELOG and versions.yaml for 1.8.0 release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update go-build-tools
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare stable-v1 for version v1.8.0
* Prepare experimental-metrics for version v0.31.0
* Prepare bridge for version v0.31.0
* `make go-mod-tidy` should use `-compat=1.17` now
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add benchmark metric test for UpDownCounter (#2655)
* add benchmark metric test for UpDownCounter
* move counter annotation up
* fix syncFloat64 to syncInt64
* fix syncFloat64 to syncInt64
* fix go-lint err
* Add semconv/v1.11.0 (#3009)
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add semconv/v1.12.0 (#3010)
* Add semconv/v1.12.0
* Update all semconv use to v1.12.0
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add http.method attribute to http server metric (#3018)
* Add http.method attribute to http server metric
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix lint
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix lint
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix for reviews
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* add changelog entry
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* Add tests and fix opentracing bridge defer warning (#3029)
* add tests and fix opentracing bridge defer warning
* add changelog entry
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update bridge/opentracing/bridge_test.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Introduce "split" metric schema transformation (#2999)
This is a new transformation type that allows to describe a change
where a metric is converted to several other metrics by eliminating
an attribute.
An example of such change that happened recently is this:
https://github.com/open-telemetry/opentelemetry-specification/pull/2617
This PR implements specification change https://github.com/open-telemetry/opentelemetry-specification/pull/2653
This PR creates package v1.1 for the new functionality. The old package v1.0
remains unchanged.
* Release v1.9.0 (#3052)
* Bump versions in versions.yaml
* Prepare stable-v1 for version v1.9.0
* Prepare experimental-schema for version v0.0.3
* Update changelog for release
* Replace ioutil with io and os (#3058)
* Make several vars into consts (#3068)
* Add support for Go 1.19 (#3077)
* Add support for Go 1.19
* Update CHANGELOG.md
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
* Update compatibility documentation (#3079)
Remove 3 month timeline for backwards support of old versions of Go.
Signed-off-by: Brad Topol <btopol@us.ibm.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tobias Klauser <tobias.klauser@gmail.com>
Co-authored-by: petrie <244236866@qq.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Brad Topol <btopol@us.ibm.com>
Co-authored-by: Craig Pastro <pastro.craig@gmail.com>
Co-authored-by: Kshitija Murudi <kmurudi@ncsu.edu>
Co-authored-by: Petrie Liu <lpfvip2008@gmail.com>
Co-authored-by: Guangya Liu <gyliu513@gmail.com>
Co-authored-by: Craig Pastro <craig.pastro@auth0.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: ttoad <qq530901331@outlook.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
Co-authored-by: Mikhail Mazurskiy <126021+ash2k@users.noreply.github.com>
Co-authored-by: Sam Xie <sam@samxie.me>
* Adds the option to ignore timestamps in metric data tests. (#3076)
* Adds the option to ignore timestamps in metric data tests
* use config over bool
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Adds a pipelineRegistry to manage creating aggregators. (#3044)
* Adds a pipelineRegistry to manage creating aggregators.
* Made pipeline generic
* Add aggregation filter to the registry.
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Remove stale TODO (#3083)
The aggregation transform function was added in #2958.
* Add back the otlpmetric transforms (#3065)
* Add otlpmetric transforms
* Split aggregation transforms to own file
* Rename Iterator to AttrIter
* Update pkg docs
These are internal docs use developer based language.
* Document all exported funcs
* Unify metricdata type transforms into one file
* Rename metrics.go to metricdata.go
* Copy back attribute tests
* Copy back in Iterator test
* Refactor attribute tests
* Add tests for metricdata transforms
* Add multiErr support for digestible transform errs
* Test transform errors
* go mod tidy
* Use key field
* goimported
* gofmt-ed
* Fix error documentation
* go mod tidy
* Changes instruments uniqueness in pipeline. (#3071)
* Changes instruments uniquness in pipeline.
* Fix lint
* Update sdk/metric/pipeline.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Restore the exporters/otlp/otlpmetric/internal/otelconfig package (#3090)
* Restore otlpmetric/otlpconfig from main
* Rename otlpconfig to oconf
* Remove the empty envconfig_test.go
* Update import of otlpconfig in oconf_test
* go mod tidy
* Run make
* add internal OpenCensus metric translation library (#3099)
* reintroduce opencensus trace bridge (#3098)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Document the sdk/metric/view package (#3086)
* Add package documentation for sdk/metric/view
* Refer to views not configs in WithReader docs
* Fix vanity url for view_test.go
* Add example tests for view options
* Add package example
* Fix view type docs
* Remove build constraint for doc.go
* Fix lint
* Adds async instruments and providers. (#3084)
* Adds instrument providers and instruments.
* Don't return nil instrument, return with error
* removed sync
* Added a number of tests.
Signed-off-by: GitHub <noreply@github.com>
* Address PR comments
* fix error messages
* fixes typo in test name
Signed-off-by: GitHub <noreply@github.com>
* Fix lint issues
* moved the testCallback into the TestMeterCreateInstrument
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Merge branch 'main' into new_sdk/main (#3111)
* Use already enabled revive linter and add depguard (#2883)
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
* Move the minimum version to go 1.17 (#2917)
* Move the minimum version to go 1.17
* Update readme and changelog
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Use ByteSliceToString from golang.org/x/sys/unix (#2924)
Use unix.ByteSliceToString to convert Utsname []byte fields to strings.
This also allows to drop the charsToString helper which serves the same
purpose and matches ByteSliceToString's implementation.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* docs: fix typo (#2935)
* add timeout to grpc connection in otel-collector example (#2939)
* Closes: #2951 (#2952)
This PR updates the example listed in the getting started doc
so that it will compile without error. It also makes this
example consistent with the code found in
https://github.com/open-telemetry/opentelemetry-go/blob/main/example/fib/main.go
Signed-off-by: Brad Topol <btopol@us.ibm.com>
* fix data-model link (#2955)
* Bump go.opentelemetry.io/proto/otlp from v0.16.0 to v0.18.0 (#2960)
* Move to using Instrumentation Scope (#2976)
* Move to using Instrumentation Scope
* Use type alias, not definition
* Add a changelog entry
* docs(website_docs): fix exporting_data.md and getting-started.md toc (#2930)
* docs(website_docs): fix toc
* docs(website_docs): fix toc
* update exporting_data.md for rerun check-links
* update exporting_data.md for rerun check-links
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update getting-started.md (#2984)
grammar edit for line 175 of readme
* fix typo (#2986)
* fix typo
* spell fix
* typo fix (#2991)
* added traces.txt to gitignore for fib (#2993)
* Deprecate Library and move all uses to Scope (#2977)
* Deprecate Library and move all uses to Scope
* Add PR number to changelog
* Don't change signatures in stable modules
* Revert some changes
* Rename internal struct names
* A bit more renaming
* Update sdk/trace/span.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update based on feedback
* Revert change
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Feat/bridge support text map (#2911)
* feat: support TextMap
* doc: add comment
* test: support for ot.TextMap
* Retrieve lost code due to merge
* fix: retrieve lost code due to merge. test: support for ot.HTTPHeaders
* go mod tidy
* Optimized code style, add changelog
* doc: Restore comments
* wip: add test cases
* test: fix args error
* delete empty line
* Fix syntax and changelog errors
* Fix formatting errors
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add a release template (#2863)
* Add a release template
* Update the about field
Co-authored-by: Damien Mathieu <42@dmathieu.com>
* Fix linting Issues
* Add ignore for template link
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add workflow to automate bundling dependabot PRs (#2997)
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Release prep 1.8.0 (#3001)
* Update CHANGELOG and versions.yaml for 1.8.0 release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update go-build-tools
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare stable-v1 for version v1.8.0
* Prepare experimental-metrics for version v0.31.0
* Prepare bridge for version v0.31.0
* `make go-mod-tidy` should use `-compat=1.17` now
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add benchmark metric test for UpDownCounter (#2655)
* add benchmark metric test for UpDownCounter
* move counter annotation up
* fix syncFloat64 to syncInt64
* fix syncFloat64 to syncInt64
* fix go-lint err
* Add semconv/v1.11.0 (#3009)
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add semconv/v1.12.0 (#3010)
* Add semconv/v1.12.0
* Update all semconv use to v1.12.0
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add http.method attribute to http server metric (#3018)
* Add http.method attribute to http server metric
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix lint
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix lint
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix for reviews
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* add changelog entry
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* Add tests and fix opentracing bridge defer warning (#3029)
* add tests and fix opentracing bridge defer warning
* add changelog entry
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update bridge/opentracing/bridge_test.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Introduce "split" metric schema transformation (#2999)
This is a new transformation type that allows to describe a change
where a metric is converted to several other metrics by eliminating
an attribute.
An example of such change that happened recently is this:
https://github.com/open-telemetry/opentelemetry-specification/pull/2617
This PR implements specification change https://github.com/open-telemetry/opentelemetry-specification/pull/2653
This PR creates package v1.1 for the new functionality. The old package v1.0
remains unchanged.
* Release v1.9.0 (#3052)
* Bump versions in versions.yaml
* Prepare stable-v1 for version v1.9.0
* Prepare experimental-schema for version v0.0.3
* Update changelog for release
* Replace ioutil with io and os (#3058)
* Make several vars into consts (#3068)
* Add support for Go 1.19 (#3077)
* Add support for Go 1.19
* Update CHANGELOG.md
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
* Update compatibility documentation (#3079)
Remove 3 month timeline for backwards support of old versions of Go.
* Fix `opentracing.Bridge` where it miss identifying the spanKind (#3096)
* Fix opentracing.Bridge where it was not identifying the spanKinf correctly
* fix test
* changelog
* Keeping backward comppatibillity
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* replace `required` by `requirementlevel` (#3103)
* Change the inclusivity of exponential histogram bounds (#2982)
* Use lower-inclusive boundaries
* make exponent and logarithm more symmetric
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Update golangci-lint to v1.48.0 (#3105)
* Update golangci-lint to v1.48.0
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Bump go.opentelemetry.io/proto/otlp from v0.18.0 to v0.19.0 (#3107)
* Bump go.opentelemetry.io/proto/otlp from v0.18.0 to v0.19.0
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Signed-off-by: Brad Topol <btopol@us.ibm.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tobias Klauser <tobias.klauser@gmail.com>
Co-authored-by: petrie <244236866@qq.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Brad Topol <btopol@us.ibm.com>
Co-authored-by: Craig Pastro <pastro.craig@gmail.com>
Co-authored-by: Kshitija Murudi <kmurudi@ncsu.edu>
Co-authored-by: Petrie Liu <lpfvip2008@gmail.com>
Co-authored-by: Guangya Liu <gyliu513@gmail.com>
Co-authored-by: Craig Pastro <craig.pastro@auth0.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: ttoad <qq530901331@outlook.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
Co-authored-by: Mikhail Mazurskiy <126021+ash2k@users.noreply.github.com>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Alan Protasio <alanprot@gmail.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
* Add otlpmetric exporter (#3089)
* Add otlpmetric package doc
* Add Client interface
* Add the Exporter
Have the Exporter ensure synchronous access to all client methods.
* Add race detection test for Exporter
* Expand New godocs
* Fix lint
* Merge transform and upload errors
* Fix ineffectual increment
* Make pipelineRegistry non-generic (#3115)
* Make pipelineRegistry non-generic
* Add Synchronous instruments (#3124)
* Add Synchronous instruments
* remove duplicate code in instrument
* Fixes to Histogram comments
* Add back the otlpmetricgrpc exporter (#3094)
* Add otlpmetric package doc
* Add Client interface
* Add the Exporter
Have the Exporter ensure synchronous access to all client methods.
* Add race detection test for Exporter
* Expand New godocs
* Fix lint
* Add the otlpmetricgrpc Go module
* Restore otlpmetricgrpc from main
* Remove integration testing from otlpmetricgrpc
* Fix import of otlpconfig to oconf
* Update client
Add ForceFlush method to satisfy otlpmetric.Client, unexport Start, and
restructure NewClient to return a started client.
* Update otlpmetricgrpc New functions
Remove NewUnstarted and only export New.
* Remove unneeded client sync
The exporter handle the synchronization of client method calls.
* Update example_test.go
* Update client_unit_test.go
* Rename client_unit_test.go to client_test.go
* Rename options.go to config.go
* Add package doc
* Unify exporter.go and doc.go into client.go
* Unexport NewClient
* Correct option documentation
* Add env config documentation
* go mod tidy
* Restrict build to Go 1.18
* Update client.go
Fix copied UploadMetrics documentation.
* Run make
* Close client conn even if context deadline reached
* Add sdk/metric Go pkg docs and example (#3139)
* Add sdk/metric Go pkg docs
* Add example_test.go
* Add Go 1.18 build guard to example_test.go
* Merge main into new_sdk/main (#3141)
* Use already enabled revive linter and add depguard (#2883)
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
* Move the minimum version to go 1.17 (#2917)
* Move the minimum version to go 1.17
* Update readme and changelog
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Use ByteSliceToString from golang.org/x/sys/unix (#2924)
Use unix.ByteSliceToString to convert Utsname []byte fields to strings.
This also allows to drop the charsToString helper which serves the same
purpose and matches ByteSliceToString's implementation.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* docs: fix typo (#2935)
* add timeout to grpc connection in otel-collector example (#2939)
* Closes: #2951 (#2952)
This PR updates the example listed in the getting started doc
so that it will compile without error. It also makes this
example consistent with the code found in
https://github.com/open-telemetry/opentelemetry-go/blob/main/example/fib/main.go
Signed-off-by: Brad Topol <btopol@us.ibm.com>
* fix data-model link (#2955)
* Bump go.opentelemetry.io/proto/otlp from v0.16.0 to v0.18.0 (#2960)
* Move to using Instrumentation Scope (#2976)
* Move to using Instrumentation Scope
* Use type alias, not definition
* Add a changelog entry
* docs(website_docs): fix exporting_data.md and getting-started.md toc (#2930)
* docs(website_docs): fix toc
* docs(website_docs): fix toc
* update exporting_data.md for rerun check-links
* update exporting_data.md for rerun check-links
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update getting-started.md (#2984)
grammar edit for line 175 of readme
* fix typo (#2986)
* fix typo
* spell fix
* typo fix (#2991)
* added traces.txt to gitignore for fib (#2993)
* Deprecate Library and move all uses to Scope (#2977)
* Deprecate Library and move all uses to Scope
* Add PR number to changelog
* Don't change signatures in stable modules
* Revert some changes
* Rename internal struct names
* A bit more renaming
* Update sdk/trace/span.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update based on feedback
* Revert change
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Feat/bridge support text map (#2911)
* feat: support TextMap
* doc: add comment
* test: support for ot.TextMap
* Retrieve lost code due to merge
* fix: retrieve lost code due to merge. test: support for ot.HTTPHeaders
* go mod tidy
* Optimized code style, add changelog
* doc: Restore comments
* wip: add test cases
* test: fix args error
* delete empty line
* Fix syntax and changelog errors
* Fix formatting errors
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add a release template (#2863)
* Add a release template
* Update the about field
Co-authored-by: Damien Mathieu <42@dmathieu.com>
* Fix linting Issues
* Add ignore for template link
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Add workflow to automate bundling dependabot PRs (#2997)
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Release prep 1.8.0 (#3001)
* Update CHANGELOG and versions.yaml for 1.8.0 release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update go-build-tools
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare stable-v1 for version v1.8.0
* Prepare experimental-metrics for version v0.31.0
* Prepare bridge for version v0.31.0
* `make go-mod-tidy` should use `-compat=1.17` now
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add benchmark metric test for UpDownCounter (#2655)
* add benchmark metric test for UpDownCounter
* move counter annotation up
* fix syncFloat64 to syncInt64
* fix syncFloat64 to syncInt64
* fix go-lint err
* Add semconv/v1.11.0 (#3009)
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add semconv/v1.12.0 (#3010)
* Add semconv/v1.12.0
* Update all semconv use to v1.12.0
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add http.method attribute to http server metric (#3018)
* Add http.method attribute to http server metric
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix lint
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix lint
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* fix for reviews
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* add changelog entry
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
* Add tests and fix opentracing bridge defer warning (#3029)
* add tests and fix opentracing bridge defer warning
* add changelog entry
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update bridge/opentracing/bridge_test.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Introduce "split" metric schema transformation (#2999)
This is a new transformation type that allows to describe a change
where a metric is converted to several other metrics by eliminating
an attribute.
An example of such change that happened recently is this:
https://github.com/open-telemetry/opentelemetry-specification/pull/2617
This PR implements specification change https://github.com/open-telemetry/opentelemetry-specification/pull/2653
This PR creates package v1.1 for the new functionality. The old package v1.0
remains unchanged.
* Release v1.9.0 (#3052)
* Bump versions in versions.yaml
* Prepare stable-v1 for version v1.9.0
* Prepare experimental-schema for version v0.0.3
* Update changelog for release
* Replace ioutil with io and os (#3058)
* Make several vars into consts (#3068)
* Add support for Go 1.19 (#3077)
* Add support for Go 1.19
* Update CHANGELOG.md
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
* Update compatibility documentation (#3079)
Remove 3 month timeline for backwards support of old versions of Go.
* Fix `opentracing.Bridge` where it miss identifying the spanKind (#3096)
* Fix opentracing.Bridge where it was not identifying the spanKinf correctly
* fix test
* changelog
* Keeping backward comppatibillity
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* replace `required` by `requirementlevel` (#3103)
* Change the inclusivity of exponential histogram bounds (#2982)
* Use lower-inclusive boundaries
* make exponent and logarithm more symmetric
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Update golangci-lint to v1.48.0 (#3105)
* Update golangci-lint to v1.48.0
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Bump go.opentelemetry.io/proto/otlp from v0.18.0 to v0.19.0 (#3107)
* Bump go.opentelemetry.io/proto/otlp from v0.18.0 to v0.19.0
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Update tracer to guard for a nil ctx (#3110)
* Update tracer to guard for a nil ctx
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Fix sdk/instrumentation pkg docs (#3130)
* Add instrumentation scope attributes (#3131)
* Add WithScopeAttributes TracerOption to trace API
* Add Attributes field to instrumentation Scope
* Use scope attributes for new Tracer
* Fix stdouttrace expected test output
* Allow unexported Set fields in sdk/trace test
* Export instrumentation scope attrs in OTLP
* Add changes to the changelog
* Fix imports with make lint
* Add unit tests for WithScopeAttributes
* Fix English in Scope documentation
* Add WithScopeAttributes MeterOption to metric API package (#3132)
* Add WithScopeAttributes MeterOption to metric pkg
* Add MeterConfig unit tests
* Add changes to changelog
* Fix import linting
* Update MeterProvider documentation
Include information about how to use WithScopeAttributes.
* Refactor TracerProvider documentation (#3133)
* Refactor TracerProvider documentation
* Fix English article
* Grammar fixes
* consistency-of: Changed signal names for website docs (#3137)
* Shut down all processors even on error (#3091)
* Fix stdoutmetric example test
The merged instrumentation Scope includes SchemaURL and Attributes now,
add them to the expected output.
Signed-off-by: Brad Topol <btopol@us.ibm.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tobias Klauser <tobias.klauser@gmail.com>
Co-authored-by: petrie <244236866@qq.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Brad Topol <btopol@us.ibm.com>
Co-authored-by: Craig Pastro <pastro.craig@gmail.com>
Co-authored-by: Kshitija Murudi <kmurudi@ncsu.edu>
Co-authored-by: Petrie Liu <lpfvip2008@gmail.com>
Co-authored-by: Guangya Liu <gyliu513@gmail.com>
Co-authored-by: Craig Pastro <craig.pastro@auth0.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: ttoad <qq530901331@outlook.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
Co-authored-by: Mikhail Mazurskiy <126021+ash2k@users.noreply.github.com>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Alan Protasio <alanprot@gmail.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Mitch Usher <cull.methi@gmail.com>
Co-authored-by: Gaurang Patel <mr.patelgaurang@gmail.com>
* Remove empty metrictest pkg (#3148)
* Add exporters/otlp/otlpmetric/internal/otest (#3125)
* Add otlpmetric package doc
* Add Client interface
* Add the Exporter
Have the Exporter ensure synchronous access to all client methods.
* Add race detection test for Exporter
* Expand New godocs
* Fix lint
* Restore otlpmetrictest from main
* Rename otlpmetrictest to otest
* Remove data.go
The functions and types it contains are no longer relevant to the SDK.
* Update client context error tests
Remove multiple shutdown tests. The Client interface states this should
never happen.
* Remove collector.go and otlptest.go
* Expand client tests with ctx and force-flush
* Add UploadMetrics tests
* Test the tests with a trivial client
* Condense all to client.go
* Example of how to run RunClientTests
* Add client integration testing
* Add GRPCCollector
* Remove GRPCCollector to limit scope of PR
* Add back the otlpmetrichttp exporter (#3097)
* Add otlpmetric package doc
* Add Client interface
* Add the Exporter
Have the Exporter ensure synchronous access to all client methods.
* Add race detection test for Exporter
* Expand New godocs
* Fix lint
* Add back the otlpmetrichttp pkg from main
* Restrict to Go 1.18 and above
* Remove integration testing
* Rename client_unit_test.go to client_test.go
* Rename options.go to config.go
* Remove the NewUnstarted func
* Remove Start method from client
* Add no-op ForceFlush method to client
* Update otlpconfig pkg name to oconf
* Rename Stop method to Shutdown
Match the otlpmetric.Client interface.
* Update creation functions to compile
* Remove name field from client
* Remove sync of methods from client
This is handled by the exporter.
* Remove unused generalCfg field from client
* Replace cfg client field with used conf vals
* Use a http request instead of url/header fields
* Remove NewClient and move New into client.go
* Rename client.client field to client.httpClient
* Update client tests
Remove test of a retry config and add functional tests of the client
methods honoring a context.
* Remove deprecated WithMaxAttempts and WithBackoff
* Update option docs
Include info on envvars.
* Fix lint
* Fix lint errors
* Revert New to accept a context
* Add example test
* Update pkg docs
* go mod tidy
* Use url.URL to form HTTP request URL
* Remove stale TODO in sdk/view (#3149)
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Use unique metric testing data in reader_test (#3151)
Address unresolved TODO.
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Add new metric SDK changes to changelog (#3150)
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
* Add integration and config testing to otlpmetricgrpc (#3126)
* Add the GRPCCollector to otest
* Use otest to test otlpmetricgrpc Client
* Add WithHeaders and WithTimeout tests
* Add integration and config testing to otlpmetrichttp (#3155)
* Add HTTPCollector to otest
* Add integration testing for otlpmetrichttp
* Fix NewHTTPCollector docs
* Add config tests
* Fix lint
* Add WithURLPath test
* Add WithTLSClientConfig test
* Ignore depguard for crypto/x509/pkix
This is a testing package that uses the package to generate a weak
testing TLS certificate.
* Add Prometheus exporter code (#3135)
* Add Prometheus exporter example (#3168)
* Add back prom exporter to README.md
* Fix removal changes from #3154 in API
* Update CHANGELOG with PR number
Signed-off-by: Brad Topol <btopol@us.ibm.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tobias Klauser <tobias.klauser@gmail.com>
Co-authored-by: petrie <244236866@qq.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Brad Topol <btopol@us.ibm.com>
Co-authored-by: Craig Pastro <pastro.craig@gmail.com>
Co-authored-by: Kshitija Murudi <kmurudi@ncsu.edu>
Co-authored-by: Petrie Liu <lpfvip2008@gmail.com>
Co-authored-by: Guangya Liu <gyliu513@gmail.com>
Co-authored-by: Craig Pastro <craig.pastro@auth0.com>
Co-authored-by: ttoad <qq530901331@outlook.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
Co-authored-by: Mikhail Mazurskiy <126021+ash2k@users.noreply.github.com>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: Alan Protasio <alanprot@gmail.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Mitch Usher <cull.methi@gmail.com>
Co-authored-by: Gaurang Patel <mr.patelgaurang@gmail.com>
Co-authored-by: Mike Dame <mikedame@google.com>
* Add WithScopeAttributes TracerOption to trace API
* Add Attributes field to instrumentation Scope
* Use scope attributes for new Tracer
* Fix stdouttrace expected test output
* Allow unexported Set fields in sdk/trace test
* Export instrumentation scope attrs in OTLP
* Add changes to the changelog
* Fix imports with make lint
* Add unit tests for WithScopeAttributes
* Fix English in Scope documentation
* Bump versions in versions.yaml
* Prepare stable-v1 for version v1.9.0
* Prepare experimental-schema for version v0.0.3
* Update changelog for release
* Update CHANGELOG and versions.yaml for 1.8.0 release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update go-build-tools
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare stable-v1 for version v1.8.0
* Prepare experimental-metrics for version v0.31.0
* Prepare bridge for version v0.31.0
* `make go-mod-tidy` should use `-compat=1.17` now
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Deprecate Library and move all uses to Scope
* Add PR number to changelog
* Don't change signatures in stable modules
* Revert some changes
* Rename internal struct names
* A bit more renaming
* Update sdk/trace/span.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update based on feedback
* Revert change
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Bump versions
* Prepare stable-v1 for version v1.7.0
* Prepare experimental-metrics for version v0.30.0
* Prepare bridge for version v0.30.0
* Update changelog
Comment should be complete sentences outside of lists with sentence
fragments. This adds the godot linter to check these complete sentences
end with punctuation. If they do not, running fix will append a period.
* Replace use of old term label with attribute
The specification has unified on the term attribute to describe
key-value pairs. There exist still many hold-overs of the use of the
term label. This updates those uses or deprecates exported types and
functions in favor of renamed forms.
* fix infinite recursion
* Remove backticks from attribute set docs
* Remove LabelFilterSelector entirely
* Remove Metadata.Labels instead of deprecate
* Update changelog with public changes
* Revert OC err msg
* No wrap RELEASING Semantic Convention Generation section
* Initial generator
* Update template render
* Add exception and schema templates
* Add semconv/internal http unification
* Add http template
* Add licenses header
* Embed the templates
* Update static version in schema tmpl
* Add semconv-generate target to Makefile
Use this target to generate versions of the semconv packages.
* Generate semconv packages
* Update RELEASING to use make semconv-generate
* Add comments to semconvkit
* Generate semconv/v1.8.0
* Use new version of semconv
* Add changes to changelog
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Update changelog and versions for metric/v0.29.0 release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare experimental-metrics for version v0.29.0
* Prepare bridge for version v0.29.0
* update changelog and versions for 1.6.2 release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare stable-v1 for version v1.6.2
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Upgrade go.opentelemetry.io/proto to v0.15.0
* Fix otlpmetric exporter test
* Fix lint in otlpmetric
* Update otlptrace
* Clean new line breaks
* Fix comment in otlpmetric exporter_test.go
* Add changes to changelog
* Update versions.yaml
* Bump version in changelog
* Prepare stable-v1 for version v1.6.0
* Prepare experimental-metrics for version v0.28.0
* Prepare bridge for version v0.28.0
* Update changelog language
* Bump stable-v1 from v1.4.1 to v1.5.0
* Remove internal/metric module from versions file
This module was removed from the project.
* Prepare stable-v1 for version v1.5.0
* Update changelog
* Update CHANGELOG.md
* Empty All of the metrics dir
* Add instrument api with documentation
* Add a NoOp implementation.
* Updated to the new config standard
* Address PR comments
* This change moves components to sdk/metrics
The Moved components are:
- metric/metrictest
- metric/number
- metric/internal/registry
- metric/sdkapi
* The SDK changes necessary to satasify the new api
* This fixes the remaing tests.
* Update changelog
* refactor the Noop meter and instruments into one package.
* Renamed pkg.Instruments to pkg.InstrumentProvider
Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
* Use port 4318 for otlptracehttp client default
* Use port 4318 for otlpmetrichttp client default
* Add changes to changelog
* Fix arg pass error
* Simplify defaultPath path parsing
* feature/exporter: add Drop Counts for oltptracer's event
Signed-off-by: 1046102779 <seachen@tencent.com>
* feature/exporter: add Drop Counts for oltptracer's event
Signed-off-by: 1046102779 <seachen@tencent.com>
* feature/exporter: add Drop Counts for oltptracer's event and link
Signed-off-by: 1046102779 <seachen@tencent.com>
* feature/exporter: add Drop Counts for oltptracer's event and link
Signed-off-by: 1046102779 <seachen@tencent.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update versions.yaml
* Prepare stable-v1 for version v1.4.1
* Prepare experimental-metrics for version v0.27.1
* Prepare bridge for version v0.27.1
* Update CHANGELOG
* Revert "Prepare experimental-metrics for version v0.27.1"
This reverts commit 838743af21.
* Do not release experimental-metrics with v0.27.1
* Update versions.yaml
* Update changelog
* Upgrade stable-v1 to version v1.4.0
* Upgrade experimental-metrics to version v0.27.0
* Upgrade bridge to version v0.27.0
* Update CHANGELOG.md
* Change trace options to accept type not pointer
Add benchmark to show allocation improvement.
* Update CONTRIBUTING.md guidelines
* Update all Option iface
* Fix grammar in CONTRIBUTING
* Fix TestBackoffRetry in otlp retry pkg
The delay of the retry is within two times a randomization factor (the
back-off time is delay * random number within [1 - factor, 1 + factor].
This means the waitFunc in TestBackoffRetry needs to check the delay is
within an appropriate delta, not equal to configure initial delay.
* Fix delta value
* Fix delta
Co-authored-by: Aaron Clawson <Aaron.Clawson@gmail.com>
* support zipkin exporter endpoint env
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* update interface and changelog
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* add pr number
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* fix lint
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* add import
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* add additional batch overhead in jaeger agent udp exporter
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* update changelog
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update versions.yaml for release
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Prepare stable-v1 for version v1.3.0
* Prepare experimental-metrics for version v0.26.0
* Prepare bridge for version v0.26.0
* Update CHANGELOG
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Fix Jaeger exporter status conversion
The status tag needs to be a string of value `ERROR` or `OK` for Error
and Ok statuses respectively according to the OTel spec.
* Add PR number to changelog
* Fix per-signal endpoint parsing in otlptrace
* Add distinguishing non-per-signal env var value
* Fix per-signal endpoint parsing in otlpmetric
* Add changes to changelog
* Use else if to prevent unnecessary work
* Add spec link to otlptrace README
* Use host CA set by default for otlptrace
* Remove test for invalid default certs
* Default to host CA for otlpmetric
* Add changes to changelog
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Centralize the retry package for the otlp exporters
* Add dependabot config
* Use unified internal/retry module in otlp exporters
* Remove otlpmetric and otlptrace internal/retry module
* Run go mod tidy in otlp{metric,trace}
* Use gRPC ClientConn for otlpmetricgrpc conn handling
* Update PR number
* Update otlpmetrichttp to use retry package
* Remove old commented code
* Add all other external changes to changelog
* POC using the grpc.ClientConn to handle connections
* Update invalid client security test
* Update client start test for a bad endpoint
* Use any ClientConn a user provides
* Connect ReconnectionPeriod to gRPC conn retries
* Replace connection retry handling direct in otlptracegrpc
* Fix client comments
* Fix comment for NewGRPCConfig
* Replace reconnection test
* Fix grammar
* Remove unrelated changes
* Remove connection pkg
* Rename evaluate to retryable
* POC using the grpc.ClientConn to handle connections
* Replace connection retry handling direct in otlptracegrpc
* Add ClientConn use changes to changelog
* Update otlptracegrpc options
* Only close ClientConn that the Client create
* Remove listener wrapper from mock_collector_test
This is not needed now that no tests relies on the listener to wait for
a connection to be established before continuing.
* Fix spelling error
* Do not use deprecated options in the otel-collector example
* Add unit tests for retryable and throttleDelay funcs
* Add unit tests for context heredity
* Add test that exporter stop is linked to context cancel
* go mod tidy
* Update exporters/otlp/otlptrace/otlptracegrpc/client.go
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Fix go.mod from rebase
* Remove wrong comment about client stop closing gRPC conn
* Fix shutdown test cleanup
Do not check the second call to the client Stop. There is no guarantee
it will not error in normal operation.
* Make lint fixes
* Fix flaky unit test
Use the internals of the client to explicit cancel the context returned
from exportContext. This gets around the bug where the select in Stop
may randomly choose the non-context Done case and avoid returning an
error (also failing to cancel the context).
* Remove deprecation
To configure the client/exporter with environment variables these
options are used. There is no way to fully remove these options without
removing support for configuration with environment variables. Leave
that decision and strategy determination to a separate PR.
* Fix grammatical error in comment
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Fail in RunEndToEndTest if collector stop fails
* Use testing T.Cleanup to check shut downs
* Add goroutine leak detection
* Fix TestExporterShutdown go leak
The shutdown tests checking if a context error is honored did not
completely clean up the resources used by the client after the error was
evaluated. Update the connection client to handle multiple calls to
shutdown and make a second call to these clients that must succeed so
the test does not have abandoned goroutines.
* Fix leak in TestNew_WithTimeout
The mockTraceService did not delay with its lock being held. This
resulted in the mockCollector stopping and being able to acquire the
lock. It was assumed that no export was taking place because of this and
the mockTraceService was abandoned without cleaning up resources it held
and goroutines it had spawned. This reworks the export blocking logic to
block on a channel read. This will make the block more deterministic and
not depend on the scheduler timing. Additionally, this blocking is moved
inside the lock acquire. Meaning code will deadlock if the block is not
released before a shutdown (something the developer will immediately be
aware of when they submit a bad patch), and will ensure all resources
are released before shutdown.
Replace TestNew_WithTimeout with TestExportSpansTimeoutHonored which
directly tests if a span export errors when the timeout is reached. This
is the only unique thing that TestNew_WithTimeout, but it also tests the
non-error path. That non-error path is tested in many other tests.
* Guard otlptracehttp client stopCh when stopping
In normal operations the exporter is guaranteed to only ever call the
client Stop method once. However in testing we need to call this
multiple times when checking it returns an error in particular context.
Add a lightweight sync.Once to the closing of the stopCh to ensure tests
do not panic when cleaning up.
* Release export block after export
Prevent deadlock in TestExportSpansTimeoutHonored.
