1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Commit Graph

15 Commits

Author SHA1 Message Date
Matthieu MOREL 68841fa6db chore: enable unused-receiver rule from revive (#7130)
#### Description

Enable and fixes
[unused-receiver](https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#unused-receiver)
rule from revive

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-08-08 15:38:22 -07:00
Matthieu MOREL d464abf1f3 chore: enable unused-parameter rule from revive (#7122)
#### Description

Enable and fixes
[unused-parameter](https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#unused-parameter)
rule from revive

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-08-04 12:48:04 -07:00
Tyler Yahn 90a9d1d936 Do not inline noopSpan.tracerProvider (#6456)
Currently, the `noopSpan.tracerProvider` is inlined into
`noopSpan.TracerProvider` for binaries built with standard tooling. This
function is needed in the ELF file for auto-instrumentation. Ensure
this, and the other required methods are always kept isolated.

cc @open-telemetry/go-instrumentation-approvers

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
2025-03-19 14:50:43 -07:00
Tyler Yahn 9aae208463 Add an auto-instrumentable no-op implementation to the trace package (#6203)
This copes the `go.opentelemetry.io/auto/sdk` package into the
`go.opentelemetry.io/otel/trace` package. This is done to avoid package
import cycles and still provide an auto-instrumentable SDK (see
https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/974).

## Overview of changes

The code copied is updated with the following changes. The over-all goal
is to ensure none of this is exported and follows the `auto/sdk` as
close as possible to help maintenance.

### `trace/auto.go`

Consolidation of the following into a single file:

-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/tracer_provider.go
-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/tracer.go
-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/span.go
-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/limit.go

Has the following changes:

- `func TracerProvider()` renamed to `newAutoTracerProvider`
- `type tracerProvider struct` renamed to `autoTracerProvider`
- `type tracer struct` renamed to `autoTracer`
- `type span struct` renamed to `autoSpan`
- Lint issues addressed based on this repositories configuration (these
changes are being back-ported upstream)

### `trace/auto_test.go`

Consolidation of the following into a single file:

-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/tracer_provider_test.go
-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/tracer_test.go
-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/span_test.go
-
https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/limit_test.go

Has the following changes:

- Renames in `trace/auto.go` are applied here
- Lint issues addressed based on this repositories configuration (these
changes are being back-ported upstream)

### `trace/internal/telemetry`

Copied from
https://github.com/open-telemetry/opentelemetry-go-instrumentation/tree/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/internal/telemetry

- Pacakge vanity URLs added
- Lint issues addressed based on this repositories configuration (these
changes are being back-ported upstream)
- Use of the package name has been updated

#### `trace/internal/telemetry/test`

Copied from
https://github.com/open-telemetry/opentelemetry-go-instrumentation/tree/aea085dd2a3640630ac07a2187cbda9d15d2dd00/sdk/internal/telemetry/test

- Module name updated
- Documentation updated with new package name
- Testing values updated with new package name

---------

Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
2025-02-04 08:04:14 -08:00
qcheng 554282d3e4 trace: Add Span.AddLink method (#5032) 2024-03-28 08:35:15 +01:00
Robert Pająk 6ff94ab620 trace: SpanFromContext and SpanContextFromContext make no allocs (#5049) 2024-03-12 08:39:28 +01:00
Robert Pająk 7dea232a46 [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
Tyler Yahn 1e1cc901a5 Add embedded package to trace API (#4620)
* Add trace/embedded

* Update trace impl to use trace/embedded

* Add noop pkg to replace no-op impl in trace pkg

* Use trace/embedded in global impl

* Use trace/embedded in SDK impl

* Update opencensus bridge

* Update opentracing bridge

* Add changes to changelog

* Update trace/doc.go

Co-authored-by: David Ashpole <dashpole@google.com>

---------

Co-authored-by: David Ashpole <dashpole@google.com>
2023-10-19 10:16:24 -07:00
Charlie Le 1b55281859 docs(typos): Run codespell to fix typos (#3980)
* docs(typos): Run codespell to fix typos

There were a lot of typos through the repository, so I ran
[codespell][], a tool for automatically fixing typos, to fix them.

```console
make codespell
```

There's already a tool called [misspell][] that's supposed to take care
of this, but misspell hasn't been updated for 6 years, and it doesn't
seem to be catching any of the typos that codespell can.

[codespell]: https://github.com/codespell-project/codespell
[misspell]: https://github.com/client9/misspell

* Revert and ignore spelling for Consequentially

* Add GH workflow for codespell

* Revert GH Workflow and Makefile for codespell

Per @pellared, since there's no instructions for setting up codespell,
it was suggested that the changes for setting up a workflow and section
in Makefile include instructions for setting up codespell as well.

* Revert spelling on consequently

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-04-11 17:28:13 -07:00
Tyler Yahn fdfc821bac Add godot linter to golangci (#2845)
Comment should be complete sentences outside of lists with sentence
fragments. This adds the godot linter to check these complete sentences
end with punctuation. If they do not, running fix will append a period.
2022-04-25 13:22:49 -07:00
Anthony Mirabella 39fe8092ed Add span.TracerProvider() (#2009)
* Ensure that no-op tracer still progates non-recording spans

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Add `TracerProvider` to the `trace.Span` interface

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Remove config from oteltest.Tracer as it can be accessed through the provider

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
2021-06-17 12:05:44 -04:00
Aaron Clawson c1f460e097 Update API configs. (#1921)
* Added Reason to Contributing and Updated TracerConfig

* PR comment fixup

* Changed how span Options work.

* Fix Markdown linting

* Added meter configs.

* Fixes from PR comments

* fix for missing instrument

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-05-27 07:53:56 -07:00
Tyler Yahn b6d5442ff6 Remove the Tracer method from the Span API (#1900)
* Remove the Tracer method from the Span API

* Update CHANGELOG with changes

* Update CHANGELOG.md

* Fix misspell

* Address feedback
2021-05-12 11:19:50 -04:00
Tyler Yahn 604b05cbcf Store current Span instead of local and remote SpanContext in context.Context (#1731)
* Store Span instead of local/remote SpanContext in Context

Now that the SpanContext has a remote identifier, storing a Span's
SpanContext two separate ways in a Context (one for local another for
remote) is unnecessary and adds complication throughout the project when
determining heredity of a Span. This moves to storing the Span directly
in the Context uniformly (for both local and remote) as current Span. In
the process, it updates the getter/setter functionality the `trace`
package provides and replaces the distributed heredity logic throughout
the project with just using the current Span as the parent if it exists.

* Update trace/context.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Assert propagators context remote state

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-03-29 08:55:44 -07:00
Tyler Yahn 65c7de2069 Remove trace prefix from NoOp src files. (#1679) 2021-03-09 09:12:06 -08:00