* Update grpctrace instrumentation span names
Span names MUST not contain the leading slash (`/`) that the grpc
package prepends to all `FullMethod` values. This replaces the
`serviceFromFullMethod` function with a parsing function. This parsing
function returns an span name adhering to the OpenTelemetry semantic
conventions as well as formatted span attributes.
Additionally, the service name needs to include the package if one
exists. This updates that attribute accordingly.
Once #900 is merged the method attributes can be added by uncommenting.
Resolves#916
* Update Changelog
* Update comment to plural
* Switch from regexp to string parsing
* Consolidate attributes before creating span
* Update Changelog with addition of rpc.method in grpctrace
* Fix test spanMap lookup key
* Update instrumentation/grpctrace/interceptor.go
Co-authored-by: ET <evantorrie@users.noreply.github.com>
* Unify on explicit typed return value
* Fix copy paste error
Co-authored-by: ET <evantorrie@users.noreply.github.com>
* Add http content size to standard package
Signed-off-by: Sam Xie <xsambundy@gmail.com>
* Include `http.request_content_length` in HTTP request basic attributes
Signed-off-by: Sam Xie <xsambundy@gmail.com>
* Add test for api.standard package
Signed-off-by: Sam Xie <xsambundy@gmail.com>
* Update CHANGELOG
Signed-off-by: Sam Xie <xsambundy@gmail.com>
* Fix http content size naming
Signed-off-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* set othttp span status from HTTP status code
* set othttp span status from HTTP status code
* set othttp span status from HTTP status code
* remove the cast to int of statusCode
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
