1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-14 10:13:10 +02:00
Commit Graph

2063 Commits

Author SHA1 Message Date
Tyler Yahn
3c75a44f84
Move metric No-Op to metric/noop (#3893)
* Move metric No-Op to noop pkg

* Remove the unneeded embedded ifaces

* Update CHANGELOG.md

Co-authored-by: Peter Liu <lpfvip2008@gmail.com>

---------

Co-authored-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
2023-03-21 14:25:23 -05:00
Peter Liu
571ff65854
[doc] replace jaeger exporter with otlp http exporter (#3705)
* update exporters.md

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* add jaeger version which support otlp exporter

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* add jaeger version which support otlp exporter

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* Update website_docs/exporters.md

Co-authored-by: Robert Pająk <pellared@hotmail.com>

---------

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
2023-03-21 09:56:25 -05:00
Tyler Yahn
90df52586b
Split metric configuration down to instrument (#3895)
* Split metric configuration down to instrument

* Rename *ObserverOptions to *ObservableOption

* Update option docs with links
2023-03-21 08:16:57 -05:00
Tyler Yahn
6eb1157b45
Update metric API documentation (#3896)
* Update metric API documentation

Remove the warning on otel/metric not being GA.

Document the otel/metric and otel/metric/instrument package for
instrumenters.

* Remove unrendered links in MeterProvider.Meter doc

* Clarify synchronous and asynchronous

* Fix misspelling

* Update metric/instrument/doc.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update metric/instrument/doc.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update metric/instrument/doc.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update metric/instrument/doc.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Apply feedback

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2023-03-20 13:35:26 -07:00
Tyler Yahn
b7b53bba40
Remove Synchronous and rename Asynchronous (#3892)
* Remove the Synchronous interface

* Rename Asynchronous to Observable

* Update PR number
2023-03-20 13:26:17 -07:00
OpenTelemetry Bot
4ccd590569
dependabot updates Sun Mar 19 14:50:15 UTC 2023 (#3910)
Bump github.com/golangci/golangci-lint from 1.51.2 to 1.52.0 in /internal/tools
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/otlp/otlptrace
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/otlp/otlpmetric
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/otlp/otlptrace/otlptracehttp
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/otlp/otlpmetric/otlpmetrichttp
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/otlp/otlptrace/otlptracegrpc
Bump google.golang.org/protobuf from 1.29.1 to 1.30.0 in /exporters/prometheus
2023-03-19 07:58:22 -07:00
dependabot[bot]
c276995621
Bump actions/setup-go from 3 to 4 (#3901)
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-19 07:47:08 -07:00
Tyler Yahn
9215136863
Update "How to Get PRs Merged" section of CONTRIBUTING.md (#3868)
* Update "How to Get PRs Merged" sec of CONTRIBUTING

* Link to local approvers and maintainers

---------

Co-authored-by: Damien Mathieu <damien.mathieu@elastic.co>
2023-03-17 11:40:22 -07:00
Sinan Ülker
7fc24d2b14
Update the metric Export interface to accept a *ResourceMetrics instead of ResourceMetrics (#3853)
* Change the signature of Export method

* Pass tests for otlp exporter

* Pass tests for otlp grpc and http packages

* Update opencensus bridge

* Refactor and pass tests for stdoutmetric package

* Update periodic reader tests

* Update changelog

* Apply suggestions

* Apply suggestions

* Update CHANGELOG.md

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-03-16 10:58:43 -07:00
Mori
3a40e65a38
Update go directive value in go.mod files to 1.19 (#3850)
* remove go 1.18 in go.mod, add go 1.19

* revert //+build directives

* remove +build directives

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-03-15 09:52:04 -07:00
OpenTelemetry Bot
0694868e55
dependabot updates Wed Mar 15 14:54:57 UTC 2023 (#3885)
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/prometheus
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/otlp/otlptrace/otlptracegrpc
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /internal/tools
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/otlp/otlpmetric
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/otlp/otlpmetric/otlpmetrichttp
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/otlp/otlpmetric/otlpmetricgrpc
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /example/otel-collector
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/otlp/otlptrace/otlptracehttp
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /exporters/otlp/otlptrace
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /example/prometheus
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /example/view
Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 in /bridge/opentracing/test
Bump benchmark-action/github-action-benchmark from 1.15.0 to 1.16.2
2023-03-15 09:11:15 -07:00
Robert Pająk
9b398a63d7
Update SIG meeting notes URL (#3869)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-03-14 09:36:13 -07:00
Tyler Yahn
01b8f15a72
Add Exemplar to metricdata package (#3849)
* Add Exemplar to metricdata pkg

* Update histogram Aggregator

* Update opencensus bridge

* Update prometheus exporter

* Update OTLP exporter

* Update stdoutmetric exporter

* Add changes to changelog

* Update fail tests

* Add tests for IgnoreExemplars

* Fix merge
2023-03-14 07:56:18 -07:00
Tyler Yahn
b62eb2ca88
Pool sortables used to create attribute sets (#3832)
* Pool sortables used to create attribute sets

* Move sync pool to attribute pkg

* Add change to changelog

* Fix comment

* Apply suggestions from code review

Co-authored-by: Peter Liu <lpfvip2008@gmail.com>

* Update sdk/metric/instrument.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update comment based on feedback

* Apply feedback

---------

Co-authored-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
2023-03-13 11:19:28 -07:00
OpenTelemetry Bot
4af35a97dd
dependabot updates Mon Mar 13 14:52:37 UTC 2023 (#3867)
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/otlp/otlpmetric/otlpmetrichttp
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/otlp/otlptrace/otlptracehttp
Bump golang.org/x/tools from 0.6.0 to 0.7.0 in /internal/tools
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/otlp/otlpmetric
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/otlp/otlptrace/otlptracegrpc
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/prometheus
Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 in /exporters/otlp/otlptrace
Bump benchmark-action/github-action-benchmark from 1.15.0 to 1.16.2
2023-03-13 08:15:00 -07:00
Peter Liu
6a95d5770c
New stdoutmetric encoder with ignore timestamp (#3828)
* new stdoutmetric encoder with ignore timestamp

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* refactor to avoid using a dedicated encoder

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* remove useless encoder code

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* dont't change the original data

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* Update exporters/stdout/stdoutmetric/exporter.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* complete test data and add changelog entry

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>

* Move changelog entry to unreleased

---------

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
2023-03-09 11:41:47 -08:00
Aaron Clawson
e463505da7
Reuse memory in metric pipelines (#3760)
* Have pipelines reuse memory

* truncate Metric slice

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Use rm pool on periodic shutdown.

* zero out RM on ctx error

* Update sdk/metric/pipeline.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Fix lint

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
2023-03-09 09:43:16 -08:00
Tyler Yahn
7dc7b30405
Remove unneeded type argument from metric SDK (#3831)
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
2023-03-09 07:33:18 -08:00
Tyler Yahn
1626ff746f
Wrap errors returned from Detect and New in sdk/resource (#3844)
* Update Detect and New to wrap errors

* Add TestNewWrapedError

Test that New returns an error that can be unwrapped.

* Add changes to changelog

* Clarify and simplify errors
2023-03-08 15:15:27 -08:00
Robert Pająk
f993fac236
Update metrics project status to beta (#3843) 2023-03-08 07:42:38 -08:00
Tyler Yahn
60f7d42d1e
Remove the deprecated otel/metric/global pkg (#3829)
* Remove the deprecated `otel/metric/global` pkg

* Add changelog entry

* Update PR number in changelog

* Fix lint

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
2023-03-07 08:36:19 -08:00
Alan Protasio
3015c86cfd
Avoid creating new references on WithDeferredSetup for every span (#3833)
* Avoid creating new references on WithDeferredSetup call
2023-03-07 07:40:31 -06:00
OpenTelemetry Bot
3df561e644
dependabot updates Mon Mar 6 15:33:46 UTC 2023 (#3840)
Bump github.com/itchyny/gojq from 0.12.11 to 0.12.12 in /internal/tools
Bump golang.org/x/sys from 0.5.0 to 0.6.0 in /sdk
2023-03-06 07:40:41 -08:00
Tyler Yahn
c869b9171a
Document httpconv and netconv packages as trace providing only trace semantic convention (#3823)
* Document {http,net}conv pkgs as trace semconv

* Fix spelling error
2023-03-02 11:42:46 -08:00
Tyler Yahn
34aacd95ff
Release v1.15.0-rc.1 (#3825)
* Bump module set versions

* Prepare stable-v1 for version v1.15.0-rc.1

* Prepare experimental-metrics for version v0.38.0-rc.1

* Update changelog
2023-03-02 07:43:27 -08:00
Tyler Yahn
813936187e
Support a global MeterProvider in go.opentelemetry.io/otel (#3818)
* Move ErrorHandler impl to internal

To avoid the import cycle, the otel/metric package needs to not import
otel. To achieve this, the error handling implementation is moved to the
otel/internal/global package where both can import the needed
functionality.

* Add global metric to go.opentelemetry.io/otel

* Crosslink and update to global metric in otel

* Add changes to changelog

* Set PR number in changelog

* Add global metric unit tests

* Rename MeterProivder() to GetMeterProivder()

* Add TODO to remove nolint comments
2023-03-01 11:16:03 -08:00
Tyler Yahn
c39e625cdf
Drop compatibility testing for Go 1.18 (#3813)
* Drop support for Go 1.18

* Add changes to changelog

* Add PR number
2023-03-01 09:15:39 -08:00
Tyler Yahn
264becee27
Remove the deprecated metric/unit package (#3814)
* Remove the dep metric/unit package

* Add PR number
2023-02-28 14:14:43 -08:00
Robert Pająk
d0e4a438ef
Handle empty env vars as it they were not set (#3764)
* Handle empty env vars as it they were not set

* Add changelog entry

* Add missing unit test
2023-02-28 12:43:48 -08:00
Tyler Yahn
2e54fbb3fe
Release v1.14.0/v0.37.0/v0.0.4 (#3810)
* Bump mod versions

* Add bridge/opentracing/test to versions.yaml

* Prepare stable-v1 for version v1.14.0

* Prepare experimental-metrics for version v0.37.0

* Prepare experimental-schema for version v0.0.4

* Update changelog
2023-02-27 13:57:23 -08:00
Aaron Clawson
46d7f8dad3
Add Note about dropping go 1.18 (#3771)
* Add Note about dropping go 1.18

* Fix lint

* Apply suggestions from code review

Co-authored-by: Robert Pająk <pellared@hotmail.com>

---------

Co-authored-by: Damien Mathieu <damien.mathieu@elastic.co>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
2023-02-27 11:01:34 -08:00
Patrice Chalin
b177f58e09
[docs] fix link to traces concept page (#3807)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-02-27 10:02:22 -08:00
Sinan Ülker
2c213bf585
Restructure compatibility testing (#3779)
* Restructure compatibility testing

* Add PR number into Changelog

* Keep the original name for compatibility matrix

* Remove changelog entry

* Apply suggestions

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-02-27 09:20:06 -08:00
Tigran Najaryan
071d317394
Fix incorrect "all" and "resource" definition for Schema File (#3777)
The "all" and "resource" sections had incorrect definitions of "attribute_rename"
transform. It was missing the subkey "attribute_map".

This is a bug fix and makes the implementation compliant with the spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/schemas/file_format_v1.1.0.md#resources-section

Related issue: https://github.com/open-telemetry/opentelemetry-specification/issues/3245

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-02-27 08:38:41 -08:00
Tyler Yahn
fe6856e804
Deprecate metric/unit and use a string for units in the metric API/SDK (#3776)
* Replace Unit from metric/unit with string

Deprecate the units package. This package will not be included in the
metric GA.

* Add changes to changelog
2023-02-27 08:10:56 -08:00
Aaron Clawson
17e5d0f549
Do not wrap error if multierror does not have one. (#3772) 2023-02-27 09:10:55 -06:00
dependabot[bot]
01bbea3285
Bump lycheeverse/lychee-action from 1.5.4 to 1.6.1 (#3780)
Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.5.4 to 1.6.1.
- [Release notes](https://github.com/lycheeverse/lychee-action/releases)
- [Commits](https://github.com/lycheeverse/lychee-action/compare/v1.5.4...v1.6.1)

---
updated-dependencies:
- dependency-name: lycheeverse/lychee-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-26 08:27:14 -08:00
OpenTelemetry Bot
0a75c5bd8a
dependabot updates Sun Feb 26 15:49:13 UTC 2023 (#3804)
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /bridge/opentracing/test
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/internal/retry
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /schema
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/otlpmetric/otlpmetrichttp
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/prometheus
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /metric
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/jaeger
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/otlpmetric/otlpmetricgrpc
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/zipkin
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /trace
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/otlpmetric
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/stdout/stdouttrace
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/otlptrace/otlptracegrpc
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/otlptrace
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/otlp/otlptrace/otlptracehttp
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /exporters/stdout/stdoutmetric
Bump github.com/golangci/golangci-lint from 1.51.1 to 1.51.2 in /internal/tools
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /sdk/metric
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /bridge/opencensus
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /sdk
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2
Bump golang.org/x/sys from 0.0.0-20220919091848-fb04ddd9f9c8 to 0.5.0 in /sdk
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /bridge/opentracing
Bump lycheeverse/lychee-action from 1.5.4 to 1.6.1
2023-02-26 07:58:24 -08:00
Kason Braley
6fa6afba26
Fix global.MeterProvider documentation (#3774) 2023-02-24 11:11:52 -08:00
Robert Pająk
1d6704c8fc
Support OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT (#3763)
* Support OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT

* Fix non-positive duration error log


Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-02-24 09:26:47 -06:00
Patrice Chalin
3d6a643980
Run website formatter over website_docs (#3762)
* Run website formatter over website_docs

* Ignore selected website_docs links
2023-02-24 07:35:24 -06:00
Pijus Navickas
69d09462db
Implement IsSampled for OpenTelemetry bridgeSpanContext (#3570)
* Add IsSampled to OpenTracing bridge

* Add entry to CHANGELOG

* Add note to the README

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update bridge/opentracing/README.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update bridge/opentracing/README.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update bridge/opentracing/README.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update bridge/opentracing/README.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Add PR ID to changelog note

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-02-23 13:11:48 -08:00
Tyler Yahn
99ec432679
Accept scope attributes during Tracer creation (#3739)
* Accept scope attributes during Tracer creation

The OTel specification requires the instrumentation attributes are
accepted by the API for the Tracer. This adds a TracerOption to satisfy
that requirement.
2023-02-21 13:31:37 -06:00
Patrice Chalin
1c5aed692c
[website_docs] Fix link to Go logo (#3758) 2023-02-21 13:19:16 -06:00
Severin Neumann
867900e519
Restructure Website documentation (#3585)
* Restructure Website documentation

Signed-off-by: svrnm <neumanns@cisco.com>

* Update website_docs/getting-started.md

* Update website_docs/exporters.md

Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>

---------

Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Damien Mathieu <damien.mathieu@elastic.co>
2023-02-21 13:07:45 -06:00
Damien Mathieu
37931d44b9
Allow using OTLP export retrier concurrently (#3756)
* allow using OTLP export retrier concurrently
2023-02-21 11:43:24 -06:00
Tyler Yahn
de94fafd17
Do no silently drop unknown schema data (#3743)
* Do no silently drop unknown schema data

* Add entry to changelog

* Add PR number to changelog

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
2023-02-21 08:39:38 -08:00
Tyler Yahn
f78f72d66c
Merge instrument cache to inserter (#3724)
* Merge instrument cache to inserter

The current pipeline resolution path will only add the resolved
aggregators to the pipeline when it creates one (cache miss). It will
not add it if there is a cache hit. This means (since we cache
instruments at the meter level, not the pipeline level) the first reader
in a multiple-reader setup is the only one that will collect data for
that aggregator. All other readers will have a cache hit and nothing is
added to the pipeline. This is causing #3720.

This resolves #3720 by moving the instrument caching into the inserter.
This means aggregators are cached at the reader level, not the meter.

* Rename aggCV to aggVal

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
2023-02-21 08:07:37 -08:00
Aaron Clawson
cc8bdaaad4
Change the Reader.Collect Signature. (#3732)
* Changes the signature of Collect().

This DOES NOT make the SDK reuse memory, but it does enable it to be added.
2023-02-21 09:04:27 -06:00
Tyler Yahn
ecf0838245
Add "[chore]" PR prefix to skip changelog check (#3754)
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2023-02-17 19:45:41 -05:00