Cheng-Zhen Yang has not had any activity in several months, and he
confirmed to me on slack that he can't contribute anymore and we should
move him to emeritus.
cc @scorpionknifes
---------
Co-authored-by: Flc゛ <i@flc.io>
Fix typos and linguistic errors in documentation. It's not much, but I'm
happy to help
---------
Signed-off-by: Sebastien Dionne <survivant00@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Self-Observability is a redundant term, the self being instrumented is
always the self that observability is being provided for. Remove this
redundancy.
Continue to provide backwards compatibility for any users already using
`OTEL_GO_X_SELF_OBSERVABILITY` to enable the feature.
---------
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Resolve#6245Resolve#6246Resolve#6241
Add a "v1.0.0" security insights policy to the repository.
This does not add a "v2.0.0" version of the insights policy as the [CLO
monitor
documentation](https://clomonitor.io/docs/topics/checks/#security-insights)
still reference the "v1.0.0" policy. The policy can be updated if the
CLO tooling is also updated in the future.
Based on SIG meeting discussions today: relax requirement for two
approvals from Approvers at different companies. Instead, require at
least one approver or the author to not work at the same company.
This means that if the author works at a different company than two
Approvers who have approved and work at the same company, the PR is
ready to merge.
This continues the enforcement that if an author and all Approvers
approving a PR work at the same company, additional qualified approvals
are needed.
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Per [OpenSSF Best Practices](https://www.bestpractices.dev/en):
> It is SUGGESTED that this policy on adding tests be documented in the
instructions for change proposals.
This proposes adding @scorpionknifes as a triager for the Go SIG.
While Cheng-Zhen's contributions are all in the contrib repository, we
don't currently split roles between the two repos.
Cheng-Zhen's contributions in the log bridges, and his interest in being
more involved with the SIG make him a nice fit to be a triager.
Based on a change in role and priorities, @MadVikingGod is no longer
able to focus on OTel. This moves him out of a maintainer role and into
an Emeritus status.
Thank you @MadVikingGod for all the contributions!
After off-line discussions, the existing maintainers have all agreed
that the contributions made by both @XSAM and @dmathieu motivate adding
them as maintainers to the project. Both @XSAM and @dmathieu have
confimed they are interested in the position and willing to accept the
responsibilities.
### TODO
- [ ] Add @XSAM to maintainers group
- [ ] Add @dmathieu to maintainers group
- [ ] Copy the substance of this PR into the contrib repository
Co-authored-by: Sam Xie <sam@samxie.me>
Removing myself as contributor since I have not approved anything in a
long time.
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add David Ashpole as a maintainer
* Sort the maintiners by surname.
Co-authored-by: Robert Pająk <pellared@hotmail.com>
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com>
* feat(ci): Add codespell to Makefile and GitHub Actions
This is a followup from
https://github.com/open-telemetry/opentelemetry-go/pull/3980 to add the
automation for checking for code spelling errors to a different PR.
[Codespell][] makes use of the `.codespellrc` file automatically as a config
file for convenience. The configuration file specifies directories and
flags to pass to `codespell`. Codespell also makes use of the
`.codespellignore` file to ignore certain word spellings.
There is a new section in `Makefile` for installing python tooling.
It is similar to how the go tools are installed. It sets up a virtualenv
in `venv `and installs python tooling there if it hasn't been installed
yet.
The new [codespell workflow][] will run in pull requests to annotate
misspelled words. It is set up to only warn the user with annotations in
the pull request if there are typos, but we can fail the pull request as
well if we want to by deleting the [warn_only][] key.
[codespell]: https://github.com/codespell-project/codespell
[codespell workflow]: https://github.com/codespell-project/actions-codespell
[warn_only]: https://github.com/codespell-project/actions-codespell#parameter-only_warn
* Use docker to run python and codespell
Since this is a Go project, having a dependency on python seemed
disconcerting. So, docker is used to create a virtual environment
with a python image and also run the tools that were installed.
* Remove wording on requirement for python
* Apply suggestions from code review
Co-authored-by: Damien Mathieu <42@dmathieu.com>
* Pin versions into requirements.txt
* Pin version in requirements.txt
* Fix typo in license
* Revert typo fix on deleted file
* Update .github/workflows/codespell.yaml
Co-authored-by: Robert Pająk <pellared@hotmail.com>
* Update codespell.yaml
* Update codespell.yaml
---------
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* docs(typos): Run codespell to fix typos
There were a lot of typos through the repository, so I ran
[codespell][], a tool for automatically fixing typos, to fix them.
```console
make codespell
```
There's already a tool called [misspell][] that's supposed to take care
of this, but misspell hasn't been updated for 6 years, and it doesn't
seem to be catching any of the typos that codespell can.
[codespell]: https://github.com/codespell-project/codespell
[misspell]: https://github.com/client9/misspell
* Revert and ignore spelling for Consequentially
* Add GH workflow for codespell
* Revert GH Workflow and Makefile for codespell
Per @pellared, since there's no instructions for setting up codespell,
it was suggested that the changes for setting up a workflow and section
in Makefile include instructions for setting up codespell as well.
* Revert spelling on consequently
---------
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update "How to Get PRs Merged" sec of CONTRIBUTING
* Link to local approvers and maintainers
---------
Co-authored-by: Damien Mathieu <damien.mathieu@elastic.co>