igrucci
cc43e01c27
chore: move functionality from internal/rawhelpers.go to attribute ( #6578 )
...
Resolve #6524
---------
Signed-off-by: igrucci <babichevigor12@gmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
Co-authored-by: Tyler Yahn <codingalias@gmail.com >
2025-04-10 09:04:50 -07:00
Rabel Mervin
5bf8691520
Functionality moved from internal/attribute to attribute ( #6580 )
...
Resolve #6525
## Description
This pull request addresses the issue of moving internal functionality
from the `internal/attribute` package to the `attribute `package within
the open-telemetry/opentelemetry-go repository. The goal is to ensure
that none of this functionality is added to the public API of the
attribute or any other public package while improving the naming,
layout, and following Go idioms.
## Changes made
1. Moved Functions to `attribute/internal`
- Created a new internal package within the `attribute` package:
`attribute/internal`.
- Moved `attribute.go` and `attribute_test.go` into the
`attribute/internal`
- Moved the following functions from `internal/attribute` to
`attribute/internal`
2 . Changes in .golangci.yml
- Removed line 67 and 68 from .golangci.yml
---------
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2025-04-03 14:12:30 +01:00
Damien Mathieu
f8b9fe3dbe
Emit attributes slices as their json representation ( #5159 )
...
* emit slices as their json representation
* add changelog
* fix resource tests
* indicate invalid slice if we couldn't turn them into json
* move changelog entry to the unreleased section
---------
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2024-05-07 07:42:07 -07:00
Robert Pająk
7dea232a46
[chore] Simplify the license header ( #4987 )
2024-02-29 07:05:28 +01:00
Peter Liu
d68b05fbee
Refactor package internal/attribute to not use generics. ( #3725 )
...
* remove generics
Signed-off-by: Peter Liu <lpfvip2008@gmail.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Update internal/attribute/attribute.go
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* refactor unit test
Signed-off-by: Peter Liu <lpfvip2008@gmail.com >
* add changelog
Signed-off-by: Peter Liu <lpfvip2008@gmail.com >
* update changelog
Signed-off-by: Peter Liu <lpfvip2008@gmail.com >
* Update internal/attribute/attribute.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
* replace interface{} with any
Signed-off-by: Peter Liu <lpfvip2008@gmail.com >
---------
Signed-off-by: Peter Liu <lpfvip2008@gmail.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2023-02-15 10:37:07 -08:00
Aaron Clawson
d7b31155b5
Make the AsType functions not panic ( #3489 )
...
* Make the AsType functions not panic
* Adds changelog
Signed-off-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com >
Signed-off-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com >
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
2022-11-25 15:27:47 -08:00
Ziqi Zhao
a8b9ddc7f6
attribute: fix slice related function bug ( #3252 )
...
* attribute: fix slice related function bug
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
2022-10-13 09:34:02 -05:00
Tyler Yahn
1f5b159161
Use already enabled revive linter and add depguard ( #2883 )
...
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
2022-05-19 15:15:07 -05:00
Chester Cheung
7aba6f796f
update wrong doc comment with attribute value ( #2476 )
2021-12-20 08:10:34 -08:00
Tyler Yahn
ef126f5ce1
Remove deprecated Array from attribute package ( #2235 )
...
* Remove deprecated Array from attribute pkg
* Add changes to changelog
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com >
2021-09-10 11:51:02 -04:00
Anthony Mirabella
eaacfaa801
Fix slice-valued attributes when used as map keys ( #2223 )
...
* Fix slice-valued attributes when used as map keys
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
* store pointers to slice values to make them usable as map keys
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
* Emit slice-typed attribute values as slices, not pointers to slices
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2021-09-09 08:42:47 -07:00
Tyler Yahn
87d09df346
Deprecate Array attribute in favor of *Slice types ( #2162 )
...
* Deprecate Array attribute in favor of *Slice types
* Use new attr types in Jaeger exporter
* Use slice attr types in otlpmetric
* Use slice attr types in otlptrace
* Use slice attr types in zipkin exporter
* Remove array attr test from deprectated oteltest func
* Use StringSlice for cmd arg resource attr
* Add changes to the changelog
* Remove use of deprecated Array func
2021-08-12 08:05:42 -07:00
Tyler Yahn
a882ee3792
Clarify the attribute package documentation and order/grouping ( #2168 )
...
* Clarify attr key docs and func grouping
* Update KeyValue func docs and ordering
* Move IntValue creation function closer Int64Value
* Apply suggestions from code review
Co-authored-by: Robert Pająk <pellared@hotmail.com >
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2021-08-11 10:08:46 -07:00
Guangwen Feng
5c99a34cd8
Fix golint issue caused by incorrect comment ( #1795 )
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com >
2021-04-12 08:10:00 -07:00
Punya Biswal
ecf65d7968
Rename otel/label -> otel/attribute ( #1541 )
...
* Rename otel/label -> otel/attr
Leave the imported name alone, to avoid a large diff and conflicts
* Better import comment
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
* otel/attr -> otel/attribute
* Missed the changelog entry
* Get rid of import renaming
* Merge remaining conflicts
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com >
2021-02-18 12:59:37 -05:00
