mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-24 20:14:40 +02:00
5b2ce02911
`BenchmarkValueEqual` does not run the target code with `b.N`, as https://pkg.go.dev/testing#hdr-Benchmarks states. Thus, it cannot produce a stable benchmark result. And, it would fail the benchmark: https://github.com/open-telemetry/opentelemetry-go/actions/runs/10412186663. This PR fixes this issue. Here is the result of `benchstat` ``` goos: darwin goarch: arm64 pkg: go.opentelemetry.io/otel/log │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ ValueEqual/2_with_1-10 0.0000002000n ± 100% 3.1450000000n ± 1% +1572499900.00% (p=0.000 n=10) │ old.txt │ new.txt │ │ B/op │ B/op vs base │ ValueEqual/2_with_1-10 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ¹ all samples are equal │ old.txt │ new.txt │ │ allocs/op │ allocs/op vs base │ ValueEqual/2_with_1-10 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ¹ all samples are equal ```
235 lines
4.5 KiB
Go
235 lines
4.5 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package log_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"go.opentelemetry.io/otel/log"
|
|
)
|
|
|
|
// Store results in a file scope var to ensure compiler does not optimize the
|
|
// test away.
|
|
var (
|
|
outV log.Value
|
|
outKV log.KeyValue
|
|
|
|
outBool bool
|
|
outFloat64 float64
|
|
outInt64 int64
|
|
outMap []log.KeyValue
|
|
outSlice []log.Value
|
|
outStr string
|
|
)
|
|
|
|
func BenchmarkBool(b *testing.B) {
|
|
const k, v = "bool", true
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.BoolValue(v)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.Bool(k, v)
|
|
}
|
|
})
|
|
|
|
kv := log.Bool(k, v)
|
|
b.Run("AsBool", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outBool = kv.Value.AsBool()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkFloat64(b *testing.B) {
|
|
const k, v = "float64", 3.0
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.Float64Value(v)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.Float64(k, v)
|
|
}
|
|
})
|
|
|
|
kv := log.Float64(k, v)
|
|
b.Run("AsFloat64", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outFloat64 = kv.Value.AsFloat64()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkInt(b *testing.B) {
|
|
const k, v = "int", 32
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.IntValue(v)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.Int(k, v)
|
|
}
|
|
})
|
|
|
|
kv := log.Int(k, v)
|
|
b.Run("AsInt64", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outInt64 = kv.Value.AsInt64()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkInt64(b *testing.B) {
|
|
const k, v = "int64", int64(32)
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.Int64Value(v)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.Int64(k, v)
|
|
}
|
|
})
|
|
|
|
kv := log.Int64(k, v)
|
|
b.Run("AsInt64", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outInt64 = kv.Value.AsInt64()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkMap(b *testing.B) {
|
|
const k = "map"
|
|
v := []log.KeyValue{log.Bool("b", true), log.Int("i", 1)}
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.MapValue(v...)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.Map(k, v...)
|
|
}
|
|
})
|
|
|
|
kv := log.Map(k, v...)
|
|
b.Run("AsMap", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outMap = kv.Value.AsMap()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkSlice(b *testing.B) {
|
|
const k = "slice"
|
|
v := []log.Value{log.BoolValue(true), log.IntValue(1)}
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.SliceValue(v...)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.Slice(k, v...)
|
|
}
|
|
})
|
|
|
|
kv := log.Slice(k, v...)
|
|
b.Run("AsSlice", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outSlice = kv.Value.AsSlice()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkString(b *testing.B) {
|
|
const k, v = "str", "value"
|
|
|
|
b.Run("Value", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outV = log.StringValue(v)
|
|
}
|
|
})
|
|
b.Run("KeyValue", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outKV = log.String(k, v)
|
|
}
|
|
})
|
|
|
|
kv := log.String(k, v)
|
|
b.Run("AsString", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
outStr = kv.Value.AsString()
|
|
}
|
|
})
|
|
}
|
|
|
|
func BenchmarkValueEqual(b *testing.B) {
|
|
vals := []log.Value{
|
|
{},
|
|
log.Int64Value(1),
|
|
log.Int64Value(2),
|
|
log.Float64Value(3.5),
|
|
log.Float64Value(3.7),
|
|
log.BoolValue(true),
|
|
log.BoolValue(false),
|
|
log.StringValue("hi"),
|
|
log.StringValue("bye"),
|
|
log.BytesValue([]byte{1, 3, 5}),
|
|
log.SliceValue(log.StringValue("foo")),
|
|
log.SliceValue(log.IntValue(3), log.StringValue("foo")),
|
|
log.MapValue(log.Bool("b", true), log.Int("i", 3)),
|
|
log.MapValue(
|
|
log.Slice("l", log.IntValue(3), log.StringValue("foo")),
|
|
log.Bytes("b", []byte{3, 5, 7}),
|
|
log.Empty("e"),
|
|
),
|
|
}
|
|
for _, v1 := range vals {
|
|
for _, v2 := range vals {
|
|
b.Run(v1.String()+" with "+v2.String(), func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
_ = v1.Equal(v2)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|