You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-11-27 22:49:15 +02:00
Fixes #7004 This PR adds support for experimental otel.sdk.processor.span.processed metric in simple span processor. Definition of metric at: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/otel/sdk-metrics.md Experimental metrics are behind a feature flag: `OTEL_GO_X_OBSERVABILITY` <details> <summary>Observability Implementation Checklist</summary> ## Observability Implementation Checklist Based on the [project Observability guidelines](e4ab314112/CONTRIBUTING.md (observability)), ensure the following are completed: ### Environment Variable Activation * [x] Observability features are disabled by default * [x] Features are activated through the `OTEL_GO_X_OBSERVABILITY` environment variable * [x] Use consistent pattern with `x.Observability.Enabled()` check [^1] * [x] Follow established experimental feature pattern [^2][^3] [^1]:e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L101-L103)[^2]:e4ab314112/exporters/stdout/stdouttrace/internal/x/x.go[^3]:e4ab314112/sdk/internal/x/x.go### Encapsulation * [x] Instrumentation is encapsulated within a dedicated `struct` (e.g., [`Instrumentation`](e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L86-L94))) * [x] Instrumentation is not mixed into the instrumented component * [x] Instrumentation code is in its own file or package if complex/reused * [x] Instrumentation setup doesn't bloat the main component code ### Initialization * [x] Initialization is only done when observability is enabled * [x] Setup is explicit and side-effect free * [x] Return errors from initialization when appropriate * [x] Use the global Meter provider (e.g., `otel.GetMeterProvider()`) * [x] Include proper meter configuration with: * [x] Instrumentation package name is used for the Meter * [x] Instrumentation version (e.g. [`Version`](e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L40-L43))) * [x] Schema URL (e.g. [`SchemaURL`](e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L36-L38))) ### Performance * [x] Little to no overhead when observability is disabled * [x] Expensive operations are only executed when observability is enabled * [x] When enabled, instrumentation code paths are optimized to reduce allocation/computation overhead #### Attribute and Option Allocation Management * [x] Use `sync.Pool` for attribute slices and options with dynamic attributes * [x] Pool objects are properly reset before returning to pool * [x] Pools are scoped for maximum efficiency while ensuring correctness #### Caching * [x] Static attribute sets known at compile time are pre-computed and cached * [x] Common attribute combinations use lookup tables/maps #### Benchmarking * [x] Benchmarks provided for all instrumentation code * [ ] Benchmark scenarios include both enabled and disabled observability * [x] Benchmark results show impact on allocs/op, B/op, and ns/op (use `b.ReportAllocs()` in benchmarks) ### Error Handling and Robustness * [x] Errors are reported back to caller when possible * [x] Partial failures are handled gracefully * [x] Use partially initialized components when available * [x] Return errors to caller instead of only using `otel.Handle()` * [x] Use `otel.Handle()` only when component cannot report error to user ### Context Propagation * [x] Observability measurements receive the context from the function being measured (don't break context propagation by using `context.Background()`) ### Semantic Conventions Compliance * [x] All metrics follow [OpenTelemetry Semantic Conventions](5ee549b1ce/docs/otel/sdk-metrics.md) * [x] Use the [`otelconv`](https://pkg.go.dev/go.opentelemetry.io/otel@v1.38.0/semconv/v1.37.0/otelconv) convenience package for metric semantic conventions * [x] Component names follow semantic conventions * [x] Use package path scope type as stable identifier for non-standard components * [x] Component names are stable unique identifiers * [x] Use global counter for uniqueness if necessary * [x] Component ID counter is resettable for deterministic testing ### Testing * [x] Use deterministic testing with isolated state * [x] Restore previous state after tests (`t.Cleanup()`) * [x] Isolate meter provider for testing * [x] Use `t.Setenv()` for environment variable testing * [x] Reset component ID counter for deterministic component names * [x] Test order doesn't affect results </details> ### Benchmarks ```console > benchstat bmark.result goos: darwin goarch: arm64 pkg: go.opentelemetry.io/otel/sdk/trace/internal/observ cpu: Apple M1 Pro │ bmark.result │ │ sec/op │ SSP/SpanProcessed-8 146.7n ± 15% SSP/SpanProcessedWithError-8 205.1n ± 3% geomean 173.5n │ bmark.result │ │ B/op │ SSP/SpanProcessed-8 280.0 ± 0% SSP/SpanProcessedWithError-8 408.0 ± 0% geomean 338.0 │ bmark.result │ │ allocs/op │ SSP/SpanProcessed-8 3.000 ± 0% SSP/SpanProcessedWithError-8 3.000 ± 0% geomean 3.000 ``` --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
98 lines
3.0 KiB
Go
98 lines
3.0 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package observ // import "go.opentelemetry.io/otel/sdk/trace/internal/observ"
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/metric"
|
|
"go.opentelemetry.io/otel/sdk"
|
|
"go.opentelemetry.io/otel/sdk/internal/x"
|
|
semconv "go.opentelemetry.io/otel/semconv/v1.37.0"
|
|
"go.opentelemetry.io/otel/semconv/v1.37.0/otelconv"
|
|
)
|
|
|
|
var measureAttrsPool = sync.Pool{
|
|
New: func() any {
|
|
// "component.name" + "component.type" + "error.type"
|
|
const n = 1 + 1 + 1
|
|
s := make([]attribute.KeyValue, 0, n)
|
|
// Return a pointer to a slice instead of a slice itself
|
|
// to avoid allocations on every call.
|
|
return &s
|
|
},
|
|
}
|
|
|
|
// SSP is the instrumentation for an OTel SDK SimpleSpanProcessor.
|
|
type SSP struct {
|
|
spansProcessedCounter metric.Int64Counter
|
|
addOpts []metric.AddOption
|
|
attrs []attribute.KeyValue
|
|
}
|
|
|
|
// SSPComponentName returns the component name attribute for a
|
|
// SimpleSpanProcessor with the given ID.
|
|
func SSPComponentName(id int64) attribute.KeyValue {
|
|
t := otelconv.ComponentTypeSimpleSpanProcessor
|
|
name := fmt.Sprintf("%s/%d", t, id)
|
|
return semconv.OTelComponentName(name)
|
|
}
|
|
|
|
// NewSSP returns instrumentation for an OTel SDK SimpleSpanProcessor with the
|
|
// provided ID.
|
|
//
|
|
// If the experimental observability is disabled, nil is returned.
|
|
func NewSSP(id int64) (*SSP, error) {
|
|
if !x.Observability.Enabled() {
|
|
return nil, nil
|
|
}
|
|
|
|
meter := otel.GetMeterProvider().Meter(
|
|
ScopeName,
|
|
metric.WithInstrumentationVersion(sdk.Version()),
|
|
metric.WithSchemaURL(SchemaURL),
|
|
)
|
|
spansProcessedCounter, err := otelconv.NewSDKProcessorSpanProcessed(meter)
|
|
if err != nil {
|
|
err = fmt.Errorf("failed to create SSP processed spans metric: %w", err)
|
|
}
|
|
|
|
componentName := SSPComponentName(id)
|
|
componentType := spansProcessedCounter.AttrComponentType(otelconv.ComponentTypeSimpleSpanProcessor)
|
|
attrs := []attribute.KeyValue{componentName, componentType}
|
|
addOpts := []metric.AddOption{metric.WithAttributeSet(attribute.NewSet(attrs...))}
|
|
|
|
return &SSP{
|
|
spansProcessedCounter: spansProcessedCounter.Inst(),
|
|
addOpts: addOpts,
|
|
attrs: attrs,
|
|
}, err
|
|
}
|
|
|
|
// SpanProcessed records that a span has been processed by the SimpleSpanProcessor.
|
|
// If err is non-nil, it records the processing error as an attribute.
|
|
func (ssp *SSP) SpanProcessed(ctx context.Context, err error) {
|
|
ssp.spansProcessedCounter.Add(ctx, 1, ssp.addOption(err)...)
|
|
}
|
|
|
|
func (ssp *SSP) addOption(err error) []metric.AddOption {
|
|
if err == nil {
|
|
return ssp.addOpts
|
|
}
|
|
attrs := measureAttrsPool.Get().(*[]attribute.KeyValue)
|
|
defer func() {
|
|
*attrs = (*attrs)[:0] // reset the slice for reuse
|
|
measureAttrsPool.Put(attrs)
|
|
}()
|
|
*attrs = append(*attrs, ssp.attrs...)
|
|
*attrs = append(*attrs, semconv.ErrorType(err))
|
|
// Do not inefficiently make a copy of attrs by using
|
|
// WithAttributes instead of WithAttributeSet.
|
|
return []metric.AddOption{metric.WithAttributeSet(attribute.NewSet(*attrs...))}
|
|
}
|