mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-12 10:04:29 +02:00
942713a02d
This PR removes the non-compliant ChildOf and FollowsFrom interfaces and the Relation type, which were inherited from OpenTracing via the initial prototype. Instead allow adding a span context to the go context as a remote span context and use a simple algorithm for figuring out an actual parent of the new span, which was proposed for the OpenTelemetry specification. Also add a way to ignore current span and remote span context in go context, so we can force the tracer to create a new root span - a span with a new trace ID. That required some moderate changes in the opentracing bridge - first reference with ChildOfRef reference type becomes a local parent, the rest become links. This also fixes links handling in the meantime. The downside of the approach proposed here is that we can only set the remote parent when creating a span through the opentracing API. Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
221 lines
5.9 KiB
Go
221 lines
5.9 KiB
Go
// Copyright 2019, OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package trace_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/binary"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.opentelemetry.io/otel/api/core"
|
|
apitrace "go.opentelemetry.io/otel/api/trace"
|
|
export "go.opentelemetry.io/otel/sdk/export/trace"
|
|
sdktrace "go.opentelemetry.io/otel/sdk/trace"
|
|
)
|
|
|
|
type testBatchExporter struct {
|
|
mu sync.Mutex
|
|
spans []*export.SpanData
|
|
sizes []int
|
|
batchCount int
|
|
}
|
|
|
|
func (t *testBatchExporter) ExportSpans(ctx context.Context, sds []*export.SpanData) {
|
|
t.mu.Lock()
|
|
defer t.mu.Unlock()
|
|
|
|
t.spans = append(t.spans, sds...)
|
|
t.sizes = append(t.sizes, len(sds))
|
|
t.batchCount++
|
|
}
|
|
|
|
func (t *testBatchExporter) len() int {
|
|
t.mu.Lock()
|
|
defer t.mu.Unlock()
|
|
return len(t.spans)
|
|
}
|
|
|
|
func (t *testBatchExporter) getBatchCount() int {
|
|
t.mu.Lock()
|
|
defer t.mu.Unlock()
|
|
return t.batchCount
|
|
}
|
|
|
|
func (t *testBatchExporter) get(idx int) *export.SpanData {
|
|
t.mu.Lock()
|
|
defer t.mu.Unlock()
|
|
return t.spans[idx]
|
|
}
|
|
|
|
var _ export.SpanBatcher = (*testBatchExporter)(nil)
|
|
|
|
func TestNewBatchSpanProcessorWithNilExporter(t *testing.T) {
|
|
_, err := sdktrace.NewBatchSpanProcessor(nil)
|
|
if err == nil {
|
|
t.Errorf("Expected error while creating processor with nil exporter")
|
|
}
|
|
}
|
|
|
|
type testOption struct {
|
|
name string
|
|
o []sdktrace.BatchSpanProcessorOption
|
|
wantNumSpans int
|
|
wantBatchCount int
|
|
genNumSpans int
|
|
waitTime time.Duration
|
|
}
|
|
|
|
func TestNewBatchSpanProcessorWithOptions(t *testing.T) {
|
|
schDelay := 200 * time.Millisecond
|
|
waitTime := schDelay + 100*time.Millisecond
|
|
options := []testOption{
|
|
{
|
|
name: "default BatchSpanProcessorOptions",
|
|
wantNumSpans: 2048,
|
|
wantBatchCount: 4,
|
|
genNumSpans: 2053,
|
|
waitTime: 5100 * time.Millisecond,
|
|
},
|
|
{
|
|
name: "non-default ScheduledDelayMillis",
|
|
o: []sdktrace.BatchSpanProcessorOption{
|
|
sdktrace.WithScheduleDelayMillis(schDelay),
|
|
},
|
|
wantNumSpans: 2048,
|
|
wantBatchCount: 4,
|
|
genNumSpans: 2053,
|
|
waitTime: waitTime,
|
|
},
|
|
{
|
|
name: "non-default MaxQueueSize and ScheduledDelayMillis",
|
|
o: []sdktrace.BatchSpanProcessorOption{
|
|
sdktrace.WithScheduleDelayMillis(schDelay),
|
|
sdktrace.WithMaxQueueSize(200),
|
|
},
|
|
wantNumSpans: 200,
|
|
wantBatchCount: 1,
|
|
genNumSpans: 205,
|
|
waitTime: waitTime,
|
|
},
|
|
{
|
|
name: "non-default MaxQueueSize, ScheduledDelayMillis and MaxExportBatchSize",
|
|
o: []sdktrace.BatchSpanProcessorOption{
|
|
sdktrace.WithScheduleDelayMillis(schDelay),
|
|
sdktrace.WithMaxQueueSize(205),
|
|
sdktrace.WithMaxExportBatchSize(20),
|
|
},
|
|
wantNumSpans: 205,
|
|
wantBatchCount: 11,
|
|
genNumSpans: 210,
|
|
waitTime: waitTime,
|
|
},
|
|
{
|
|
name: "blocking option",
|
|
o: []sdktrace.BatchSpanProcessorOption{
|
|
sdktrace.WithScheduleDelayMillis(schDelay),
|
|
sdktrace.WithMaxQueueSize(200),
|
|
sdktrace.WithMaxExportBatchSize(20),
|
|
sdktrace.WithBlocking(),
|
|
},
|
|
wantNumSpans: 205,
|
|
wantBatchCount: 11,
|
|
genNumSpans: 205,
|
|
waitTime: waitTime,
|
|
},
|
|
}
|
|
for _, option := range options {
|
|
te := testBatchExporter{}
|
|
tp := basicProvider(t)
|
|
ssp := createAndRegisterBatchSP(t, option, &te)
|
|
if ssp == nil {
|
|
t.Errorf("%s: Error creating new instance of BatchSpanProcessor\n", option.name)
|
|
}
|
|
tp.RegisterSpanProcessor(ssp)
|
|
tr := tp.Tracer("BatchSpanProcessorWithOptions")
|
|
|
|
generateSpan(t, tr, option)
|
|
|
|
time.Sleep(option.waitTime)
|
|
|
|
gotNumOfSpans := te.len()
|
|
if option.wantNumSpans != gotNumOfSpans {
|
|
t.Errorf("%s: number of exported span: got %+v, want %+v\n", option.name, gotNumOfSpans, option.wantNumSpans)
|
|
}
|
|
|
|
gotBatchCount := te.getBatchCount()
|
|
if gotBatchCount < option.wantBatchCount {
|
|
t.Errorf("%s: number batches: got %+v, want >= %+v\n", option.name, gotBatchCount, option.wantBatchCount)
|
|
t.Errorf("Batches %v\n", te.sizes)
|
|
}
|
|
|
|
// Check first Span is reported. Most recent one is dropped.
|
|
sc := getSpanContext()
|
|
wantTraceID := sc.TraceID
|
|
binary.BigEndian.PutUint64(wantTraceID[0:8], uint64(1))
|
|
gotTraceID := te.get(0).SpanContext.TraceID
|
|
if wantTraceID != gotTraceID {
|
|
t.Errorf("%s: first exported span: got %+v, want %+v\n", option.name, gotTraceID, wantTraceID)
|
|
}
|
|
tp.UnregisterSpanProcessor(ssp)
|
|
}
|
|
}
|
|
|
|
func createAndRegisterBatchSP(t *testing.T, option testOption, te *testBatchExporter) *sdktrace.BatchSpanProcessor {
|
|
ssp, err := sdktrace.NewBatchSpanProcessor(te, option.o...)
|
|
if ssp == nil {
|
|
t.Errorf("%s: Error creating new instance of BatchSpanProcessor, error: %v\n", option.name, err)
|
|
}
|
|
return ssp
|
|
}
|
|
|
|
func generateSpan(t *testing.T, tr apitrace.Tracer, option testOption) {
|
|
sc := getSpanContext()
|
|
|
|
for i := 0; i < option.genNumSpans; i++ {
|
|
binary.BigEndian.PutUint64(sc.TraceID[0:8], uint64(i+1))
|
|
ctx := apitrace.ContextWithRemoteSpanContext(context.Background(), sc)
|
|
_, span := tr.Start(ctx, option.name)
|
|
span.End()
|
|
}
|
|
}
|
|
|
|
func getSpanContext() core.SpanContext {
|
|
tid, _ := core.TraceIDFromHex("01020304050607080102040810203040")
|
|
sid, _ := core.SpanIDFromHex("0102040810203040")
|
|
return core.SpanContext{
|
|
TraceID: tid,
|
|
SpanID: sid,
|
|
TraceFlags: 0x1,
|
|
}
|
|
}
|
|
|
|
func TestBatchSpanProcessorShutdown(t *testing.T) {
|
|
bsp, err := sdktrace.NewBatchSpanProcessor(&testBatchExporter{})
|
|
if err != nil {
|
|
t.Errorf("Unexpected error while creating processor\n")
|
|
}
|
|
|
|
if bsp == nil {
|
|
t.Fatalf("Error creating new instance of BatchSpanProcessor\n")
|
|
}
|
|
|
|
bsp.Shutdown()
|
|
|
|
// Multiple call to Shutdown() should not panic.
|
|
bsp.Shutdown()
|
|
}
|