You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-11-27 22:49:15 +02:00
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/golangci/golangci-lint](https://redirect.github.com/golangci/golangci-lint) | `v1.64.8` -> `v2.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>golangci/golangci-lint (github.com/golangci/golangci-lint)</summary> ### [`v2.0.2`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v202) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v2.0.1...v2.0.2) 1. Misc. - Fixes flags parsing for formatters - Fixes the filepath used by the exclusion `source` option 2. Documentation - Adds a section about flags migration - Cleaning pages with v1 options ### [`v2.0.1`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v201) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v2.0.0...v2.0.1) 1. Linters/formatters bug fixes - `golines`: fix settings during linter load 2. Misc. - Validates the `version` field before the configuration - `forbidigo`: fix migration ### [`v2.0.0`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v200) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.64.8...v2.0.0) 1. Enhancements - 🌟 New `golangci-lint fmt` command with dedicated formatter configuration (https://golangci-lint.run/welcome/quick-start/#formatting) - ♻️ New `golangci-lint migrate` command to help migration from v1 to v2 (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#command-migrate)) - ⚠️ New default values (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - ⚠️ No exclusions by default (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#issuesexclude-use-default)) - ⚠️ New default sort order (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#outputsort-order)) - 🌟 New option `run.relative-path-mode` (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#runrelative-path-mode)) - 🌟 New linters configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#linters)) - 🌟 New output format configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#output)) - 🌟 New `--fast-only` flag (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersfast)) - 🌟 New option `linters.exclusions.warn-unused` to log a warning if an exclusion rule is unused. 2. New linters/formatters - Add `golines` formatter https://github.com/segmentio/golines 3. Linters new features - ⚠️ Merge `staticcheck`, `stylecheck`, `gosimple` into one linter (`staticcheck`) (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersenablestylecheckgosimplestaticcheck)) - `go-critic`: from 0.12.0 to 0.13.0 - `gomodguard`: from 1.3.5 to 1.4.1 (block explicit indirect dependencies) - `nilnil`: from 1.0.1 to 1.1.0 (new option: `only-two`) - `perfsprint`: from 0.8.2 to 0.9.1 (checker name in the diagnostic message) - `staticcheck`: new `quickfix` set of rules - `testifylint`: from 1.5.2 to 1.6.0 (new options: `equal-values`, `suite-method-signature`, `require-string-msg`) - `wsl`: from 4.5.0 to 4.6.0 (new option: `allow-cuddle-used-in-block`) 4. Linters bug fixes - `bidichk`: from 0.3.2 to 0.3.3 - `errchkjson`: from 0.4.0 to 0.4.1 - `errname`: from 1.0.0 to 1.1.0 - `funlen`: fix `ignore-comments` option - `gci`: from 0.13.5 to 0.13.6 - `gosmopolitan`: from 1.2.2 to 1.3.0 - `inamedparam`: from 0.1.3 to 0.2.0 - `intrange`: from 0.3.0 to 0.3.1 - `protogetter`: from 0.3.9 to 0.3.12 - `unparam`: from [`8a5130c`](https://redirect.github.com/golangci/golangci-lint/commit/8a5130ca722f) to [`0df0534`](https://redirect.github.com/golangci/golangci-lint/commit/0df0534333a4) 5. Misc. - 🧹 Configuration options renaming (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - 🧹 Remove options (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - 🧹 Remove flags (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - 🧹 Remove alternative names (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#alternative-linter-names)) - 🧹 Remove or replace deprecated elements (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - Adds an option to display some commands as JSON: - `golangci-lint config path --json` - `golangci-lint help linters --json` - `golangci-lint help formatters --json` - `golangci-lint linters --json` - `golangci-lint formatters --json` - `golangci-lint version --json` 6. Documentation - [Migration guide](https://golangci-lint.run/product/migration-guide/) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <codingalias@gmail.com>
336 lines
8.5 KiB
Go
336 lines
8.5 KiB
Go
// Code created by gotmpl. DO NOT MODIFY.
|
|
// source: internal/shared/internaltest/harness.go.tmpl
|
|
|
|
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Package internaltest provides testing functionality.
|
|
package internaltest // import "go.opentelemetry.io/otel/internal/internaltest"
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/codes"
|
|
"go.opentelemetry.io/otel/internal/matchers"
|
|
"go.opentelemetry.io/otel/trace"
|
|
)
|
|
|
|
// Harness is a testing harness used to test implementations of the
|
|
// OpenTelemetry API.
|
|
type Harness struct {
|
|
t *testing.T
|
|
}
|
|
|
|
// NewHarness returns an instantiated *Harness using t.
|
|
func NewHarness(t *testing.T) *Harness {
|
|
return &Harness{
|
|
t: t,
|
|
}
|
|
}
|
|
|
|
// TestTracerProvider runs validation tests for an implementation of the OpenTelemetry
|
|
// TracerProvider API.
|
|
func (h *Harness) TestTracerProvider(subjectFactory func() trace.TracerProvider) {
|
|
h.t.Run("#Start", func(t *testing.T) {
|
|
t.Run("allow creating an arbitrary number of TracerProvider instances", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
|
|
tp1 := subjectFactory()
|
|
tp2 := subjectFactory()
|
|
|
|
e.Expect(tp1).NotToEqual(tp2)
|
|
})
|
|
t.Run("all methods are safe to be called concurrently", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
runner := func(tp trace.TracerProvider) <-chan struct{} {
|
|
done := make(chan struct{})
|
|
go func(tp trace.TracerProvider) {
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 20; i++ {
|
|
wg.Add(1)
|
|
go func(name, version string) {
|
|
_ = tp.Tracer(name, trace.WithInstrumentationVersion(version))
|
|
wg.Done()
|
|
}(fmt.Sprintf("tracer %d", i%5), strconv.Itoa(i))
|
|
}
|
|
wg.Wait()
|
|
done <- struct{}{}
|
|
}(tp)
|
|
return done
|
|
}
|
|
|
|
matchers.NewExpecter(t).Expect(func() {
|
|
// Run with multiple TracerProvider to ensure they encapsulate
|
|
// their own Tracers.
|
|
tp1 := subjectFactory()
|
|
tp2 := subjectFactory()
|
|
|
|
done1 := runner(tp1)
|
|
done2 := runner(tp2)
|
|
|
|
<-done1
|
|
<-done2
|
|
}).NotToPanic()
|
|
})
|
|
})
|
|
}
|
|
|
|
// TestTracer runs validation tests for an implementation of the OpenTelemetry
|
|
// Tracer API.
|
|
func (h *Harness) TestTracer(subjectFactory func() trace.Tracer) {
|
|
h.t.Run("#Start", func(t *testing.T) {
|
|
t.Run("propagates the original context", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
ctxKey := testCtxKey{}
|
|
ctxValue := "ctx value"
|
|
ctx := context.WithValue(context.Background(), ctxKey, ctxValue)
|
|
|
|
ctx, _ = subject.Start(ctx, "test")
|
|
|
|
e.Expect(ctx.Value(ctxKey)).ToEqual(ctxValue)
|
|
})
|
|
|
|
t.Run("returns a span containing the expected properties", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
_, span := subject.Start(context.Background(), "test")
|
|
|
|
e.Expect(span).NotToBeNil()
|
|
|
|
e.Expect(span.SpanContext().IsValid()).ToBeTrue()
|
|
})
|
|
|
|
t.Run("stores the span on the provided context", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
ctx, span := subject.Start(context.Background(), "test")
|
|
|
|
e.Expect(span).NotToBeNil()
|
|
e.Expect(span.SpanContext()).NotToEqual(trace.SpanContext{})
|
|
e.Expect(trace.SpanFromContext(ctx)).ToEqual(span)
|
|
})
|
|
|
|
t.Run("starts spans with unique trace and span IDs", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
_, span1 := subject.Start(context.Background(), "span1")
|
|
_, span2 := subject.Start(context.Background(), "span2")
|
|
|
|
sc1 := span1.SpanContext()
|
|
sc2 := span2.SpanContext()
|
|
|
|
e.Expect(sc1.TraceID()).NotToEqual(sc2.TraceID())
|
|
e.Expect(sc1.SpanID()).NotToEqual(sc2.SpanID())
|
|
})
|
|
|
|
t.Run("propagates a parent's trace ID through the context", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
ctx, parent := subject.Start(context.Background(), "parent")
|
|
_, child := subject.Start(ctx, "child")
|
|
|
|
psc := parent.SpanContext()
|
|
csc := child.SpanContext()
|
|
|
|
e.Expect(csc.TraceID()).ToEqual(psc.TraceID())
|
|
e.Expect(csc.SpanID()).NotToEqual(psc.SpanID())
|
|
})
|
|
|
|
t.Run("ignores parent's trace ID when new root is requested", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
ctx, parent := subject.Start(context.Background(), "parent")
|
|
_, child := subject.Start(ctx, "child", trace.WithNewRoot())
|
|
|
|
psc := parent.SpanContext()
|
|
csc := child.SpanContext()
|
|
|
|
e.Expect(csc.TraceID()).NotToEqual(psc.TraceID())
|
|
e.Expect(csc.SpanID()).NotToEqual(psc.SpanID())
|
|
})
|
|
|
|
t.Run("propagates remote parent's trace ID through the context", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
_, remoteParent := subject.Start(context.Background(), "remote parent")
|
|
parentCtx := trace.ContextWithRemoteSpanContext(context.Background(), remoteParent.SpanContext())
|
|
_, child := subject.Start(parentCtx, "child")
|
|
|
|
psc := remoteParent.SpanContext()
|
|
csc := child.SpanContext()
|
|
|
|
e.Expect(csc.TraceID()).ToEqual(psc.TraceID())
|
|
e.Expect(csc.SpanID()).NotToEqual(psc.SpanID())
|
|
})
|
|
|
|
t.Run("ignores remote parent's trace ID when new root is requested", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
subject := subjectFactory()
|
|
|
|
_, remoteParent := subject.Start(context.Background(), "remote parent")
|
|
parentCtx := trace.ContextWithRemoteSpanContext(context.Background(), remoteParent.SpanContext())
|
|
_, child := subject.Start(parentCtx, "child", trace.WithNewRoot())
|
|
|
|
psc := remoteParent.SpanContext()
|
|
csc := child.SpanContext()
|
|
|
|
e.Expect(csc.TraceID()).NotToEqual(psc.TraceID())
|
|
e.Expect(csc.SpanID()).NotToEqual(psc.SpanID())
|
|
})
|
|
|
|
t.Run("all methods are safe to be called concurrently", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
e := matchers.NewExpecter(t)
|
|
tracer := subjectFactory()
|
|
|
|
ctx, parent := tracer.Start(context.Background(), "span")
|
|
|
|
runner := func(tp trace.Tracer) <-chan struct{} {
|
|
done := make(chan struct{})
|
|
go func(tp trace.Tracer) {
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 20; i++ {
|
|
wg.Add(1)
|
|
go func(name string) {
|
|
defer wg.Done()
|
|
_, child := tp.Start(ctx, name)
|
|
|
|
psc := parent.SpanContext()
|
|
csc := child.SpanContext()
|
|
|
|
e.Expect(csc.TraceID()).ToEqual(psc.TraceID())
|
|
e.Expect(csc.SpanID()).NotToEqual(psc.SpanID())
|
|
}(fmt.Sprintf("span %d", i))
|
|
}
|
|
wg.Wait()
|
|
done <- struct{}{}
|
|
}(tp)
|
|
return done
|
|
}
|
|
|
|
e.Expect(func() {
|
|
done := runner(tracer)
|
|
|
|
<-done
|
|
}).NotToPanic()
|
|
})
|
|
})
|
|
|
|
h.testSpan(subjectFactory)
|
|
}
|
|
|
|
func (h *Harness) testSpan(tracerFactory func() trace.Tracer) {
|
|
methods := map[string]func(span trace.Span){
|
|
"#End": func(span trace.Span) {
|
|
span.End()
|
|
},
|
|
"#AddEvent": func(span trace.Span) {
|
|
span.AddEvent("test event")
|
|
},
|
|
"#AddEventWithTimestamp": func(span trace.Span) {
|
|
span.AddEvent("test event", trace.WithTimestamp(time.Now().Add(1*time.Second)))
|
|
},
|
|
"#SetStatus": func(span trace.Span) {
|
|
span.SetStatus(codes.Error, "internal")
|
|
},
|
|
"#SetName": func(span trace.Span) {
|
|
span.SetName("new name")
|
|
},
|
|
"#SetAttributes": func(span trace.Span) {
|
|
span.SetAttributes(attribute.String("key1", "value"), attribute.Int("key2", 123))
|
|
},
|
|
}
|
|
mechanisms := map[string]func() trace.Span{
|
|
"Span created via Tracer#Start": func() trace.Span {
|
|
tracer := tracerFactory()
|
|
_, subject := tracer.Start(context.Background(), "test")
|
|
|
|
return subject
|
|
},
|
|
"Span created via span.TracerProvider()": func() trace.Span {
|
|
ctx, spanA := tracerFactory().Start(context.Background(), "span1")
|
|
|
|
_, spanB := spanA.TracerProvider().Tracer("second").Start(ctx, "span2")
|
|
return spanB
|
|
},
|
|
}
|
|
|
|
for mechanismName, mechanism := range mechanisms {
|
|
h.t.Run(mechanismName, func(t *testing.T) {
|
|
for methodName, method := range methods {
|
|
t.Run(methodName, func(t *testing.T) {
|
|
t.Run("is thread-safe", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
span := mechanism()
|
|
|
|
wg := &sync.WaitGroup{}
|
|
wg.Add(2)
|
|
|
|
go func() {
|
|
defer wg.Done()
|
|
|
|
method(span)
|
|
}()
|
|
|
|
go func() {
|
|
defer wg.Done()
|
|
|
|
method(span)
|
|
}()
|
|
|
|
wg.Wait()
|
|
})
|
|
})
|
|
}
|
|
|
|
t.Run("#End", func(t *testing.T) {
|
|
t.Run("can be called multiple times", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
span := mechanism()
|
|
|
|
span.End()
|
|
span.End()
|
|
})
|
|
})
|
|
})
|
|
}
|
|
}
|
|
|
|
type testCtxKey struct{}
|