You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-11-23 22:34:47 +02:00
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/golangci/golangci-lint](https://redirect.github.com/golangci/golangci-lint) | `v1.64.8` -> `v2.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>golangci/golangci-lint (github.com/golangci/golangci-lint)</summary> ### [`v2.0.2`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v202) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v2.0.1...v2.0.2) 1. Misc. - Fixes flags parsing for formatters - Fixes the filepath used by the exclusion `source` option 2. Documentation - Adds a section about flags migration - Cleaning pages with v1 options ### [`v2.0.1`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v201) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v2.0.0...v2.0.1) 1. Linters/formatters bug fixes - `golines`: fix settings during linter load 2. Misc. - Validates the `version` field before the configuration - `forbidigo`: fix migration ### [`v2.0.0`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v200) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.64.8...v2.0.0) 1. Enhancements - 🌟 New `golangci-lint fmt` command with dedicated formatter configuration (https://golangci-lint.run/welcome/quick-start/#formatting) - ♻️ New `golangci-lint migrate` command to help migration from v1 to v2 (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#command-migrate)) - ⚠️ New default values (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - ⚠️ No exclusions by default (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#issuesexclude-use-default)) - ⚠️ New default sort order (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#outputsort-order)) - 🌟 New option `run.relative-path-mode` (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#runrelative-path-mode)) - 🌟 New linters configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#linters)) - 🌟 New output format configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#output)) - 🌟 New `--fast-only` flag (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersfast)) - 🌟 New option `linters.exclusions.warn-unused` to log a warning if an exclusion rule is unused. 2. New linters/formatters - Add `golines` formatter https://github.com/segmentio/golines 3. Linters new features - ⚠️ Merge `staticcheck`, `stylecheck`, `gosimple` into one linter (`staticcheck`) (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersenablestylecheckgosimplestaticcheck)) - `go-critic`: from 0.12.0 to 0.13.0 - `gomodguard`: from 1.3.5 to 1.4.1 (block explicit indirect dependencies) - `nilnil`: from 1.0.1 to 1.1.0 (new option: `only-two`) - `perfsprint`: from 0.8.2 to 0.9.1 (checker name in the diagnostic message) - `staticcheck`: new `quickfix` set of rules - `testifylint`: from 1.5.2 to 1.6.0 (new options: `equal-values`, `suite-method-signature`, `require-string-msg`) - `wsl`: from 4.5.0 to 4.6.0 (new option: `allow-cuddle-used-in-block`) 4. Linters bug fixes - `bidichk`: from 0.3.2 to 0.3.3 - `errchkjson`: from 0.4.0 to 0.4.1 - `errname`: from 1.0.0 to 1.1.0 - `funlen`: fix `ignore-comments` option - `gci`: from 0.13.5 to 0.13.6 - `gosmopolitan`: from 1.2.2 to 1.3.0 - `inamedparam`: from 0.1.3 to 0.2.0 - `intrange`: from 0.3.0 to 0.3.1 - `protogetter`: from 0.3.9 to 0.3.12 - `unparam`: from [`8a5130c`](https://redirect.github.com/golangci/golangci-lint/commit/8a5130ca722f) to [`0df0534`](https://redirect.github.com/golangci/golangci-lint/commit/0df0534333a4) 5. Misc. - 🧹 Configuration options renaming (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - 🧹 Remove options (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - 🧹 Remove flags (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - 🧹 Remove alternative names (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#alternative-linter-names)) - 🧹 Remove or replace deprecated elements (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/)) - Adds an option to display some commands as JSON: - `golangci-lint config path --json` - `golangci-lint help linters --json` - `golangci-lint help formatters --json` - `golangci-lint linters --json` - `golangci-lint formatters --json` - `golangci-lint version --json` 6. Documentation - [Migration guide](https://golangci-lint.run/product/migration-guide/) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <codingalias@gmail.com>
239 lines
5.6 KiB
Go
239 lines
5.6 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package global
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"go.opentelemetry.io/otel/metric"
|
|
metricnoop "go.opentelemetry.io/otel/metric/noop"
|
|
"go.opentelemetry.io/otel/propagation"
|
|
"go.opentelemetry.io/otel/trace"
|
|
tracenoop "go.opentelemetry.io/otel/trace/noop"
|
|
)
|
|
|
|
type nonComparableErrorHandler struct {
|
|
ErrorHandler
|
|
|
|
nonComparable func() //nolint:unused // This is not called.
|
|
}
|
|
|
|
type nonComparableTracerProvider struct {
|
|
trace.TracerProvider
|
|
|
|
nonComparable func() //nolint:unused // This is not called.
|
|
}
|
|
|
|
type nonComparableMeterProvider struct {
|
|
metric.MeterProvider
|
|
|
|
nonComparable func() //nolint:unused // This is not called.
|
|
}
|
|
|
|
type fnErrHandler func(error)
|
|
|
|
func (f fnErrHandler) Handle(err error) { f(err) }
|
|
|
|
var noopEH = fnErrHandler(func(error) {})
|
|
|
|
func TestSetErrorHandler(t *testing.T) {
|
|
t.Run("Set With default is a noop", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
SetErrorHandler(GetErrorHandler())
|
|
|
|
eh, ok := GetErrorHandler().(*ErrDelegator)
|
|
if !ok {
|
|
t.Fatal("Global ErrorHandler should be the default ErrorHandler")
|
|
}
|
|
|
|
if eh.delegate.Load() != nil {
|
|
t.Fatal("ErrorHandler should not delegate when setting itself")
|
|
}
|
|
})
|
|
|
|
t.Run("First Set() should replace the delegate", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
SetErrorHandler(noopEH)
|
|
|
|
_, ok := GetErrorHandler().(*ErrDelegator)
|
|
if ok {
|
|
t.Fatal("Global ErrorHandler was not changed")
|
|
}
|
|
})
|
|
|
|
t.Run("Set() should delegate existing ErrorHandlers", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
eh := GetErrorHandler()
|
|
SetErrorHandler(noopEH)
|
|
|
|
errDel, ok := eh.(*ErrDelegator)
|
|
if !ok {
|
|
t.Fatal("Wrong ErrorHandler returned")
|
|
}
|
|
|
|
if errDel.delegate.Load() == nil {
|
|
t.Fatal("The ErrDelegator should have a delegate")
|
|
}
|
|
})
|
|
|
|
t.Run("non-comparable types should not panic", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
eh := nonComparableErrorHandler{}
|
|
assert.NotPanics(t, func() { SetErrorHandler(eh) }, "delegate")
|
|
assert.NotPanics(t, func() { SetErrorHandler(eh) }, "replacement")
|
|
})
|
|
}
|
|
|
|
func TestSetTracerProvider(t *testing.T) {
|
|
t.Run("Set With default is a noop", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
SetTracerProvider(TracerProvider())
|
|
|
|
tp, ok := TracerProvider().(*tracerProvider)
|
|
if !ok {
|
|
t.Fatal("Global TracerProvider should be the default tracer provider")
|
|
}
|
|
|
|
if tp.delegate != nil {
|
|
t.Fatal("tracer provider should not delegate when setting itself")
|
|
}
|
|
})
|
|
|
|
t.Run("First Set() should replace the delegate", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
SetTracerProvider(tracenoop.NewTracerProvider())
|
|
|
|
_, ok := TracerProvider().(*tracerProvider)
|
|
if ok {
|
|
t.Fatal("Global TracerProvider was not changed")
|
|
}
|
|
})
|
|
|
|
t.Run("Set() should delegate existing TracerProviders", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
tp := TracerProvider()
|
|
SetTracerProvider(tracenoop.NewTracerProvider())
|
|
|
|
ntp := tp.(*tracerProvider)
|
|
|
|
if ntp.delegate == nil {
|
|
t.Fatal("The delegated tracer providers should have a delegate")
|
|
}
|
|
})
|
|
|
|
t.Run("non-comparable types should not panic", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
tp := nonComparableTracerProvider{}
|
|
SetTracerProvider(tp)
|
|
assert.NotPanics(t, func() { SetTracerProvider(tp) })
|
|
})
|
|
}
|
|
|
|
func TestSetTextMapPropagator(t *testing.T) {
|
|
t.Run("Set With default is a noop", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
SetTextMapPropagator(TextMapPropagator())
|
|
|
|
tmp, ok := TextMapPropagator().(*textMapPropagator)
|
|
if !ok {
|
|
t.Fatal("Global TextMapPropagator should be the default propagator")
|
|
}
|
|
|
|
if tmp.delegate != nil {
|
|
t.Fatal("TextMapPropagator should not delegate when setting itself")
|
|
}
|
|
})
|
|
|
|
t.Run("First Set() should replace the delegate", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
SetTextMapPropagator(propagation.TraceContext{})
|
|
|
|
_, ok := TextMapPropagator().(*textMapPropagator)
|
|
if ok {
|
|
t.Fatal("Global TextMapPropagator was not changed")
|
|
}
|
|
})
|
|
|
|
t.Run("Set() should delegate existing propagators", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
p := TextMapPropagator()
|
|
SetTextMapPropagator(propagation.TraceContext{})
|
|
|
|
np := p.(*textMapPropagator)
|
|
|
|
if np.delegate == nil {
|
|
t.Fatal("The delegated TextMapPropagators should have a delegate")
|
|
}
|
|
})
|
|
|
|
t.Run("non-comparable types should not panic", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
// A composite TextMapPropagator is not comparable.
|
|
prop := propagation.NewCompositeTextMapPropagator(propagation.TraceContext{})
|
|
SetTextMapPropagator(prop)
|
|
assert.NotPanics(t, func() { SetTextMapPropagator(prop) })
|
|
})
|
|
}
|
|
|
|
func TestSetMeterProvider(t *testing.T) {
|
|
t.Run("Set With default is a noop", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
SetMeterProvider(MeterProvider())
|
|
|
|
mp, ok := MeterProvider().(*meterProvider)
|
|
if !ok {
|
|
t.Fatal("Global MeterProvider should be the default meter provider")
|
|
}
|
|
|
|
if mp.delegate != nil {
|
|
t.Fatal("meter provider should not delegate when setting itself")
|
|
}
|
|
})
|
|
|
|
t.Run("First Set() should replace the delegate", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
SetMeterProvider(metricnoop.NewMeterProvider())
|
|
|
|
_, ok := MeterProvider().(*meterProvider)
|
|
if ok {
|
|
t.Fatal("Global MeterProvider was not changed")
|
|
}
|
|
})
|
|
|
|
t.Run("Set() should delegate existing Meter Providers", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
mp := MeterProvider()
|
|
|
|
SetMeterProvider(metricnoop.NewMeterProvider())
|
|
|
|
dmp := mp.(*meterProvider)
|
|
|
|
if dmp.delegate == nil {
|
|
t.Fatal("The delegated meter providers should have a delegate")
|
|
}
|
|
})
|
|
|
|
t.Run("non-comparable types should not panic", func(t *testing.T) {
|
|
ResetForTest(t)
|
|
|
|
mp := nonComparableMeterProvider{}
|
|
SetMeterProvider(mp)
|
|
assert.NotPanics(t, func() { SetMeterProvider(mp) })
|
|
})
|
|
}
|