mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-12 10:04:29 +02:00
91091b44eb
* Add comments on needed filed alignment Add comment about alignment requirements to all struct fields who's values are passed to 64-bit atomic operations. Update any struct's field ordering if one or more of those fields has alignment requirements to support 64-bit atomic operations. * Add 64-bit alignment tests Most `struct` that have field alignment requirements are now statically validated prior to testing. The only `struct`s not validated that have these requirements are ones defined in tests themselves where multiple `TestMain` functions would be needed to test them. Given the fields are already identified with comments specifying the alignment requirements and they are in the test themselves, this seems like an OK omission. Co-authored-by: Liz Fong-Jones <elizabeth@ctyalcove.org>
37 lines
672 B
Go
37 lines
672 B
Go
package metric
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
"unsafe"
|
|
|
|
ottest "go.opentelemetry.io/otel/internal/testing"
|
|
)
|
|
|
|
// Ensure struct alignment prior to running tests.
|
|
func TestMain(m *testing.M) {
|
|
fields := []ottest.FieldOffset{
|
|
{
|
|
Name: "record.refcount",
|
|
Offset: unsafe.Offsetof(record{}.refcount),
|
|
},
|
|
{
|
|
Name: "record.collectedEpoch",
|
|
Offset: unsafe.Offsetof(record{}.collectedEpoch),
|
|
},
|
|
{
|
|
Name: "record.modifiedEpoch",
|
|
Offset: unsafe.Offsetof(record{}.modifiedEpoch),
|
|
},
|
|
{
|
|
Name: "record.reclaim",
|
|
Offset: unsafe.Offsetof(record{}.reclaim),
|
|
},
|
|
}
|
|
if !ottest.Aligned8Byte(fields, os.Stderr) {
|
|
os.Exit(1)
|
|
}
|
|
|
|
os.Exit(m.Run())
|
|
}
|