mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-02-03 13:11:53 +02:00
f3a2d96022
Remove one allocation in all SliceValue function (going from 3 to 2).
Here is benchstat results
```
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/internal/attribute
cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
BoolSliceValue-8 128.4n ± 22% 103.8n ± 25% -19.12% (p=0.007 n=10)
Int64SliceValue-8 167.9n ± 7% 130.8n ± 5% -22.13% (p=0.000 n=10)
Float64SliceValue-8 133.8n ± 14% 122.6n ± 4% -8.33% (p=0.000 n=10)
StringSliceValue-8 166.4n ± 9% 158.5n ± 10% -4.75% (p=0.037 n=10)
geomean 148.0n 127.5n -13.88%
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
BoolSliceValue-8 32.000 ± 0% 8.000 ± 0% -75.00% (p=0.000 n=10)
Int64SliceValue-8 88.00 ± 0% 64.00 ± 0% -27.27% (p=0.000 n=10)
Float64SliceValue-8 88.00 ± 0% 64.00 ± 0% -27.27% (p=0.000 n=10)
StringSliceValue-8 152.0 ± 0% 128.0 ± 0% -15.79% (p=0.000 n=10)
geomean 78.34 45.25 -42.23%
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
BoolSliceValue-8 3.000 ± 0% 2.000 ± 0% -33.33% (p=0.000 n=10)
Int64SliceValue-8 3.000 ± 0% 2.000 ± 0% -33.33% (p=0.000 n=10)
Float64SliceValue-8 3.000 ± 0% 2.000 ± 0% -33.33% (p=0.000 n=10)
StringSliceValue-8 3.000 ± 0% 2.000 ± 0% -33.33% (p=0.000 n=10)
geomean 3.000 2.000 -33.33%
```
101 lines
3.2 KiB
Go
101 lines
3.2 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
/*
|
|
Package attribute provide several helper functions for some commonly used
|
|
logic of processing attributes.
|
|
*/
|
|
package attribute // import "go.opentelemetry.io/otel/internal/attribute"
|
|
|
|
import (
|
|
"reflect"
|
|
)
|
|
|
|
// BoolSliceValue converts a bool slice into an array with same elements as slice.
|
|
func BoolSliceValue(v []bool) interface{} {
|
|
var zero bool
|
|
cp := reflect.New(reflect.ArrayOf(len(v), reflect.TypeOf(zero))).Elem()
|
|
reflect.Copy(cp, reflect.ValueOf(v))
|
|
return cp.Interface()
|
|
}
|
|
|
|
// Int64SliceValue converts an int64 slice into an array with same elements as slice.
|
|
func Int64SliceValue(v []int64) interface{} {
|
|
var zero int64
|
|
cp := reflect.New(reflect.ArrayOf(len(v), reflect.TypeOf(zero))).Elem()
|
|
reflect.Copy(cp, reflect.ValueOf(v))
|
|
return cp.Interface()
|
|
}
|
|
|
|
// Float64SliceValue converts a float64 slice into an array with same elements as slice.
|
|
func Float64SliceValue(v []float64) interface{} {
|
|
var zero float64
|
|
cp := reflect.New(reflect.ArrayOf(len(v), reflect.TypeOf(zero))).Elem()
|
|
reflect.Copy(cp, reflect.ValueOf(v))
|
|
return cp.Interface()
|
|
}
|
|
|
|
// StringSliceValue converts a string slice into an array with same elements as slice.
|
|
func StringSliceValue(v []string) interface{} {
|
|
var zero string
|
|
cp := reflect.New(reflect.ArrayOf(len(v), reflect.TypeOf(zero))).Elem()
|
|
reflect.Copy(cp, reflect.ValueOf(v))
|
|
return cp.Interface()
|
|
}
|
|
|
|
// AsBoolSlice converts a bool array into a slice into with same elements as array.
|
|
func AsBoolSlice(v interface{}) []bool {
|
|
rv := reflect.ValueOf(v)
|
|
if rv.Type().Kind() != reflect.Array {
|
|
return nil
|
|
}
|
|
var zero bool
|
|
correctLen := rv.Len()
|
|
correctType := reflect.ArrayOf(correctLen, reflect.TypeOf(zero))
|
|
cpy := reflect.New(correctType)
|
|
_ = reflect.Copy(cpy.Elem(), rv)
|
|
return cpy.Elem().Slice(0, correctLen).Interface().([]bool)
|
|
}
|
|
|
|
// AsInt64Slice converts an int64 array into a slice into with same elements as array.
|
|
func AsInt64Slice(v interface{}) []int64 {
|
|
rv := reflect.ValueOf(v)
|
|
if rv.Type().Kind() != reflect.Array {
|
|
return nil
|
|
}
|
|
var zero int64
|
|
correctLen := rv.Len()
|
|
correctType := reflect.ArrayOf(correctLen, reflect.TypeOf(zero))
|
|
cpy := reflect.New(correctType)
|
|
_ = reflect.Copy(cpy.Elem(), rv)
|
|
return cpy.Elem().Slice(0, correctLen).Interface().([]int64)
|
|
}
|
|
|
|
// AsFloat64Slice converts a float64 array into a slice into with same elements as array.
|
|
func AsFloat64Slice(v interface{}) []float64 {
|
|
rv := reflect.ValueOf(v)
|
|
if rv.Type().Kind() != reflect.Array {
|
|
return nil
|
|
}
|
|
var zero float64
|
|
correctLen := rv.Len()
|
|
correctType := reflect.ArrayOf(correctLen, reflect.TypeOf(zero))
|
|
cpy := reflect.New(correctType)
|
|
_ = reflect.Copy(cpy.Elem(), rv)
|
|
return cpy.Elem().Slice(0, correctLen).Interface().([]float64)
|
|
}
|
|
|
|
// AsStringSlice converts a string array into a slice into with same elements as array.
|
|
func AsStringSlice(v interface{}) []string {
|
|
rv := reflect.ValueOf(v)
|
|
if rv.Type().Kind() != reflect.Array {
|
|
return nil
|
|
}
|
|
var zero string
|
|
correctLen := rv.Len()
|
|
correctType := reflect.ArrayOf(correctLen, reflect.TypeOf(zero))
|
|
cpy := reflect.New(correctType)
|
|
_ = reflect.Copy(cpy.Elem(), rv)
|
|
return cpy.Elem().Slice(0, correctLen).Interface().([]string)
|
|
}
|