1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-01-12 02:28:07 +02:00
OpenTelemetry Go API and SDK https://opentelemetry.io/
Go to file
Krzesimir Nowak 35215264dc
Split connection management away from exporter (#1369)
* Split protocol handling away from exporter

This commits adds a ProtocolDriver interface, which the exporter
will use to connect to the collector and send both metrics and traces
to it. That way, the Exporter type is free from dealing with any
connection/protocol details, as this business is taken over by the
implementations of the ProtocolDriver interface.

The gRPC code from the exporter is moved into the implementation of
ProtocolDriver. Currently it only maintains a single connection,
just as the Exporter used to do.

With the split, most of the Exporter options became actually gRPC
connection manager's options. Currently the only option that remained
to be Exporter's is about setting the export kind selector.

* Update changelog

* Increase the test coverage of GRPC driver

* Do not close a channel with multiple senders

The disconnected channel can be used for sending by multiple
goroutines (for example, by metric controller and span processor), so
this channel should not be closed at all. Dropping this line closes a
race between closing a channel and sending to it.

* Simplify new connection handler

The callbacks never return an error, so drop the return type from it.

* Access clients under a lock

The client may change as a result on reconnection in background, so
guard against a racy access.

* Simplify the GRPC driver a bit

The config type was exported earlier to have a consistent way of
configuring the driver, when also the multiple connection driver would
appear. Since we are not going to add a multiple connection driver,
pass the options directly to the driver constructor. Also shorten the
name of the constructor to `NewGRPCDriver`.

* Merge common gRPC code back into the driver

The common code was supposed to be shared between single connection
driver and multiple connection driver, but since the latter won't be
happening, it makes no sense to keep the not-so-common code in a
separate file. Also drop some abstraction too.

* Rename the file with gRPC driver implementation

* Update changelog

* Sleep for a second to trigger the timeout

Sometimes CI has it's better moments, so it's blazing fast and manages
to finish shutting the exporter down within the 1 microsecond timeout.

* Increase the timeout for shutting down the exporter

One millisecond is quite short, and I was getting failures locally or
in CI:

go test ./... + race in ./exporters/otlp
2020/12/14 18:27:54 rpc error: code = Canceled desc = context canceled
2020/12/14 18:27:54 context deadline exceeded
--- FAIL: TestNewExporter_withMultipleAttributeTypes (0.37s)
    otlp_integration_test.go:541: resource span count: got 0, want 1
FAIL
FAIL	go.opentelemetry.io/otel/exporters/otlp	5.278s

or

go test ./... + coverage in ./exporters/otlp
2020/12/14 17:41:16 rpc error: code = Canceled desc = context canceled
2020/12/14 17:41:16 exporter disconnected
--- FAIL: TestNewExporter_endToEnd (1.53s)
    --- FAIL: TestNewExporter_endToEnd/WithCompressor (0.41s)
        otlp_integration_test.go:246: span counts: got 3, want 4
2020/12/14 17:41:18 context canceled
FAIL
coverage: 35.3% of statements in ./...
FAIL	go.opentelemetry.io/otel/exporters/otlp	4.753s

* Shut down the providers in end to end test

This is to make sure that all batched spans are actually flushed
before closing the exporter.
2020-12-21 12:49:45 -08:00
.circleci Export coverage report to codecov (#995) 2020-08-24 09:43:29 -07:00
.github Fix duplicate checkout action in GitHub workflow (#1407) 2020-12-17 08:59:44 -08:00
baggage Update the package docs for the new API layout (#1346) 2020-11-17 10:30:22 -05:00
bridge Release v0.15.0 (#1392) 2020-12-10 21:00:59 -08:00
codes Update the package docs for the new API layout (#1346) 2020-11-17 10:30:22 -05:00
example Split connection management away from exporter (#1369) 2020-12-21 12:49:45 -08:00
exporters Split connection management away from exporter (#1369) 2020-12-21 12:49:45 -08:00
internal Fix typo in comment (#1402) 2020-12-15 08:06:58 -08:00
label chore: adds vanity import for files that don't have it. (#1297) 2020-11-04 09:10:58 -08:00
metric Update the package docs for the new API layout (#1346) 2020-11-17 10:30:22 -05:00
oteltest Move baggage and propagation to separate packages (#1325) 2020-11-13 07:34:24 -08:00
propagation Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
sdk Fix typo in comment (#1402) 2020-12-15 08:06:58 -08:00
semconv chore(semconv): Add PR number to changelog (#1323) 2020-11-16 10:29:28 -08:00
trace Update the package docs for the new API layout (#1346) 2020-11-17 10:30:22 -05:00
unit chore: adds vanity import for files that don't have it. (#1297) 2020-11-04 09:10:58 -08:00
.gitignore Move opencensus example to the example directory (#1359) 2020-11-20 13:34:40 -08:00
.gitmodules Move OTLP to the OTLP exporter (#1050) 2020-08-10 19:55:52 -07:00
.golangci.yml Remove nolint and update misspell to ignore cancelled 2020-05-29 11:11:19 -07:00
CHANGELOG.md Split connection management away from exporter (#1369) 2020-12-21 12:49:45 -08:00
CODEOWNERS Add @dashpole as a project Approver (#1410) 2020-12-17 16:36:49 -08:00
CONTRIBUTING.md Add @dashpole as a project Approver (#1410) 2020-12-17 16:36:49 -08:00
doc.go Mention the getting started guide (#1406) 2020-12-17 10:00:34 -08:00
error_handler.go chore: adds vanity import for files that don't have it. (#1297) 2020-11-04 09:10:58 -08:00
get_main_pkgs.sh Update License header for all source files (#586) 2020-03-23 22:41:10 -07:00
go.mod Bump github.com/google/go-cmp from 0.5.3 to 0.5.4 (#1374) 2020-11-30 10:31:41 -08:00
go.sum Bump github.com/google/go-cmp from 0.5.3 to 0.5.4 (#1374) 2020-11-30 10:31:41 -08:00
handler_test.go Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
handler.go Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
LICENSE Initial commit 2019-05-16 12:05:27 -07:00
Makefile Build examples last (#1370) 2020-12-01 08:02:36 -08:00
Makefile.proto Rework proto generation (#1371) 2020-12-07 09:36:06 -08:00
metric_test.go Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
metric.go Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
pre_release.sh Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
propagation.go Fix small typo (#1409) 2020-12-17 12:07:09 -08:00
README.md Mention the getting started guide (#1406) 2020-12-17 10:00:34 -08:00
RELEASING.md Add reminder to release contrib after this repo (#1030) 2020-08-05 09:01:00 -07:00
tag.sh Move tools package under internal (#1141) 2020-09-09 09:14:03 -07:00
trace_test.go Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
trace.go Move Version function and code from global to toplevel (#1330) 2020-11-16 09:30:54 -08:00
verify_examples.sh Clean up tools (#762) 2020-05-26 11:35:34 -07:00
version.go Release v0.15.0 (#1392) 2020-12-10 21:00:59 -08:00

OpenTelemetry-Go

Circle CI PkgGoDev Go Report Card Gitter

The Go OpenTelemetry implementation.

Project Status

Warning: this project is currently in a pre-GA phase. Backwards incompatible changes may be introduced in subsequent minor version releases as we work to track the evolving OpenTelemetry specification and user feedback.

Our progress towards a GA release candidate is tracked in this project board. This release candidate will follow semantic versioning and will be released with a major version greater than zero.

Progress and status specific to this repository is tracked in our local project boards and milestones.

Getting Started

You can find a getting started guide on opentelemetry.io.

OpenTelemetry's goal is to provide a single set of APIs to capture distributed traces and metrics from your application and send them to an observability platform. This project allows you to do just that for applications written in Go. There are two steps to this process: instrument your application, and configure an exporter.

Instrumentation

To start capturing distributed traces and metric events from your application it first needs to be instrumented. The easiest way to do this is by using an instrumentation library for your code. Be sure to check out the officially supported instrumentation libraries.

If you need to extend the telemetry an instrumentation library provides or want to build your own instrumentation for your application directly you will need to use the go.opentelemetry.io/otel/api package. The included examples are a good way to see some practical uses of this process.

Export

Now that your application is instrumented to collect telemetry, it needs an export pipeline to send that telemetry to an observability platform.

You can find officially supported exporters here and in the companion contrib repository. Additionally, there are many vendor specific or 3rd party exporters for OpenTelemetry. These exporters are broken down by trace and metric support.

Contributing

See the contributing documentation.