mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-14 10:13:10 +02:00
35215264dc
* Split protocol handling away from exporter This commits adds a ProtocolDriver interface, which the exporter will use to connect to the collector and send both metrics and traces to it. That way, the Exporter type is free from dealing with any connection/protocol details, as this business is taken over by the implementations of the ProtocolDriver interface. The gRPC code from the exporter is moved into the implementation of ProtocolDriver. Currently it only maintains a single connection, just as the Exporter used to do. With the split, most of the Exporter options became actually gRPC connection manager's options. Currently the only option that remained to be Exporter's is about setting the export kind selector. * Update changelog * Increase the test coverage of GRPC driver * Do not close a channel with multiple senders The disconnected channel can be used for sending by multiple goroutines (for example, by metric controller and span processor), so this channel should not be closed at all. Dropping this line closes a race between closing a channel and sending to it. * Simplify new connection handler The callbacks never return an error, so drop the return type from it. * Access clients under a lock The client may change as a result on reconnection in background, so guard against a racy access. * Simplify the GRPC driver a bit The config type was exported earlier to have a consistent way of configuring the driver, when also the multiple connection driver would appear. Since we are not going to add a multiple connection driver, pass the options directly to the driver constructor. Also shorten the name of the constructor to `NewGRPCDriver`. * Merge common gRPC code back into the driver The common code was supposed to be shared between single connection driver and multiple connection driver, but since the latter won't be happening, it makes no sense to keep the not-so-common code in a separate file. Also drop some abstraction too. * Rename the file with gRPC driver implementation * Update changelog * Sleep for a second to trigger the timeout Sometimes CI has it's better moments, so it's blazing fast and manages to finish shutting the exporter down within the 1 microsecond timeout. * Increase the timeout for shutting down the exporter One millisecond is quite short, and I was getting failures locally or in CI: go test ./... + race in ./exporters/otlp 2020/12/14 18:27:54 rpc error: code = Canceled desc = context canceled 2020/12/14 18:27:54 context deadline exceeded --- FAIL: TestNewExporter_withMultipleAttributeTypes (0.37s) otlp_integration_test.go:541: resource span count: got 0, want 1 FAIL FAIL go.opentelemetry.io/otel/exporters/otlp 5.278s or go test ./... + coverage in ./exporters/otlp 2020/12/14 17:41:16 rpc error: code = Canceled desc = context canceled 2020/12/14 17:41:16 exporter disconnected --- FAIL: TestNewExporter_endToEnd (1.53s) --- FAIL: TestNewExporter_endToEnd/WithCompressor (0.41s) otlp_integration_test.go:246: span counts: got 3, want 4 2020/12/14 17:41:18 context canceled FAIL coverage: 35.3% of statements in ./... FAIL go.opentelemetry.io/otel/exporters/otlp 4.753s * Shut down the providers in end to end test This is to make sure that all batched spans are actually flushed before closing the exporter.
173 lines
4.4 KiB
Go
173 lines
4.4 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package otlp
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
metricpb "go.opentelemetry.io/otel/exporters/otlp/internal/opentelemetry-proto-gen/metrics/v1"
|
|
tracepb "go.opentelemetry.io/otel/exporters/otlp/internal/opentelemetry-proto-gen/trace/v1"
|
|
"go.opentelemetry.io/otel/exporters/otlp/internal/transform"
|
|
|
|
metricsdk "go.opentelemetry.io/otel/sdk/export/metric"
|
|
tracesdk "go.opentelemetry.io/otel/sdk/export/trace"
|
|
)
|
|
|
|
type stubProtocolDriver struct {
|
|
rm []metricpb.ResourceMetrics
|
|
rs []tracepb.ResourceSpans
|
|
}
|
|
|
|
var _ ProtocolDriver = (*stubProtocolDriver)(nil)
|
|
|
|
func (m *stubProtocolDriver) Start(ctx context.Context) error {
|
|
select {
|
|
case <-ctx.Done():
|
|
return ctx.Err()
|
|
default:
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func (m *stubProtocolDriver) Stop(ctx context.Context) error {
|
|
select {
|
|
case <-ctx.Done():
|
|
return ctx.Err()
|
|
default:
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func (m *stubProtocolDriver) ExportMetrics(parent context.Context, cps metricsdk.CheckpointSet, selector metricsdk.ExportKindSelector) error {
|
|
rms, err := transform.CheckpointSet(parent, selector, cps, 1)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, rm := range rms {
|
|
if rm == nil {
|
|
continue
|
|
}
|
|
m.rm = append(m.rm, *rm)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *stubProtocolDriver) ExportTraces(ctx context.Context, ss []*tracesdk.SpanSnapshot) error {
|
|
for _, rs := range transform.SpanData(ss) {
|
|
if rs == nil {
|
|
continue
|
|
}
|
|
m.rs = append(m.rs, *rs)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *stubProtocolDriver) Reset() {
|
|
m.rm = nil
|
|
m.rs = nil
|
|
}
|
|
|
|
func newExporter(t *testing.T, opts ...ExporterOption) (*Exporter, *stubProtocolDriver) {
|
|
driver := &stubProtocolDriver{}
|
|
exp, err := NewExporter(context.Background(), driver, opts...)
|
|
require.NoError(t, err)
|
|
return exp, driver
|
|
}
|
|
|
|
func TestExporterShutdownHonorsTimeout(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Minute)
|
|
defer cancel()
|
|
|
|
e := NewUnstartedExporter(&stubProtocolDriver{})
|
|
if err := e.Start(ctx); err != nil {
|
|
t.Fatalf("failed to start exporter: %v", err)
|
|
}
|
|
|
|
innerCtx, innerCancel := context.WithTimeout(ctx, time.Microsecond)
|
|
<-time.After(time.Second)
|
|
if err := e.Shutdown(innerCtx); err == nil {
|
|
t.Error("expected context DeadlineExceeded error, got nil")
|
|
} else if !errors.Is(err, context.DeadlineExceeded) {
|
|
t.Errorf("expected context DeadlineExceeded error, got %v", err)
|
|
}
|
|
innerCancel()
|
|
}
|
|
|
|
func TestExporterShutdownHonorsCancel(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Minute)
|
|
defer cancel()
|
|
|
|
e := NewUnstartedExporter(&stubProtocolDriver{})
|
|
if err := e.Start(ctx); err != nil {
|
|
t.Fatalf("failed to start exporter: %v", err)
|
|
}
|
|
|
|
var innerCancel context.CancelFunc
|
|
ctx, innerCancel = context.WithCancel(ctx)
|
|
innerCancel()
|
|
if err := e.Shutdown(ctx); err == nil {
|
|
t.Error("expected context canceled error, got nil")
|
|
} else if !errors.Is(err, context.Canceled) {
|
|
t.Errorf("expected context canceled error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestExporterShutdownNoError(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Minute)
|
|
defer cancel()
|
|
|
|
e := NewUnstartedExporter(&stubProtocolDriver{})
|
|
if err := e.Start(ctx); err != nil {
|
|
t.Fatalf("failed to start exporter: %v", err)
|
|
}
|
|
|
|
if err := e.Shutdown(ctx); err != nil {
|
|
t.Errorf("shutdown errored: expected nil, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestExporterShutdownManyTimes(t *testing.T) {
|
|
ctx := context.Background()
|
|
e, err := NewExporter(ctx, &stubProtocolDriver{})
|
|
if err != nil {
|
|
t.Fatalf("failed to start an exporter: %v", err)
|
|
}
|
|
ch := make(chan struct{})
|
|
wg := sync.WaitGroup{}
|
|
const num int = 20
|
|
wg.Add(num)
|
|
errs := make([]error, num)
|
|
for i := 0; i < num; i++ {
|
|
go func(idx int) {
|
|
defer wg.Done()
|
|
<-ch
|
|
errs[idx] = e.Shutdown(ctx)
|
|
}(i)
|
|
}
|
|
close(ch)
|
|
wg.Wait()
|
|
for _, err := range errs {
|
|
if err != nil {
|
|
t.Fatalf("failed to shutdown exporter: %v", err)
|
|
}
|
|
}
|
|
}
|