1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-11 00:50:34 +02:00
Files
opentelemetry-go/sdk/metric/controller/basic/push_test.go
Joshua MacDonald 3c8e1853f0 Separate InstrumentationLibrary from metric.Descriptor (#2197)
* factor instrumentation library out of the instrument descriptor

* SDK tests pass

* checkpoint work

* otlp and opencensus tests passing

* prometheus

* tests pass, working on lint

* lint applied: MetricReader->Reader

* comments

* Changelog

* Apply suggestions from code review

Co-authored-by: alrex <alrex.boten@gmail.com>

* remove an interdependency

* fix build

* re-indent one

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Lint&feedback

* update after rename

* comment fix

* style fix for meter options

* remove libraryReader, let Controller implement the reader API directly

* rename 'impl' field to 'provider'

* remove a type assertion

* move metric/registry into internal; move registry.MeterProvider into metric controller

* add test for controller registry function

* CheckpointSet->Reader everywhere

* lint

* remove two unnecessary accessor methods; Controller implements MeterProvider and InstrumentationLibraryReader directly, no need to get these

* use a sync.Map

* ensure the initOnce is always called; handle multiple errors

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* cleanup locking in metrictest

* Revert "ensure the initOnce is always called; handle multiple errors"

This reverts commit 3356eb5ed0.

* Revert "use a sync.Map"

This reverts commit ea7bc599bd.

* restore the TODO about sync.Map

Co-authored-by: alrex <alrex.boten@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-09-27 08:51:47 -07:00

229 lines
5.7 KiB
Go

// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package basic_test
import (
"context"
"errors"
"fmt"
"runtime"
"sync"
"testing"
"time"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric"
export "go.opentelemetry.io/otel/sdk/export/metric"
"go.opentelemetry.io/otel/sdk/export/metric/aggregation"
controller "go.opentelemetry.io/otel/sdk/metric/controller/basic"
"go.opentelemetry.io/otel/sdk/metric/controller/controllertest"
processor "go.opentelemetry.io/otel/sdk/metric/processor/basic"
"go.opentelemetry.io/otel/sdk/metric/processor/processortest"
"go.opentelemetry.io/otel/sdk/resource"
)
var testResource = resource.NewSchemaless(attribute.String("R", "V"))
type handler struct {
sync.Mutex
err error
}
func (h *handler) Handle(err error) {
h.Lock()
h.err = err
h.Unlock()
}
func (h *handler) Flush() error {
h.Lock()
err := h.err
h.err = nil
h.Unlock()
return err
}
var testHandler *handler
func init() {
testHandler = new(handler)
otel.SetErrorHandler(testHandler)
}
func newExporter() *processortest.Exporter {
return processortest.New(
export.StatelessExportKindSelector(),
attribute.DefaultEncoder(),
)
}
func newCheckpointerFactory() export.CheckpointerFactory {
return processortest.NewCheckpointerFactory(
processortest.AggregatorSelector(),
attribute.DefaultEncoder(),
)
}
func TestPushDoubleStop(t *testing.T) {
ctx := context.Background()
exporter := newExporter()
checkpointer := newCheckpointerFactory()
p := controller.New(checkpointer, controller.WithExporter(exporter))
require.NoError(t, p.Start(ctx))
require.NoError(t, p.Stop(ctx))
require.NoError(t, p.Stop(ctx))
}
func TestPushDoubleStart(t *testing.T) {
ctx := context.Background()
exporter := newExporter()
checkpointer := newCheckpointerFactory()
p := controller.New(checkpointer, controller.WithExporter(exporter))
require.NoError(t, p.Start(ctx))
err := p.Start(ctx)
require.Error(t, err)
require.True(t, errors.Is(err, controller.ErrControllerStarted))
require.NoError(t, p.Stop(ctx))
}
func TestPushTicker(t *testing.T) {
exporter := newExporter()
checkpointer := newCheckpointerFactory()
p := controller.New(
checkpointer,
controller.WithExporter(exporter),
controller.WithCollectPeriod(time.Second),
controller.WithResource(testResource),
)
meter := p.Meter("name")
mock := controllertest.NewMockClock()
p.SetClock(mock)
ctx := context.Background()
counter := metric.Must(meter).NewInt64Counter("counter.sum")
require.NoError(t, p.Start(ctx))
counter.Add(ctx, 3)
require.EqualValues(t, map[string]float64{}, exporter.Values())
mock.Add(time.Second)
runtime.Gosched()
require.EqualValues(t, map[string]float64{
"counter.sum//R=V": 3,
}, exporter.Values())
require.Equal(t, 1, exporter.ExportCount())
exporter.Reset()
counter.Add(ctx, 7)
mock.Add(time.Second)
runtime.Gosched()
require.EqualValues(t, map[string]float64{
"counter.sum//R=V": 10,
}, exporter.Values())
require.Equal(t, 1, exporter.ExportCount())
exporter.Reset()
require.NoError(t, p.Stop(ctx))
}
func TestPushExportError(t *testing.T) {
injector := func(name string, e error) func(r export.Record) error {
return func(r export.Record) error {
if r.Descriptor().Name() == name {
return e
}
return nil
}
}
var errAggregator = fmt.Errorf("unexpected error")
var tests = []struct {
name string
injectedError error
expected map[string]float64
expectedError error
}{
{"errNone", nil, map[string]float64{
"counter1.sum/X=Y/R=V": 3,
"counter2.sum//R=V": 5,
}, nil},
{"errNoData", aggregation.ErrNoData, map[string]float64{
"counter2.sum//R=V": 5,
}, nil},
{"errUnexpected", errAggregator, map[string]float64{}, errAggregator},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
exporter := newExporter()
exporter.InjectErr = injector("counter1.sum", tt.injectedError)
// This test validates the error handling
// behavior of the basic Processor is honored
// by the push processor.
checkpointer := processor.NewFactory(processortest.AggregatorSelector(), exporter)
p := controller.New(
checkpointer,
controller.WithExporter(exporter),
controller.WithCollectPeriod(time.Second),
controller.WithResource(testResource),
)
mock := controllertest.NewMockClock()
p.SetClock(mock)
ctx := context.Background()
meter := p.Meter("name")
counter1 := metric.Must(meter).NewInt64Counter("counter1.sum")
counter2 := metric.Must(meter).NewInt64Counter("counter2.sum")
require.NoError(t, p.Start(ctx))
runtime.Gosched()
counter1.Add(ctx, 3, attribute.String("X", "Y"))
counter2.Add(ctx, 5)
require.Equal(t, 0, exporter.ExportCount())
require.Nil(t, testHandler.Flush())
mock.Add(time.Second)
runtime.Gosched()
require.Equal(t, 1, exporter.ExportCount())
if tt.expectedError == nil {
require.EqualValues(t, tt.expected, exporter.Values())
require.NoError(t, testHandler.Flush())
} else {
err := testHandler.Flush()
require.Error(t, err)
require.Equal(t, tt.expectedError, err)
}
require.NoError(t, p.Stop(ctx))
})
}
}