1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-01-12 02:28:07 +02:00
opentelemetry-go/bridge/opentracing
Anthony Mirabella ca3f74d976
Add Span#RecordError method to simplify adding error events to spans (#473)
* Add `Span#Error` method to simplify setting an error status and message.

* `Span#Error` should no-op on nil errors

* Record errors as a span event rather than status/attributes.

The implementation in the SDK package now relies on existing API methods.

* Add WithErrorStatus() ErrorOption to allow setting span status on error.

* Apply suggestions from code review

Co-Authored-By: Krzesimir Nowak <qdlacz@gmail.com>

* Address code review feedback

* Clean up RecordError tests

* Ensure complete and unique error type is recorded for defined types
* Avoid duplicating logic under test in tests

* Move TestError to internal/testing package, improve RecordError test scenarios

Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
2020-02-28 13:44:53 -08:00
..
internal Add Span#RecordError method to simplify adding error events to spans (#473) 2020-02-28 13:44:53 -08:00
migration Rename CurrentSpan to SpanFromContext & SetCurrentSpan to ContextWithSpan (#379) 2019-12-11 08:51:32 -08:00
bridge.go Replace span relationship with a potentially remote parent context (#451) 2020-02-04 08:55:03 -08:00
doc.go Namespace import path under "/otel" (#274) 2019-11-01 11:40:29 -07:00
mix_test.go Rename CurrentSpan to SpanFromContext & SetCurrentSpan to ContextWithSpan (#379) 2019-12-11 08:51:32 -08:00
util.go Rename GetTracer to Tracer (#347) 2019-11-25 09:46:07 -08:00
wrapper.go Add StartOptions to Tracer.WithSpan() (#472) 2020-02-10 21:07:32 -05:00