mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-03-03 14:52:56 +02:00
3c8e1853f0
* factor instrumentation library out of the instrument descriptor * SDK tests pass * checkpoint work * otlp and opencensus tests passing * prometheus * tests pass, working on lint * lint applied: MetricReader->Reader * comments * Changelog * Apply suggestions from code review Co-authored-by: alrex <alrex.boten@gmail.com> * remove an interdependency * fix build * re-indent one * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Lint&feedback * update after rename * comment fix * style fix for meter options * remove libraryReader, let Controller implement the reader API directly * rename 'impl' field to 'provider' * remove a type assertion * move metric/registry into internal; move registry.MeterProvider into metric controller * add test for controller registry function * CheckpointSet->Reader everywhere * lint * remove two unnecessary accessor methods; Controller implements MeterProvider and InstrumentationLibraryReader directly, no need to get these * use a sync.Map * ensure the initOnce is always called; handle multiple errors * Apply suggestions from code review Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * cleanup locking in metrictest * Revert "ensure the initOnce is always called; handle multiple errors" This reverts commit 3356eb5ed0c288ac3edcc2bc2e853aecda7f29b3. * Revert "use a sync.Map" This reverts commit ea7bc599bd3a24c4acb4cd9facd13f08cd702237. * restore the TODO about sync.Map Co-authored-by: alrex <alrex.boten@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
76 lines
2.4 KiB
Go
76 lines
2.4 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package metric
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"go.opentelemetry.io/otel/metric/metrictest"
|
|
"go.opentelemetry.io/otel/metric/number"
|
|
"go.opentelemetry.io/otel/metric/sdkapi"
|
|
"go.opentelemetry.io/otel/sdk/export/metric/aggregation"
|
|
)
|
|
|
|
func TestExportKindIncludes(t *testing.T) {
|
|
require.True(t, CumulativeExportKind.Includes(CumulativeExportKind))
|
|
require.True(t, DeltaExportKind.Includes(CumulativeExportKind|DeltaExportKind))
|
|
}
|
|
|
|
var deltaMemoryKinds = []sdkapi.InstrumentKind{
|
|
sdkapi.CounterObserverInstrumentKind,
|
|
sdkapi.UpDownCounterObserverInstrumentKind,
|
|
}
|
|
|
|
var cumulativeMemoryKinds = []sdkapi.InstrumentKind{
|
|
sdkapi.HistogramInstrumentKind,
|
|
sdkapi.GaugeObserverInstrumentKind,
|
|
sdkapi.CounterInstrumentKind,
|
|
sdkapi.UpDownCounterInstrumentKind,
|
|
}
|
|
|
|
func TestExportKindMemoryRequired(t *testing.T) {
|
|
for _, kind := range deltaMemoryKinds {
|
|
require.True(t, DeltaExportKind.MemoryRequired(kind))
|
|
require.False(t, CumulativeExportKind.MemoryRequired(kind))
|
|
}
|
|
|
|
for _, kind := range cumulativeMemoryKinds {
|
|
require.True(t, CumulativeExportKind.MemoryRequired(kind))
|
|
require.False(t, DeltaExportKind.MemoryRequired(kind))
|
|
}
|
|
}
|
|
|
|
func TestExportKindSelectors(t *testing.T) {
|
|
ceks := CumulativeExportKindSelector()
|
|
deks := DeltaExportKindSelector()
|
|
seks := StatelessExportKindSelector()
|
|
|
|
for _, ikind := range append(deltaMemoryKinds, cumulativeMemoryKinds...) {
|
|
desc := metrictest.NewDescriptor("instrument", ikind, number.Int64Kind)
|
|
|
|
var akind aggregation.Kind
|
|
if ikind.Adding() {
|
|
akind = aggregation.SumKind
|
|
} else {
|
|
akind = aggregation.HistogramKind
|
|
}
|
|
require.Equal(t, CumulativeExportKind, ceks.ExportKindFor(&desc, akind))
|
|
require.Equal(t, DeltaExportKind, deks.ExportKindFor(&desc, akind))
|
|
require.False(t, seks.ExportKindFor(&desc, akind).MemoryRequired(ikind))
|
|
}
|
|
}
|