mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-04 09:43:23 +02:00
7674eebf56
* Removed different types of Detectors for Resources. This change simplifies different types of collectors into one list. The order of this list determines how they are applied. Defaults are applied when the user does not supply any detectors. To achieve default behavior and additional behavior a DefaultDetectors struct has been created * missed prometheus test. * Changed behavior around WithDetectors(nil) Added examples of use of WithDetectors. * Added NoOp example * Changed test to reflect acutal default case This changes because WithDetector() no longer is the same as not using WithDetector() * Unexports the noOp detector * Updated changelog * Fixes to spelling mistakes. * Added NewEmptyResouce and unexported builtin detectors * Fix for prometheus example * Resource has two Rs I need to get a new R key it seems. Co-authored-by: Sam Xie <xsambundy@gmail.com> * Replaced NewEmptyResource() with New() * Fix test function name * Comment fixups. * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Sam Xie <xsambundy@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
89 lines
2.5 KiB
Go
89 lines
2.5 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package resource
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"go.opentelemetry.io/otel/attribute"
|
|
ottest "go.opentelemetry.io/otel/internal/internaltest"
|
|
)
|
|
|
|
func TestDetectOnePair(t *testing.T) {
|
|
store, err := ottest.SetEnvVariables(map[string]string{
|
|
envVar: "key=value",
|
|
})
|
|
require.NoError(t, err)
|
|
defer func() { require.NoError(t, store.Restore()) }()
|
|
|
|
detector := &fromEnv{}
|
|
res, err := detector.Detect(context.Background())
|
|
require.NoError(t, err)
|
|
assert.Equal(t, NewWithAttributes(attribute.String("key", "value")), res)
|
|
}
|
|
|
|
func TestDetectMultiPairs(t *testing.T) {
|
|
store, err := ottest.SetEnvVariables(map[string]string{
|
|
"x": "1",
|
|
envVar: "key=value, k = v , a= x, a=z",
|
|
})
|
|
require.NoError(t, err)
|
|
defer func() { require.NoError(t, store.Restore()) }()
|
|
|
|
detector := &fromEnv{}
|
|
res, err := detector.Detect(context.Background())
|
|
require.NoError(t, err)
|
|
assert.Equal(t, res, NewWithAttributes(
|
|
attribute.String("key", "value"),
|
|
attribute.String("k", "v"),
|
|
attribute.String("a", "x"),
|
|
attribute.String("a", "z"),
|
|
))
|
|
}
|
|
|
|
func TestEmpty(t *testing.T) {
|
|
store, err := ottest.SetEnvVariables(map[string]string{
|
|
envVar: " ",
|
|
})
|
|
require.NoError(t, err)
|
|
defer func() { require.NoError(t, store.Restore()) }()
|
|
|
|
detector := &fromEnv{}
|
|
res, err := detector.Detect(context.Background())
|
|
require.NoError(t, err)
|
|
assert.Equal(t, Empty(), res)
|
|
}
|
|
|
|
func TestMissingKeyError(t *testing.T) {
|
|
store, err := ottest.SetEnvVariables(map[string]string{
|
|
envVar: "key=value,key",
|
|
})
|
|
require.NoError(t, err)
|
|
defer func() { require.NoError(t, store.Restore()) }()
|
|
|
|
detector := &fromEnv{}
|
|
res, err := detector.Detect(context.Background())
|
|
assert.Error(t, err)
|
|
assert.Equal(t, err, fmt.Errorf("%w: %v", errMissingValue, "[key]"))
|
|
assert.Equal(t, res, NewWithAttributes(
|
|
attribute.String("key", "value"),
|
|
))
|
|
}
|