mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-14 10:13:10 +02:00
af114baf6b
* Call otel.Handle with non-nil errors That's what normally happens in other call sites. Those two didn't check it, but passed the "error" to Handle. The default, delegating implementation of ErrorHandler was printing the error unconditionally, which resulted in pointless lines like `2020/12/07 19:51:28 <nil>` in demos, for example. * Add tests Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
85 lines
2.2 KiB
Go
85 lines
2.2 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package trace
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type basicSpanProcesor struct {
|
|
running bool
|
|
injectShutdownError error
|
|
}
|
|
|
|
func (t *basicSpanProcesor) Shutdown(context.Context) error {
|
|
t.running = false
|
|
return t.injectShutdownError
|
|
}
|
|
|
|
func (t *basicSpanProcesor) OnStart(parent context.Context, s ReadWriteSpan) {}
|
|
func (t *basicSpanProcesor) OnEnd(s ReadOnlySpan) {}
|
|
func (t *basicSpanProcesor) ForceFlush() {}
|
|
|
|
func TestShutdownTraceProvider(t *testing.T) {
|
|
stp := NewTracerProvider()
|
|
sp := &basicSpanProcesor{}
|
|
stp.RegisterSpanProcessor(sp)
|
|
|
|
sp.running = true
|
|
|
|
_ = stp.Shutdown(context.Background())
|
|
|
|
if sp.running != false {
|
|
t.Errorf("Error shutdown basicSpanProcesor\n")
|
|
}
|
|
}
|
|
|
|
func TestFailedProcessorShutdown(t *testing.T) {
|
|
handler.Reset()
|
|
stp := NewTracerProvider()
|
|
spErr := errors.New("basic span processor shutdown failure")
|
|
sp := &basicSpanProcesor{
|
|
running: true,
|
|
injectShutdownError: spErr,
|
|
}
|
|
stp.RegisterSpanProcessor(sp)
|
|
|
|
_ = stp.Shutdown(context.Background())
|
|
|
|
assert.Contains(t, handler.errs, spErr)
|
|
}
|
|
|
|
func TestFailedProcessorShutdownInUnregister(t *testing.T) {
|
|
handler.Reset()
|
|
stp := NewTracerProvider()
|
|
spErr := errors.New("basic span processor shutdown failure")
|
|
sp := &basicSpanProcesor{
|
|
running: true,
|
|
injectShutdownError: spErr,
|
|
}
|
|
stp.RegisterSpanProcessor(sp)
|
|
stp.UnregisterSpanProcessor(sp)
|
|
|
|
assert.Contains(t, handler.errs, spErr)
|
|
|
|
handler.errs = nil
|
|
_ = stp.Shutdown(context.Background())
|
|
assert.Empty(t, handler.errs)
|
|
}
|