mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-28 21:09:17 +02:00
86df763d90
trace/noop/noop.Span should be instance. This will reduce memory waste.
Benchmark results
with changes:
new.txt
```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/trace/noop
BenchmarkNoopInstance-10 29894822 39.94 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 29675424 39.99 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 30064700 39.98 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 29962016 40.03 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 30060465 40.02 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 29916855 40.04 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 29829998 40.28 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 30084706 39.99 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 30087441 40.02 ns/op 48 B/op 1 allocs/op
BenchmarkNoopInstance-10 29864365 40.14 ns/op 48 B/op 1 allocs/op
```
without changes on `main`:
old.txt
```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/trace/noop
BenchmarkNoopInstance-10 14813442 67.64 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17714486 68.17 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17701257 67.66 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17805859 67.69 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17912841 67.43 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17864120 67.58 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17663130 68.41 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17740423 67.57 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17751040 67.56 ns/op 128 B/op 2 allocs/op
BenchmarkNoopInstance-10 17738064 67.91 ns/op 128 B/op 2 allocs/op
```
benchstat:
```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/trace/noop
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
NoopInstance-10 67.65n ± 1% 40.02n ± 0% -40.84% (p=0.000 n=10)
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
NoopInstance-10 128.00 ± 0% 48.00 ± 0% -62.50% (p=0.000 n=10)
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
NoopInstance-10 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
```
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
||
|---|---|---|
| .. | ||
| embedded | ||
| noop | ||
| config_test.go | ||
| config.go | ||
| context_test.go | ||
| context.go | ||
| doc.go | ||
| go.mod | ||
| go.sum | ||
| nonrecording.go | ||
| noop_test.go | ||
| noop.go | ||
| README.md | ||
| trace_test.go | ||
| trace.go | ||
| tracestate_benchkmark_test.go | ||
| tracestate_test.go | ||
| tracestate.go | ||