1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-14 10:13:10 +02:00
opentelemetry-go/sdk/metric/aggregator
Joshua MacDonald 3c8e1853f0
Separate InstrumentationLibrary from metric.Descriptor (#2197)
* factor instrumentation library out of the instrument descriptor

* SDK tests pass

* checkpoint work

* otlp and opencensus tests passing

* prometheus

* tests pass, working on lint

* lint applied: MetricReader->Reader

* comments

* Changelog

* Apply suggestions from code review

Co-authored-by: alrex <alrex.boten@gmail.com>

* remove an interdependency

* fix build

* re-indent one

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Lint&feedback

* update after rename

* comment fix

* style fix for meter options

* remove libraryReader, let Controller implement the reader API directly

* rename 'impl' field to 'provider'

* remove a type assertion

* move metric/registry into internal; move registry.MeterProvider into metric controller

* add test for controller registry function

* CheckpointSet->Reader everywhere

* lint

* remove two unnecessary accessor methods; Controller implements MeterProvider and InstrumentationLibraryReader directly, no need to get these

* use a sync.Map

* ensure the initOnce is always called; handle multiple errors

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* cleanup locking in metrictest

* Revert "ensure the initOnce is always called; handle multiple errors"

This reverts commit 3356eb5ed0.

* Revert "use a sync.Map"

This reverts commit ea7bc599bd.

* restore the TODO about sync.Map

Co-authored-by: alrex <alrex.boten@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-09-27 08:51:47 -07:00
..
aggregatortest Separate InstrumentationLibrary from metric.Descriptor (#2197) 2021-09-27 08:51:47 -07:00
exact Rename metric instruments to match feature-freeze API specification (#2202) 2021-09-01 16:38:37 -04:00
histogram Rename metric instruments to match feature-freeze API specification (#2202) 2021-09-01 16:38:37 -04:00
lastvalue Rename metric instruments to match feature-freeze API specification (#2202) 2021-09-01 16:38:37 -04:00
minmaxsumcount Rename metric instruments to match feature-freeze API specification (#2202) 2021-09-01 16:38:37 -04:00
sum Rename metric instruments to match feature-freeze API specification (#2202) 2021-09-01 16:38:37 -04:00
aggregator_test.go Separate InstrumentationLibrary from metric.Descriptor (#2197) 2021-09-27 08:51:47 -07:00
aggregator.go Rename metric instruments to match feature-freeze API specification (#2202) 2021-09-01 16:38:37 -04:00