You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-11-29 23:07:45 +02:00
Fixes #7004 This PR adds support for experimental otel.sdk.processor.span.processed metric in simple span processor. Definition of metric at: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/otel/sdk-metrics.md Experimental metrics are behind a feature flag: `OTEL_GO_X_OBSERVABILITY` <details> <summary>Observability Implementation Checklist</summary> ## Observability Implementation Checklist Based on the [project Observability guidelines](e4ab314112/CONTRIBUTING.md (observability)), ensure the following are completed: ### Environment Variable Activation * [x] Observability features are disabled by default * [x] Features are activated through the `OTEL_GO_X_OBSERVABILITY` environment variable * [x] Use consistent pattern with `x.Observability.Enabled()` check [^1] * [x] Follow established experimental feature pattern [^2][^3] [^1]:e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L101-L103)[^2]:e4ab314112/exporters/stdout/stdouttrace/internal/x/x.go[^3]:e4ab314112/sdk/internal/x/x.go### Encapsulation * [x] Instrumentation is encapsulated within a dedicated `struct` (e.g., [`Instrumentation`](e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L86-L94))) * [x] Instrumentation is not mixed into the instrumented component * [x] Instrumentation code is in its own file or package if complex/reused * [x] Instrumentation setup doesn't bloat the main component code ### Initialization * [x] Initialization is only done when observability is enabled * [x] Setup is explicit and side-effect free * [x] Return errors from initialization when appropriate * [x] Use the global Meter provider (e.g., `otel.GetMeterProvider()`) * [x] Include proper meter configuration with: * [x] Instrumentation package name is used for the Meter * [x] Instrumentation version (e.g. [`Version`](e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L40-L43))) * [x] Schema URL (e.g. [`SchemaURL`](e4ab314112/exporters/stdout/stdouttrace/internal/observ/instrumentation.go (L36-L38))) ### Performance * [x] Little to no overhead when observability is disabled * [x] Expensive operations are only executed when observability is enabled * [x] When enabled, instrumentation code paths are optimized to reduce allocation/computation overhead #### Attribute and Option Allocation Management * [x] Use `sync.Pool` for attribute slices and options with dynamic attributes * [x] Pool objects are properly reset before returning to pool * [x] Pools are scoped for maximum efficiency while ensuring correctness #### Caching * [x] Static attribute sets known at compile time are pre-computed and cached * [x] Common attribute combinations use lookup tables/maps #### Benchmarking * [x] Benchmarks provided for all instrumentation code * [ ] Benchmark scenarios include both enabled and disabled observability * [x] Benchmark results show impact on allocs/op, B/op, and ns/op (use `b.ReportAllocs()` in benchmarks) ### Error Handling and Robustness * [x] Errors are reported back to caller when possible * [x] Partial failures are handled gracefully * [x] Use partially initialized components when available * [x] Return errors to caller instead of only using `otel.Handle()` * [x] Use `otel.Handle()` only when component cannot report error to user ### Context Propagation * [x] Observability measurements receive the context from the function being measured (don't break context propagation by using `context.Background()`) ### Semantic Conventions Compliance * [x] All metrics follow [OpenTelemetry Semantic Conventions](5ee549b1ce/docs/otel/sdk-metrics.md) * [x] Use the [`otelconv`](https://pkg.go.dev/go.opentelemetry.io/otel@v1.38.0/semconv/v1.37.0/otelconv) convenience package for metric semantic conventions * [x] Component names follow semantic conventions * [x] Use package path scope type as stable identifier for non-standard components * [x] Component names are stable unique identifiers * [x] Use global counter for uniqueness if necessary * [x] Component ID counter is resettable for deterministic testing ### Testing * [x] Use deterministic testing with isolated state * [x] Restore previous state after tests (`t.Cleanup()`) * [x] Isolate meter provider for testing * [x] Use `t.Setenv()` for environment variable testing * [x] Reset component ID counter for deterministic component names * [x] Test order doesn't affect results </details> ### Benchmarks ```console > benchstat bmark.result goos: darwin goarch: arm64 pkg: go.opentelemetry.io/otel/sdk/trace/internal/observ cpu: Apple M1 Pro │ bmark.result │ │ sec/op │ SSP/SpanProcessed-8 146.7n ± 15% SSP/SpanProcessedWithError-8 205.1n ± 3% geomean 173.5n │ bmark.result │ │ B/op │ SSP/SpanProcessed-8 280.0 ± 0% SSP/SpanProcessedWithError-8 408.0 ± 0% geomean 338.0 │ bmark.result │ │ allocs/op │ SSP/SpanProcessed-8 3.000 ± 0% SSP/SpanProcessedWithError-8 3.000 ± 0% geomean 3.000 ``` --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
128 lines
3.0 KiB
Go
128 lines
3.0 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
package observ_test
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/metric/noop"
|
|
"go.opentelemetry.io/otel/sdk/trace/internal/observ"
|
|
semconv "go.opentelemetry.io/otel/semconv/v1.37.0"
|
|
)
|
|
|
|
const sspComponentID = 0
|
|
|
|
func TestSSPComponentName(t *testing.T) {
|
|
got := observ.SSPComponentName(10)
|
|
want := semconv.OTelComponentName("simple_span_processor/10")
|
|
assert.Equal(t, want, got)
|
|
}
|
|
|
|
func TestNewSSPError(t *testing.T) {
|
|
t.Setenv("OTEL_GO_X_OBSERVABILITY", "true")
|
|
|
|
orig := otel.GetMeterProvider()
|
|
t.Cleanup(func() { otel.SetMeterProvider(orig) })
|
|
|
|
mp := &errMeterProvider{err: assert.AnError}
|
|
otel.SetMeterProvider(mp)
|
|
|
|
_, err := observ.NewSSP(sspComponentID)
|
|
require.ErrorIs(t, err, assert.AnError, "new instrument errors")
|
|
assert.ErrorContains(t, err, "create SSP processed spans metric")
|
|
}
|
|
|
|
func TestNewSSPDisabled(t *testing.T) {
|
|
ssp, err := observ.NewSSP(sspComponentID)
|
|
assert.NoError(t, err)
|
|
assert.Nil(t, ssp)
|
|
}
|
|
|
|
func TestSSPSpanProcessed(t *testing.T) {
|
|
ctx := t.Context()
|
|
collect := setup(t)
|
|
ssp, err := observ.NewSSP(sspComponentID)
|
|
assert.NoError(t, err)
|
|
|
|
ssp.SpanProcessed(ctx, nil)
|
|
check(t, collect(), processed(dPt(sspSet(), 1)))
|
|
ssp.SpanProcessed(ctx, nil)
|
|
ssp.SpanProcessed(ctx, nil)
|
|
check(t, collect(), processed(dPt(sspSet(), 3)))
|
|
|
|
processErr := errors.New("error processing span")
|
|
ssp.SpanProcessed(ctx, processErr)
|
|
check(t, collect(), processed(
|
|
dPt(sspSet(), 3),
|
|
dPt(sspSet(semconv.ErrorType(processErr)), 1),
|
|
))
|
|
}
|
|
|
|
func BenchmarkSSP(b *testing.B) {
|
|
b.Setenv("OTEL_GO_X_OBSERVABILITY", "true")
|
|
|
|
newSSP := func(b *testing.B) *observ.SSP {
|
|
b.Helper()
|
|
ssp, err := observ.NewSSP(sspComponentID)
|
|
require.NoError(b, err)
|
|
require.NotNil(b, ssp)
|
|
return ssp
|
|
}
|
|
|
|
b.Run("SpanProcessed", func(b *testing.B) {
|
|
orig := otel.GetMeterProvider()
|
|
b.Cleanup(func() {
|
|
otel.SetMeterProvider(orig)
|
|
})
|
|
|
|
// Ensure deterministic benchmark by using noop meter.
|
|
otel.SetMeterProvider(noop.NewMeterProvider())
|
|
|
|
ssp := newSSP(b)
|
|
ctx := b.Context()
|
|
|
|
b.ResetTimer()
|
|
b.ReportAllocs()
|
|
b.RunParallel(func(pb *testing.PB) {
|
|
for pb.Next() {
|
|
ssp.SpanProcessed(ctx, nil)
|
|
}
|
|
})
|
|
})
|
|
|
|
b.Run("SpanProcessedWithError", func(b *testing.B) {
|
|
orig := otel.GetMeterProvider()
|
|
b.Cleanup(func() {
|
|
otel.SetMeterProvider(orig)
|
|
})
|
|
|
|
// Ensure deterministic benchmark by using noop meter.
|
|
otel.SetMeterProvider(noop.NewMeterProvider())
|
|
|
|
ssp := newSSP(b)
|
|
ctx := b.Context()
|
|
processErr := errors.New("error processing span")
|
|
|
|
b.ResetTimer()
|
|
b.ReportAllocs()
|
|
b.RunParallel(func(pb *testing.PB) {
|
|
for pb.Next() {
|
|
ssp.SpanProcessed(ctx, processErr)
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
func sspSet(attrs ...attribute.KeyValue) attribute.Set {
|
|
return attribute.NewSet(append([]attribute.KeyValue{
|
|
semconv.OTelComponentTypeSimpleSpanProcessor,
|
|
observ.SSPComponentName(sspComponentID),
|
|
}, attrs...)...)
|
|
}
|