1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-14 10:13:10 +02:00
opentelemetry-go/api/global/internal
Tyler Yahn d143b8fbf8
Unify API Span Start/End Options (#1108)
* Unify API Span Start/End Options

Replace both with `SpanOption`. Add a unified `SpanConfig` to match and
a `SpanConfigure` function to parse a `SpanConfig` from `SpanOption`s.

Update all the related options to use new `SpanOption`s.

* No non-zero SpanConfig defaults

The SDK uses an internal clock for the current time that cannot be use
if it does not know the time has not been set.

* Append attributes for WithAttributes

This preserves existing behavior.

* Add unit test for SpanConfigure

* Propagate changes

* Update append option documentation

* Update testing comments

* Move comments on guarantees to appropriate function

* Add documentation for SDK methods

Include SDK implementation specific information in the Tracer Start
method and Span End method.

* Add changes to Changelog

* Apply suggestions from code review

Co-authored-by: ET <evantorrie@users.noreply.github.com>

* Update the SpanKind comment in the  SpanConfig

Try for a less tautological comment.

Co-authored-by: ET <evantorrie@users.noreply.github.com>
2020-09-03 07:34:36 -07:00
..
benchmark_test.go Unify api/label and api/kv in new label package (#1060) 2020-08-17 20:25:03 -07:00
internal_test.go Update License header for all source files (#586) 2020-03-23 22:41:10 -07:00
meter_test.go #872 Make metric test helpers public (#1040) 2020-08-27 13:03:56 -07:00
meter.go Unify api/label and api/kv in new label package (#1060) 2020-08-17 20:25:03 -07:00
registry_test.go Rename Register* to New* (#761) 2020-05-21 15:42:14 -07:00
state.go Rename global SetTraceProvider and TraceProvider (#1102) 2020-08-31 10:02:04 -07:00
trace_test.go Rename global SetTraceProvider and TraceProvider (#1102) 2020-08-31 10:02:04 -07:00
trace.go Unify API Span Start/End Options (#1108) 2020-09-03 07:34:36 -07:00