mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-12 10:04:29 +02:00
0041e2d26e
* Rename ParentOrElse to ParentBased and enhance it according to the spec - Renaming of type and sampler function - Enhancing ParentBased with sampler options - Set default samplers for each applicable parent-based case - Adjust ShouldSample(...) func accordingly * Adjust existing tests for ParentBased and add new ones - add tests for ParentBased sampler options and description - renaming in trace_test.go * Update CHANGELOG.md * PR feedback - More clearer naming of structs; add comments where missing - Adhere to the configuration style guide * PR feedback - punctuation
191 lines
5.2 KiB
Go
191 lines
5.2 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package trace
|
|
|
|
import (
|
|
"fmt"
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
api "go.opentelemetry.io/otel/api/trace"
|
|
)
|
|
|
|
func TestParentBasedDefaultLocalParentSampled(t *testing.T) {
|
|
sampler := ParentBased(AlwaysSample())
|
|
traceID, _ := api.IDFromHex("4bf92f3577b34da6a3ce929d0e0e4736")
|
|
spanID, _ := api.SpanIDFromHex("00f067aa0ba902b7")
|
|
parentCtx := api.SpanContext{
|
|
TraceID: traceID,
|
|
SpanID: spanID,
|
|
TraceFlags: api.FlagsSampled,
|
|
}
|
|
if sampler.ShouldSample(SamplingParameters{ParentContext: parentCtx}).Decision != RecordAndSampled {
|
|
t.Error("Sampling decision should be RecordAndSampled")
|
|
}
|
|
}
|
|
|
|
func TestParentBasedDefaultLocalParentNotSampled(t *testing.T) {
|
|
sampler := ParentBased(AlwaysSample())
|
|
traceID, _ := api.IDFromHex("4bf92f3577b34da6a3ce929d0e0e4736")
|
|
spanID, _ := api.SpanIDFromHex("00f067aa0ba902b7")
|
|
parentCtx := api.SpanContext{
|
|
TraceID: traceID,
|
|
SpanID: spanID,
|
|
}
|
|
if sampler.ShouldSample(SamplingParameters{ParentContext: parentCtx}).Decision != NotRecord {
|
|
t.Error("Sampling decision should be NotRecord")
|
|
}
|
|
}
|
|
|
|
func TestParentBasedWithNoParent(t *testing.T) {
|
|
params := SamplingParameters{}
|
|
|
|
sampler := ParentBased(AlwaysSample())
|
|
if sampler.ShouldSample(params).Decision != RecordAndSampled {
|
|
t.Error("Sampling decision should be RecordAndSampled")
|
|
}
|
|
|
|
sampler = ParentBased(NeverSample())
|
|
if sampler.ShouldSample(params).Decision != NotRecord {
|
|
t.Error("Sampling decision should be NotRecord")
|
|
}
|
|
}
|
|
|
|
func TestParentBasedWithSamplerOptions(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
samplerOption ParentBasedSamplerOption
|
|
isParentRemote, isParentSampled bool
|
|
expectedDecision SamplingDecision
|
|
}{
|
|
{
|
|
"localParentSampled",
|
|
WithLocalParentSampled(NeverSample()),
|
|
false,
|
|
true,
|
|
NotRecord,
|
|
},
|
|
{
|
|
"localParentNotSampled",
|
|
WithLocalParentNotSampled(AlwaysSample()),
|
|
false,
|
|
false,
|
|
RecordAndSampled,
|
|
},
|
|
{
|
|
"remoteParentSampled",
|
|
WithRemoteParentSampled(NeverSample()),
|
|
true,
|
|
true,
|
|
NotRecord,
|
|
},
|
|
{
|
|
"remoteParentNotSampled",
|
|
WithRemoteParentNotSampled(AlwaysSample()),
|
|
true,
|
|
false,
|
|
RecordAndSampled,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
traceID, _ := api.IDFromHex("4bf92f3577b34da6a3ce929d0e0e4736")
|
|
spanID, _ := api.SpanIDFromHex("00f067aa0ba902b7")
|
|
parentCtx := api.SpanContext{
|
|
TraceID: traceID,
|
|
SpanID: spanID,
|
|
}
|
|
|
|
if tc.isParentSampled {
|
|
parentCtx.TraceFlags = api.FlagsSampled
|
|
}
|
|
|
|
params := SamplingParameters{ParentContext: parentCtx}
|
|
if tc.isParentRemote {
|
|
params.HasRemoteParent = true
|
|
}
|
|
|
|
sampler := ParentBased(
|
|
nil,
|
|
tc.samplerOption,
|
|
)
|
|
|
|
switch tc.expectedDecision {
|
|
case RecordAndSampled:
|
|
if sampler.ShouldSample(params).Decision != tc.expectedDecision {
|
|
t.Error("Sampling decision should be RecordAndSampled")
|
|
}
|
|
case NotRecord:
|
|
if sampler.ShouldSample(params).Decision != tc.expectedDecision {
|
|
t.Error("Sampling decision should be NotRecord")
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParentBasedDefaultDescription(t *testing.T) {
|
|
sampler := ParentBased(AlwaysSample())
|
|
|
|
expectedDescription := fmt.Sprintf("ParentBased{root:%s,remoteParentSampled:%s,"+
|
|
"remoteParentNotSampled:%s,localParentSampled:%s,localParentNotSampled:%s}",
|
|
AlwaysSample().Description(),
|
|
AlwaysSample().Description(),
|
|
NeverSample().Description(),
|
|
AlwaysSample().Description(),
|
|
NeverSample().Description())
|
|
|
|
if sampler.Description() != expectedDescription {
|
|
t.Error(fmt.Sprintf("Sampler description should be %s, got '%s' instead",
|
|
expectedDescription,
|
|
sampler.Description(),
|
|
))
|
|
}
|
|
|
|
}
|
|
|
|
// TraceIDRatioBased sampler requirements state
|
|
// "A TraceIDRatioBased sampler with a given sampling rate MUST also sample
|
|
// all traces that any TraceIDRatioBased sampler with a lower sampling rate
|
|
// would sample."
|
|
func TestTraceIdRatioSamplesInclusively(t *testing.T) {
|
|
const (
|
|
numSamplers = 1000
|
|
numTraces = 100
|
|
)
|
|
idg := defIDGenerator()
|
|
|
|
for i := 0; i < numSamplers; i++ {
|
|
ratioLo, ratioHi := rand.Float64(), rand.Float64()
|
|
if ratioHi < ratioLo {
|
|
ratioLo, ratioHi = ratioHi, ratioLo
|
|
}
|
|
samplerHi := TraceIDRatioBased(ratioHi)
|
|
samplerLo := TraceIDRatioBased(ratioLo)
|
|
for j := 0; j < numTraces; j++ {
|
|
traceID := idg.NewTraceID()
|
|
|
|
params := SamplingParameters{TraceID: traceID}
|
|
if samplerLo.ShouldSample(params).Decision == RecordAndSampled {
|
|
require.Equal(t, RecordAndSampled, samplerHi.ShouldSample(params).Decision,
|
|
"%s sampled but %s did not", samplerLo.Description(), samplerHi.Description())
|
|
}
|
|
}
|
|
}
|
|
}
|