1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Files
opentelemetry-go/sdk/log/logger.go
T
Tyler Yahn b335c0795c Encapsulate observability in Logs SDK (#7315)
- [Follow
guidelines](https://github.com/open-telemetry/opentelemetry-go/blob/a5dcd68ebb2f3669f7685ac7b0f3f1624251a381/CONTRIBUTING.md#encapsulation)
and encapsulate the Observability for the Logs SDK logger by moving it
into a single function.
- Add benchmarks to ensure no performance regressions

### Benchmarks

```console
$ benchstat main_2de26d1de.txt enc-sdk-log-obs_c06e888.txt
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/log
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
                                   │ main_2de26d1de.txt │    enc-sdk-log-obs_c06e888.txt     │
                                   │       sec/op       │   sec/op     vs base               │
LoggerEmitObservability/Disabled-8          167.8n ± 4%   167.3n ± 5%       ~ (p=0.796 n=10)
LoggerEmitObservability/Enabled-8           556.6n ± 4%   556.1n ± 4%       ~ (p=0.955 n=10)
geomean                                     305.6n        305.0n       -0.19%

                                   │ main_2de26d1de.txt │     enc-sdk-log-obs_c06e888.txt     │
                                   │        B/op        │    B/op     vs base                 │
LoggerEmitObservability/Disabled-8           448.0 ± 0%   448.0 ± 0%       ~ (p=1.000 n=10) ¹
LoggerEmitObservability/Enabled-8            448.0 ± 0%   448.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                      448.0        448.0       +0.00%
¹ all samples are equal

                                   │ main_2de26d1de.txt │     enc-sdk-log-obs_c06e888.txt     │
                                   │     allocs/op      │ allocs/op   vs base                 │
LoggerEmitObservability/Disabled-8           1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
LoggerEmitObservability/Enabled-8            1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                      1.000        1.000       +0.00%
¹ all samples are equal
```
2025-09-08 07:29:01 -07:00

128 lines
3.6 KiB
Go

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
package log // import "go.opentelemetry.io/otel/sdk/log"
import (
"context"
"time"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/log"
"go.opentelemetry.io/otel/log/embedded"
"go.opentelemetry.io/otel/sdk/instrumentation"
"go.opentelemetry.io/otel/trace"
)
var now = time.Now
// Compile-time check logger implements log.Logger.
var _ log.Logger = (*logger)(nil)
type logger struct {
embedded.Logger
provider *LoggerProvider
instrumentationScope instrumentation.Scope
// recCntIncr increments the count of log records created. It will be nil
// if observability is disabled.
recCntIncr func(context.Context)
}
func newLogger(p *LoggerProvider, scope instrumentation.Scope) *logger {
l := &logger{
provider: p,
instrumentationScope: scope,
}
var err error
l.recCntIncr, err = newRecordCounterIncr()
if err != nil {
otel.Handle(err)
}
return l
}
func (l *logger) Emit(ctx context.Context, r log.Record) {
newRecord := l.newRecord(ctx, r)
for _, p := range l.provider.processors {
if err := p.OnEmit(ctx, &newRecord); err != nil {
otel.Handle(err)
}
}
}
// Enabled returns true if at least one Processor held by the LoggerProvider
// that created the logger will process param for the provided context and param.
//
// If it is not possible to definitively determine the param will be
// processed, true will be returned by default. A value of false will only be
// returned if it can be positively verified that no Processor will process.
func (l *logger) Enabled(ctx context.Context, param log.EnabledParameters) bool {
p := EnabledParameters{
InstrumentationScope: l.instrumentationScope,
Severity: param.Severity,
EventName: param.EventName,
}
// If there are more Processors than FilterProcessors,
// which means not all Processors are FilterProcessors,
// we cannot be sure that all Processors will drop the record.
// Therefore, return true.
//
// If all Processors are FilterProcessors, check if any is enabled.
return len(l.provider.processors) > len(l.provider.fltrProcessors) || anyEnabled(ctx, p, l.provider.fltrProcessors)
}
func anyEnabled(ctx context.Context, param EnabledParameters, fltrs []FilterProcessor) bool {
for _, f := range fltrs {
if f.Enabled(ctx, param) {
// At least one Processor will process the Record.
return true
}
}
// No Processor will process the record
return false
}
func (l *logger) newRecord(ctx context.Context, r log.Record) Record {
sc := trace.SpanContextFromContext(ctx)
newRecord := Record{
eventName: r.EventName(),
timestamp: r.Timestamp(),
observedTimestamp: r.ObservedTimestamp(),
severity: r.Severity(),
severityText: r.SeverityText(),
traceID: sc.TraceID(),
spanID: sc.SpanID(),
traceFlags: sc.TraceFlags(),
resource: l.provider.resource,
scope: &l.instrumentationScope,
attributeValueLengthLimit: l.provider.attributeValueLengthLimit,
attributeCountLimit: l.provider.attributeCountLimit,
allowDupKeys: l.provider.allowDupKeys,
}
if l.recCntIncr != nil {
l.recCntIncr(ctx)
}
// This ensures we deduplicate key-value collections in the log body
newRecord.SetBody(r.Body())
// This field SHOULD be set once the event is observed by OpenTelemetry.
if newRecord.observedTimestamp.IsZero() {
newRecord.observedTimestamp = now()
}
r.WalkAttributes(func(kv log.KeyValue) bool {
newRecord.AddAttributes(kv)
return true
})
return newRecord
}