mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-28 21:09:17 +02:00
ae6d29f4b1
This benchmark was not only testing the batch processor, since it was starting a span, and ending it. So the entire process of recording span was being accounted. This changes the benchmark to only account for the batch processor being tested, not the entire stack. Before: ``` pkg: go.opentelemetry.io/otel/sdk/trace BenchmarkSpanProcessor-10 137320 8696 ns/op 11184 B/op 155 allocs/op BenchmarkSpanProcessorVerboseLogging-10 135483 8881 ns/op 11184 B/op 155 allocs/op PASS ok go.opentelemetry.io/otel/sdk/trace 3.984s ``` After: ``` pkg: go.opentelemetry.io/otel/sdk/trace BenchmarkSpanProcessorOnEnd/batch:_10,_spans:_10-10 6055572 173.2 ns/op 0 B/op 0 allocs/op BenchmarkSpanProcessorOnEnd/batch:_10,_spans:_100-10 684236 1733 ns/op 0 B/op 0 allocs/op BenchmarkSpanProcessorOnEnd/batch:_100,_spans:_10-10 6930391 173.8 ns/op 0 B/op 0 allocs/op BenchmarkSpanProcessorOnEnd/batch:_100,_spans:_100-10 677128 1731 ns/op 0 B/op 0 allocs/op BenchmarkSpanProcessorVerboseLogging-10 128823 9318 ns/op 11184 B/op 155 allocs/op PASS ok go.opentelemetry.io/otel/sdk/trace 6.763s ``` I haven't touched the verbose logging benchmark, as I suppose a benchmark with verbose logging could actually benefit from the entire stack. I also feel one benchmark testing the entire stack up to there could be nice. |
||
|---|---|---|
| .. | ||
| tracetest | ||
| batch_span_processor_test.go | ||
| batch_span_processor.go | ||
| benchmark_test.go | ||
| doc.go | ||
| event.go | ||
| evictedqueue_test.go | ||
| evictedqueue.go | ||
| id_generator_test.go | ||
| id_generator.go | ||
| link.go | ||
| provider_test.go | ||
| provider.go | ||
| README.md | ||
| sampler_env.go | ||
| sampling_test.go | ||
| sampling.go | ||
| simple_span_processor_test.go | ||
| simple_span_processor.go | ||
| snapshot.go | ||
| span_exporter.go | ||
| span_limits_test.go | ||
| span_limits.go | ||
| span_processor_annotator_example_test.go | ||
| span_processor_filter_example_test.go | ||
| span_processor_test.go | ||
| span_processor.go | ||
| span_test.go | ||
| span.go | ||
| trace_test.go | ||
| tracer.go | ||
| util_test.go | ||
| version_test.go | ||
| version.go | ||