You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-11-25 22:41:46 +02:00
3429e15b9a
Topic: #5249
This reverts commit 8041156518 (PR: #5899)
due to the performance degradation found by Benchmarks CI
https://github.com/open-telemetry/opentelemetry-go/actions/runs/11447364022/job/31848519243
Here is the benchmark test on my machine:
```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/metric
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
Instrument/instrumentImpl/aggregate-10 3.378µ ± 3% 49.366µ ± 1% +1361.40% (p=0.000 n=10)
Instrument/observable/observe-10 2.288µ ± 2% 37.791µ ± 1% +1551.73% (p=0.000 n=10)
geomean 2.780µ 43.19µ +1453.65%
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
Instrument/instrumentImpl/aggregate-10 1.245Ki ± 1% 22.363Ki ± 0% +1696.08% (p=0.000 n=10)
Instrument/observable/observe-10 823.0 ± 1% 17432.5 ± 0% +2018.17% (p=0.000 n=10)
geomean 1.000Ki 19.51Ki +1850.48%
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
Instrument/instrumentImpl/aggregate-10 1.000 ± 0% 21.000 ± 0% +2000.00% (p=0.000 n=10)
Instrument/observable/observe-10 1.000 ± 0% 16.000 ± 0% +1500.00% (p=0.000 n=10)
```
78 lines
3.1 KiB
Go
78 lines
3.1 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package metric // import "go.opentelemetry.io/otel/sdk/metric"
|
|
|
|
import (
|
|
"runtime"
|
|
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/sdk/metric/exemplar"
|
|
"go.opentelemetry.io/otel/sdk/metric/internal/aggregate"
|
|
)
|
|
|
|
// ExemplarReservoirProviderSelector selects the
|
|
// [exemplar.ReservoirProvider] to use
|
|
// based on the [Aggregation] of the metric.
|
|
type ExemplarReservoirProviderSelector func(Aggregation) exemplar.ReservoirProvider
|
|
|
|
// reservoirFunc returns the appropriately configured exemplar reservoir
|
|
// creation func based on the passed InstrumentKind and filter configuration.
|
|
func reservoirFunc[N int64 | float64](provider exemplar.ReservoirProvider, filter exemplar.Filter) func(attribute.Set) aggregate.FilteredExemplarReservoir[N] {
|
|
return func(attrs attribute.Set) aggregate.FilteredExemplarReservoir[N] {
|
|
return aggregate.NewFilteredExemplarReservoir[N](filter, provider(attrs))
|
|
}
|
|
}
|
|
|
|
// DefaultExemplarReservoirProviderSelector returns the default
|
|
// [exemplar.ReservoirProvider] for the
|
|
// provided [Aggregation].
|
|
//
|
|
// For explicit bucket histograms with more than 1 bucket, it uses the
|
|
// [exemplar.HistogramReservoirProvider].
|
|
// For exponential histograms, it uses the
|
|
// [exemplar.FixedSizeReservoirProvider]
|
|
// with a size of min(20, max_buckets).
|
|
// For all other aggregations, it uses the
|
|
// [exemplar.FixedSizeReservoirProvider]
|
|
// with a size equal to the number of CPUs.
|
|
//
|
|
// Exemplar default reservoirs MAY change in a minor version bump. No
|
|
// guarantees are made on the shape or statistical properties of returned
|
|
// exemplars.
|
|
func DefaultExemplarReservoirProviderSelector(agg Aggregation) exemplar.ReservoirProvider {
|
|
// https://github.com/open-telemetry/opentelemetry-specification/blob/d4b241f451674e8f611bb589477680341006ad2b/specification/metrics/sdk.md#exemplar-defaults
|
|
// Explicit bucket histogram aggregation with more than 1 bucket will
|
|
// use AlignedHistogramBucketExemplarReservoir.
|
|
a, ok := agg.(AggregationExplicitBucketHistogram)
|
|
if ok && len(a.Boundaries) > 0 {
|
|
return exemplar.HistogramReservoirProvider(a.Boundaries)
|
|
}
|
|
|
|
var n int
|
|
if a, ok := agg.(AggregationBase2ExponentialHistogram); ok {
|
|
// Base2 Exponential Histogram Aggregation SHOULD use a
|
|
// SimpleFixedSizeExemplarReservoir with a reservoir equal to the
|
|
// smaller of the maximum number of buckets configured on the
|
|
// aggregation or twenty (e.g. min(20, max_buckets)).
|
|
n = int(a.MaxSize)
|
|
if n > 20 {
|
|
n = 20
|
|
}
|
|
} else {
|
|
// https://github.com/open-telemetry/opentelemetry-specification/blob/e94af89e3d0c01de30127a0f423e912f6cda7bed/specification/metrics/sdk.md#simplefixedsizeexemplarreservoir
|
|
// This Exemplar reservoir MAY take a configuration parameter for
|
|
// the size of the reservoir. If no size configuration is
|
|
// provided, the default size MAY be the number of possible
|
|
// concurrent threads (e.g. number of CPUs) to help reduce
|
|
// contention. Otherwise, a default size of 1 SHOULD be used.
|
|
n = runtime.NumCPU()
|
|
if n < 1 {
|
|
// Should never be the case, but be defensive.
|
|
n = 1
|
|
}
|
|
}
|
|
|
|
return exemplar.FixedSizeReservoirProvider(n)
|
|
}
|