1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-01-05 22:54:18 +02:00
opentelemetry-go/sdk/metric
Sam Xie 3429e15b9a
Revert Cleanup interaction of exemplar and aggregation (#5913)
Topic: #5249

This reverts commit 8041156518 (PR: #5899)
due to the performance degradation found by Benchmarks CI
https://github.com/open-telemetry/opentelemetry-go/actions/runs/11447364022/job/31848519243

Here is the benchmark test on my machine:

```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/metric
                                       │   old.txt   │                new.txt                 │
                                       │   sec/op    │    sec/op     vs base                  │
Instrument/instrumentImpl/aggregate-10   3.378µ ± 3%   49.366µ ± 1%  +1361.40% (p=0.000 n=10)
Instrument/observable/observe-10         2.288µ ± 2%   37.791µ ± 1%  +1551.73% (p=0.000 n=10)
geomean                                  2.780µ         43.19µ       +1453.65%

                                       │   old.txt    │                 new.txt                 │
                                       │     B/op     │     B/op       vs base                  │
Instrument/instrumentImpl/aggregate-10   1.245Ki ± 1%   22.363Ki ± 0%  +1696.08% (p=0.000 n=10)
Instrument/observable/observe-10           823.0 ± 1%    17432.5 ± 0%  +2018.17% (p=0.000 n=10)
geomean                                  1.000Ki         19.51Ki       +1850.48%

                                       │  old.txt   │                new.txt                │
                                       │ allocs/op  │  allocs/op   vs base                  │
Instrument/instrumentImpl/aggregate-10   1.000 ± 0%   21.000 ± 0%  +2000.00% (p=0.000 n=10)
Instrument/observable/observe-10         1.000 ± 0%   16.000 ± 0%  +1500.00% (p=0.000 n=10)
```
2024-10-23 10:48:07 -07:00
..
exemplar Add selector of exemplar reservoir providers to metric.Stream configuration (#5861) 2024-10-18 09:05:10 -04:00
internal Revert Cleanup interaction of exemplar and aggregation (#5913) 2024-10-23 10:48:07 -07:00
metricdata [chore]: enable len and empty rules from testifylint (#5832) 2024-09-21 08:04:28 -07:00
aggregation_test.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
aggregation.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
benchmark_test.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
cache_test.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
cache.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
config_test.go [chore] Use errors.Join to unify errors (#5907) 2024-10-22 15:10:05 -07:00
config.go [chore] Use errors.Join to unify errors (#5907) 2024-10-22 15:10:05 -07:00
doc.go Add comment to other observable instruments about repeated creation with callbacks (#5606) 2024-07-12 11:45:51 -07:00
env.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
example_test.go Add selector of exemplar reservoir providers to metric.Stream configuration (#5861) 2024-10-18 09:05:10 -04:00
exemplar_test.go Move global random number generator to randRes field (#5819) 2024-09-16 07:31:15 -07:00
exemplar.go Revert Cleanup interaction of exemplar and aggregation (#5913) 2024-10-23 10:48:07 -07:00
exporter.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
go.mod Release v1.31.0/v0.53.0/v0.7.0/v0.0.10 (#5883) 2024-10-11 12:59:27 -04:00
go.sum fix(deps): update golang.org/x (#5872) 2024-10-07 09:13:11 +02:00
instrument_test.go Revert Cleanup interaction of exemplar and aggregation (#5913) 2024-10-23 10:48:07 -07:00
instrument.go Add selector of exemplar reservoir providers to metric.Stream configuration (#5861) 2024-10-18 09:05:10 -04:00
instrumentkind_string.go Fix exported instrument kind const value change (#5385) 2024-05-21 08:46:38 -07:00
manual_reader_test.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
manual_reader.go [chore] Use errors.Join to unify errors (#5907) 2024-10-22 15:10:05 -07:00
meter_test.go Allow configuring the exemplar filter on the metrics SDK (#5850) 2024-10-11 16:02:20 -04:00
meter.go [chore] Use errors.Join to unify errors (#5907) 2024-10-22 15:10:05 -07:00
periodic_reader_test.go Fix typos (#5763) 2024-09-09 08:53:15 +02:00
periodic_reader.go [chore] Use errors.Join to unify errors (#5907) 2024-10-22 15:10:05 -07:00
pipeline_registry_test.go Allow configuring the exemplar filter on the metrics SDK (#5850) 2024-10-11 16:02:20 -04:00
pipeline_test.go Add selector of exemplar reservoir providers to metric.Stream configuration (#5861) 2024-10-18 09:05:10 -04:00
pipeline.go Revert Cleanup interaction of exemplar and aggregation (#5913) 2024-10-23 10:48:07 -07:00
provider_test.go [chore]: enable len and empty rules from testifylint (#5832) 2024-09-21 08:04:28 -07:00
provider.go Allow configuring the exemplar filter on the metrics SDK (#5850) 2024-10-11 16:02:20 -04:00
reader_test.go [chore] Use errors.Join to unify errors (#5907) 2024-10-22 15:10:05 -07:00
reader.go typo: fix docs (#5649) 2024-07-26 09:41:00 -07:00
README.md Add READMEs to every package (#5103) 2024-03-26 20:13:54 +01:00
version_test.go [chore] Simplify the license header (#4987) 2024-02-29 07:05:28 +01:00
version.go Release v1.31.0/v0.53.0/v0.7.0/v0.0.10 (#5883) 2024-10-11 12:59:27 -04:00
view_test.go Add the synchronous gauge to the metric API and SDK (#5304) 2024-05-16 09:56:40 -07:00
view.go Add selector of exemplar reservoir providers to metric.Stream configuration (#5861) 2024-10-18 09:05:10 -04:00

Metric SDK

PkgGoDev