You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2026-06-03 18:35:08 +02:00
c15644d64e
Fixes https://github.com/open-telemetry/opentelemetry-go/issues/7014 This PR adds support for below self observability metrics for stdoutmetric exporter - otel.sdk.exporter.metric_data_point.inflight - otel.sdk.exporter.metric_data_point.exported - otel.sdk.exporter.operation.duration These metrics are experimental and hence behind a feature flag OTEL_GO_X_OBSERVABILITY. Definition of above metrics is available at https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/otel/sdk-metrics.md <details> <summary>Observability Implementation Checklist</summary> ## Observability Implementation Checklist Based on the [project Observability guidelines](https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/CONTRIBUTING.md#observability), ensure the following are completed: ### Environment Variable Activation * [x] Observability features are disabled by default * [x] Features are activated through the `OTEL_GO_X_OBSERVABILITY` environment variable * [x] Use consistent pattern with `x.Observability.Enabled()` check [^1] * [x] Follow established experimental feature pattern [^2][^3] [^1]: https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/exporters/stdout/stdouttrace/internal/observ/instrumentation.go#L101-L103 [^2]: https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/exporters/stdout/stdouttrace/internal/x/x.go [^3]: https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/sdk/internal/x/x.go ### Encapsulation * [x] Instrumentation is encapsulated within a dedicated `struct` (e.g., [`Instrumentation`](https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/exporters/stdout/stdouttrace/internal/observ/instrumentation.go#L86-L94)) * [x] Instrumentation is not mixed into the instrumented component * [x] Instrumentation code is in its own file or package if complex/reused * [x] Instrumentation setup doesn't bloat the main component code ### Initialization * [x] Initialization is only done when observability is enabled * [x] Setup is explicit and side-effect free * [x] Return errors from initialization when appropriate * [x] Use the global Meter provider (e.g., `otel.GetMeterProvider()`) * [x] Include proper meter configuration with: * [x] Instrumentation package name is used for the Meter * [x] Instrumentation version (e.g. [`Version`](https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/exporters/stdout/stdouttrace/internal/observ/instrumentation.go#L40-L43)) * [x] Schema URL (e.g. [`SchemaURL`](https://github.com/open-telemetry/opentelemetry-go/blob/e4ab3141123d0811125a69823dbbe4d9ec5a9b8f/exporters/stdout/stdouttrace/internal/observ/instrumentation.go#L36-L38)) ### Performance * [x] Little to no overhead when observability is disabled * [x] Expensive operations are only executed when observability is enabled * [x] When enabled, instrumentation code paths are optimized to reduce allocation/computation overhead #### Attribute and Option Allocation Management * [x] Use `sync.Pool` for attribute slices and options with dynamic attributes * [x] Pool objects are properly reset before returning to pool * [x] Pools are scoped for maximum efficiency while ensuring correctness #### Caching * [x] Static attribute sets known at compile time are pre-computed and cached * [x] Common attribute combinations use lookup tables/maps #### Benchmarking * [x] Benchmarks provided for all instrumentation code * [ ] Benchmark scenarios include both enabled and disabled observability * [x] Benchmark results show impact on allocs/op, B/op, and ns/op (use `b.ReportAllocs()` in benchmarks) ### Error Handling and Robustness * [x] Errors are reported back to caller when possible * [x] Partial failures are handled gracefully * [x] Use partially initialized components when available * [x] Return errors to caller instead of only using `otel.Handle()` * [x] Use `otel.Handle()` only when component cannot report error to user ### Context Propagation * [x] Observability measurements receive the context from the function being measured (don't break context propagation by using `context.Background()`) ### Semantic Conventions Compliance * [x] All metrics follow [OpenTelemetry Semantic Conventions](https://github.com/open-telemetry/semantic-conventions/blob/5ee549b1ce30fe11fcb9b7e3bd35ebfb363f467f/docs/otel/sdk-metrics.md) * [x] Use the [`otelconv`](https://pkg.go.dev/go.opentelemetry.io/otel@v1.38.0/semconv/v1.37.0/otelconv) convenience package for metric semantic conventions * [x] Component names follow semantic conventions * [x] Use package path scope type as stable identifier for non-standard components * [x] Component names are stable unique identifiers * [x] Use global counter for uniqueness if necessary * [x] Component ID counter is resettable for deterministic testing ### Testing * [x] Use deterministic testing with isolated state * [x] Restore previous state after tests (`t.Cleanup()`) * [x] Isolate meter provider for testing * [x] Use `t.Setenv()` for environment variable testing * [x] Reset component ID counter for deterministic component names * [x] Test order doesn't affect results </details> --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Damien Mathieu <42@dmathieu.com>
67 lines
2.5 KiB
YAML
67 lines
2.5 KiB
YAML
# Copyright The OpenTelemetry Authors
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
|
|
module-sets:
|
|
stable-v1:
|
|
version: v1.39.0
|
|
modules:
|
|
- go.opentelemetry.io/otel
|
|
- go.opentelemetry.io/otel/bridge/opencensus
|
|
- go.opentelemetry.io/otel/bridge/opencensus/test
|
|
- go.opentelemetry.io/otel/bridge/opentracing
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlptrace
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
|
|
- go.opentelemetry.io/otel/exporters/stdout/stdoutmetric
|
|
- go.opentelemetry.io/otel/exporters/stdout/stdouttrace
|
|
- go.opentelemetry.io/otel/exporters/zipkin
|
|
- go.opentelemetry.io/otel/metric
|
|
- go.opentelemetry.io/otel/sdk
|
|
- go.opentelemetry.io/otel/sdk/metric
|
|
- go.opentelemetry.io/otel/trace
|
|
experimental-metrics:
|
|
version: v0.61.0
|
|
modules:
|
|
- go.opentelemetry.io/otel/exporters/prometheus
|
|
experimental-logs:
|
|
version: v0.15.0
|
|
modules:
|
|
- go.opentelemetry.io/otel/log
|
|
- go.opentelemetry.io/otel/log/logtest
|
|
- go.opentelemetry.io/otel/sdk/log
|
|
- go.opentelemetry.io/otel/sdk/log/logtest
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
|
|
- go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp
|
|
- go.opentelemetry.io/otel/exporters/stdout/stdoutlog
|
|
experimental-schema:
|
|
version: v0.0.14
|
|
modules:
|
|
- go.opentelemetry.io/otel/schema
|
|
excluded-modules:
|
|
- go.opentelemetry.io/otel/internal/tools
|
|
- go.opentelemetry.io/otel/trace/internal/telemetry/test
|
|
modules:
|
|
go.opentelemetry.io/otel/exporters/stdout/stdouttrace:
|
|
version-refs:
|
|
- ./internal/version.go
|
|
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric:
|
|
version-refs:
|
|
- ./internal/version.go
|
|
go.opentelemetry.io/otel/exporters/prometheus:
|
|
version-refs:
|
|
- ./internal/version.go
|
|
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc:
|
|
version-refs:
|
|
- ./internal/version.go
|
|
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc:
|
|
version-refs:
|
|
- ./internal/version.go
|
|
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp:
|
|
version-refs:
|
|
- ./internal/version.go
|
|
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp:
|
|
version-refs:
|
|
- ./internal/version.go
|