mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2024-12-12 10:04:29 +02:00
f1971b3f81
* POC using the grpc.ClientConn to handle connections * Update invalid client security test * Update client start test for a bad endpoint * Use any ClientConn a user provides * Connect ReconnectionPeriod to gRPC conn retries * Replace connection retry handling direct in otlptracegrpc * Fix client comments * Fix comment for NewGRPCConfig * Replace reconnection test * Fix grammar * Remove unrelated changes * Remove connection pkg * Rename evaluate to retryable * POC using the grpc.ClientConn to handle connections * Replace connection retry handling direct in otlptracegrpc * Add ClientConn use changes to changelog * Update otlptracegrpc options * Only close ClientConn that the Client create * Remove listener wrapper from mock_collector_test This is not needed now that no tests relies on the listener to wait for a connection to be established before continuing. * Fix spelling error * Do not use deprecated options in the otel-collector example * Add unit tests for retryable and throttleDelay funcs * Add unit tests for context heredity * Add test that exporter stop is linked to context cancel * go mod tidy * Update exporters/otlp/otlptrace/otlptracegrpc/client.go Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Fix go.mod from rebase * Remove wrong comment about client stop closing gRPC conn * Fix shutdown test cleanup Do not check the second call to the client Stop. There is no guarantee it will not error in normal operation. * Make lint fixes * Fix flaky unit test Use the internals of the client to explicit cancel the context returned from exportContext. This gets around the bug where the select in Stop may randomly choose the non-context Done case and avoid returning an error (also failing to cancel the context). * Remove deprecation To configure the client/exporter with environment variables these options are used. There is no way to fully remove these options without removing support for configuration with environment variables. Leave that decision and strategy determination to a separate PR. * Fix grammatical error in comment Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
194 lines
5.2 KiB
Go
194 lines
5.2 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package otlptracegrpc
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/genproto/googleapis/rpc/errdetails"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
)
|
|
|
|
func TestThrottleDuration(t *testing.T) {
|
|
c := codes.ResourceExhausted
|
|
testcases := []struct {
|
|
status *status.Status
|
|
expected time.Duration
|
|
}{
|
|
{
|
|
status: status.New(c, "no retry info"),
|
|
expected: 0,
|
|
},
|
|
{
|
|
status: func() *status.Status {
|
|
s, err := status.New(c, "single retry info").WithDetails(
|
|
&errdetails.RetryInfo{
|
|
RetryDelay: durationpb.New(15 * time.Millisecond),
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
return s
|
|
}(),
|
|
expected: 15 * time.Millisecond,
|
|
},
|
|
{
|
|
status: func() *status.Status {
|
|
s, err := status.New(c, "error info").WithDetails(
|
|
&errdetails.ErrorInfo{Reason: "no throttle detail"},
|
|
)
|
|
require.NoError(t, err)
|
|
return s
|
|
}(),
|
|
expected: 0,
|
|
},
|
|
{
|
|
status: func() *status.Status {
|
|
s, err := status.New(c, "error and retry info").WithDetails(
|
|
&errdetails.ErrorInfo{Reason: "with throttle detail"},
|
|
&errdetails.RetryInfo{
|
|
RetryDelay: durationpb.New(13 * time.Minute),
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
return s
|
|
}(),
|
|
expected: 13 * time.Minute,
|
|
},
|
|
{
|
|
status: func() *status.Status {
|
|
s, err := status.New(c, "double retry info").WithDetails(
|
|
&errdetails.RetryInfo{
|
|
RetryDelay: durationpb.New(13 * time.Minute),
|
|
},
|
|
&errdetails.RetryInfo{
|
|
RetryDelay: durationpb.New(15 * time.Minute),
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
return s
|
|
}(),
|
|
expected: 13 * time.Minute,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testcases {
|
|
t.Run(tc.status.Message(), func(t *testing.T) {
|
|
require.Equal(t, tc.expected, throttleDelay(tc.status))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRetryable(t *testing.T) {
|
|
retryableCodes := map[codes.Code]bool{
|
|
codes.OK: false,
|
|
codes.Canceled: true,
|
|
codes.Unknown: false,
|
|
codes.InvalidArgument: false,
|
|
codes.DeadlineExceeded: true,
|
|
codes.NotFound: false,
|
|
codes.AlreadyExists: false,
|
|
codes.PermissionDenied: false,
|
|
codes.ResourceExhausted: true,
|
|
codes.FailedPrecondition: false,
|
|
codes.Aborted: true,
|
|
codes.OutOfRange: true,
|
|
codes.Unimplemented: false,
|
|
codes.Internal: false,
|
|
codes.Unavailable: true,
|
|
codes.DataLoss: true,
|
|
codes.Unauthenticated: false,
|
|
}
|
|
|
|
for c, want := range retryableCodes {
|
|
got, _ := retryable(status.Error(c, ""))
|
|
assert.Equalf(t, want, got, "evaluate(%s)", c)
|
|
}
|
|
}
|
|
|
|
func TestUnstartedStop(t *testing.T) {
|
|
client := NewClient()
|
|
assert.ErrorIs(t, client.Stop(context.Background()), errAlreadyStopped)
|
|
}
|
|
|
|
func TestUnstartedUploadTrace(t *testing.T) {
|
|
client := NewClient()
|
|
assert.ErrorIs(t, client.UploadTraces(context.Background(), nil), errShutdown)
|
|
}
|
|
|
|
func TestExportContextHonorsParentDeadline(t *testing.T) {
|
|
now := time.Now()
|
|
ctx, cancel := context.WithDeadline(context.Background(), now)
|
|
t.Cleanup(cancel)
|
|
|
|
// Without a client timeout, the parent deadline should be used.
|
|
client := newClient(WithTimeout(0))
|
|
eCtx, eCancel := client.exportContext(ctx)
|
|
t.Cleanup(eCancel)
|
|
|
|
deadline, ok := eCtx.Deadline()
|
|
assert.True(t, ok, "deadline not propagated to child context")
|
|
assert.Equal(t, now, deadline)
|
|
}
|
|
|
|
func TestExportContextHonorsClientTimeout(t *testing.T) {
|
|
// Setting a timeout should ensure a deadline is set on the context.
|
|
client := newClient(WithTimeout(1 * time.Second))
|
|
ctx, cancel := client.exportContext(context.Background())
|
|
t.Cleanup(cancel)
|
|
|
|
_, ok := ctx.Deadline()
|
|
assert.True(t, ok, "timeout not set as deadline for child context")
|
|
}
|
|
|
|
func TestExportContextLinksStopSignal(t *testing.T) {
|
|
rootCtx := context.Background()
|
|
|
|
client := newClient(WithInsecure())
|
|
t.Cleanup(func() { require.NoError(t, client.Stop(rootCtx)) })
|
|
require.NoError(t, client.Start(rootCtx))
|
|
|
|
ctx, cancel := client.exportContext(rootCtx)
|
|
t.Cleanup(cancel)
|
|
|
|
require.False(t, func() bool {
|
|
select {
|
|
case <-ctx.Done():
|
|
return true
|
|
default:
|
|
}
|
|
return false
|
|
}(), "context should not be done prior to canceling it")
|
|
|
|
// The client.stopFunc cancels the client.stopCtx. This should have been
|
|
// setup as a parent of ctx. Therefore, it should cancel ctx as well.
|
|
client.stopFunc()
|
|
|
|
// Assert this with Eventually to account for goroutine scheduler timing.
|
|
assert.Eventually(t, func() bool {
|
|
select {
|
|
case <-ctx.Done():
|
|
return true
|
|
default:
|
|
}
|
|
return false
|
|
}, 10*time.Second, time.Microsecond)
|
|
}
|