1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-12 10:04:29 +02:00
opentelemetry-go/internal
Anthony Mirabella ca3f74d976
Add Span#RecordError method to simplify adding error events to spans (#473)
* Add `Span#Error` method to simplify setting an error status and message.

* `Span#Error` should no-op on nil errors

* Record errors as a span event rather than status/attributes.

The implementation in the SDK package now relies on existing API methods.

* Add WithErrorStatus() ErrorOption to allow setting span status on error.

* Apply suggestions from code review

Co-Authored-By: Krzesimir Nowak <qdlacz@gmail.com>

* Address code review feedback

* Clean up RecordError tests

* Ensure complete and unique error type is recorded for defined types
* Avoid duplicating logic under test in tests

* Move TestError to internal/testing package, improve RecordError test scenarios

Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
2020-02-28 13:44:53 -08:00
..
matchers Add inspectable test tracer (#353) 2019-12-04 14:00:35 -08:00
metric Add comments and test for 64-bit field alignment (#418) 2020-01-06 13:08:40 -05:00
testing Add Span#RecordError method to simplify adding error events to spans (#473) 2020-02-28 13:44:53 -08:00
trace Add Span#RecordError method to simplify adding error events to spans (#473) 2020-02-28 13:44:53 -08:00