1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-12 10:04:29 +02:00
opentelemetry-go/example
Injun Song d75e268053
Avoid overriding configuration of tracer provider (#1633)
* sdk/trace: add missing options to tracer provider

This change adds `WithDefaultSampler` and `WithSpanLimits` to the tracer
provider and removed `WithConfig` from it.

Before this change, `WithConfig` is the only way to set sampler or
limits of a span. However, it is prone to misuse, since `WithConfig` can
override tracing configurations that are configured by `WithResource` or
`WithIDGenerator`.  Thus to fix this, it adds new functional options -
`WithDefaultSampler` and `WithSpanLimits` and removes `WithConfig`.

Resolves #1631.

* Update sdk/trace/provider.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update sdk/trace/provider.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* rebase and remove WithConfig

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-03-08 13:43:11 -08:00
..
jaeger Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 (#1667) 2021-03-08 12:15:49 -08:00
namedtracer Avoid overriding configuration of tracer provider (#1633) 2021-03-08 13:43:11 -08:00
opencensus Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 (#1667) 2021-03-08 12:15:49 -08:00
otel-collector Avoid overriding configuration of tracer provider (#1633) 2021-03-08 13:43:11 -08:00
prom-collector Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 (#1667) 2021-03-08 12:15:49 -08:00
prometheus Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 (#1667) 2021-03-08 12:15:49 -08:00
zipkin Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 (#1667) 2021-03-08 12:15:49 -08:00