1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-10-08 23:21:56 +02:00
Files
opentelemetry-go/propagation/baggage_test.go
James Moessis f410084b21 propagation: extract of multiple header values (#5973)
* Add `ValuesGetter` interface, an optional `TextMapCarrier` feature
that adds `Values(string) []string`.
* `HeaderCarrier` implements `ValuesGetter`.
* Change `Baggage` to use the `Values()` method if it's implemented.

Notable comment:
https://github.com/open-telemetry/opentelemetry-go/pull/5973#discussion_r2074894706

Adds tests extracting requests with multiple 'baggage' headers set.
Does not introduce any breaking changes or alter any existing tests.

Spec issue:
https://github.com/open-telemetry/opentelemetry-specification/issues/433
Corresponding Java prototype:
https://github.com/open-telemetry/opentelemetry-java/pull/6852

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: dmathieu <42@dmathieu.com>
2025-05-15 09:14:35 +02:00

362 lines
8.1 KiB
Go

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
package propagation_test
import (
"context"
"net/http"
"strings"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/stretchr/testify/assert"
"go.opentelemetry.io/otel/baggage"
"go.opentelemetry.io/otel/propagation"
)
type property struct {
Key, Value string
}
type member struct {
Key, Value string
Properties []property
}
func (m member) Member(t *testing.T) baggage.Member {
props := make([]baggage.Property, 0, len(m.Properties))
for _, p := range m.Properties {
p, err := baggage.NewKeyValuePropertyRaw(p.Key, p.Value)
if err != nil {
t.Fatal(err)
}
props = append(props, p)
}
bMember, err := baggage.NewMemberRaw(m.Key, m.Value, props...)
if err != nil {
t.Fatal(err)
}
return bMember
}
type members []member
func (m members) Baggage(t *testing.T) baggage.Baggage {
bMembers := make([]baggage.Member, 0, len(m))
for _, mem := range m {
bMembers = append(bMembers, mem.Member(t))
}
bag, err := baggage.New(bMembers...)
if err != nil {
t.Fatal(err)
}
return bag
}
func TestExtractValidBaggage(t *testing.T) {
prop := propagation.TextMapPropagator(propagation.Baggage{})
tests := []struct {
name string
header string
want members
}{
{
name: "valid w3cHeader",
header: "key1=val1,key2=val2",
want: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
},
{
name: "valid w3cHeader with spaces",
header: "key1 = val1, key2 =val2 ",
want: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
},
{
name: "valid w3cHeader with properties",
header: "key1=val1,key2=val2;prop=1",
want: members{
{Key: "key1", Value: "val1"},
{
Key: "key2",
Value: "val2",
Properties: []property{
{Key: "prop", Value: "1"},
},
},
},
},
{
name: "valid header with an invalid header",
header: "key1=val1,key2=val2,a,val3",
want: members{},
},
{
name: "valid header with no value",
header: "key1=,key2=val2",
want: members{
{Key: "key1", Value: ""},
{Key: "key2", Value: "val2"},
},
},
{
name: "valid header with url encoded string",
header: "key1=val%252",
want: members{
{Key: "key1", Value: "val%2"},
},
},
{
name: "empty header",
header: "",
want: members{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
mapCarr := propagation.MapCarrier{}
mapCarr["baggage"] = tt.header
req, _ := http.NewRequest(http.MethodGet, "http://example.com", nil)
req.Header.Set("baggage", tt.header)
// test with http header carrier (which implements ValuesGetter)
ctx := prop.Extract(context.Background(), propagation.HeaderCarrier(req.Header))
expected := tt.want.Baggage(t)
assert.Equal(t, expected, baggage.FromContext(ctx), "should extract baggage for HeaderCarrier")
// test with map carrier (which does not implement ValuesGetter)
ctx = prop.Extract(context.Background(), mapCarr)
expected = tt.want.Baggage(t)
assert.Equal(t, expected, baggage.FromContext(ctx), "should extract baggage for MapCarrier")
})
}
}
func TestExtractValidMultipleBaggageHeaders(t *testing.T) {
prop := propagation.TextMapPropagator(propagation.Baggage{})
tests := []struct {
name string
headers []string
want members
}{
{
name: "non conflicting headers",
headers: []string{"key1=val1", "key2=val2"},
want: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
},
{
name: "conflicting keys, uses last val",
headers: []string{"key1=val1", "key1=val2"},
want: members{
{Key: "key1", Value: "val2"},
},
},
{
name: "single empty",
headers: []string{"", "key1=val1"},
want: members{
{Key: "key1", Value: "val1"},
},
},
{
name: "all empty",
headers: []string{"", ""},
want: members{},
},
{
name: "none",
headers: []string{},
want: members{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
req, _ := http.NewRequest(http.MethodGet, "http://example.com", nil)
req.Header["Baggage"] = tt.headers
ctx := context.Background()
ctx = prop.Extract(ctx, propagation.HeaderCarrier(req.Header))
expected := tt.want.Baggage(t)
assert.Equal(t, expected, baggage.FromContext(ctx))
})
}
}
func TestExtractInvalidDistributedContextFromHTTPReq(t *testing.T) {
prop := propagation.TextMapPropagator(propagation.Baggage{})
tests := []struct {
name string
header string
has members
}{
{
name: "no key values",
header: "header1",
},
{
name: "invalid header with existing context",
header: "header2",
has: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
},
{
name: "empty header value",
header: "",
has: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
},
{
name: "with properties",
header: "key1=val1,key2=val2;prop=1",
has: members{
{Key: "key1", Value: "val1"},
{
Key: "key2",
Value: "val2",
Properties: []property{
{Key: "prop", Value: "1"},
},
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
req, _ := http.NewRequest(http.MethodGet, "http://example.com", nil)
req.Header.Set("baggage", tt.header)
expected := tt.has.Baggage(t)
ctx := baggage.ContextWithBaggage(context.Background(), expected)
ctx = prop.Extract(ctx, propagation.HeaderCarrier(req.Header))
assert.Equal(t, expected, baggage.FromContext(ctx))
})
}
}
func TestInjectBaggageToHTTPReq(t *testing.T) {
propagator := propagation.Baggage{}
tests := []struct {
name string
mems members
wantInHeader []string
}{
{
name: "two simple values",
mems: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
wantInHeader: []string{"key1=val1", "key2=val2"},
},
{
name: "values with escaped chars",
mems: members{
{Key: "key2", Value: "val3,4"},
},
wantInHeader: []string{"key2=val3%2C4"},
},
{
name: "with properties",
mems: members{
{Key: "key1", Value: "val1"},
{
Key: "key2",
Value: "val2",
Properties: []property{
{Key: "prop", Value: "1"},
},
},
},
wantInHeader: []string{
"key1=val1",
"key2=val2;prop=1",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
req, _ := http.NewRequest(http.MethodGet, "http://example.com", nil)
ctx := baggage.ContextWithBaggage(context.Background(), tt.mems.Baggage(t))
propagator.Inject(ctx, propagation.HeaderCarrier(req.Header))
got := strings.Split(req.Header.Get("baggage"), ",")
assert.ElementsMatch(t, tt.wantInHeader, got)
})
}
}
func TestBaggageInjectExtractRoundtrip(t *testing.T) {
propagator := propagation.Baggage{}
tests := []struct {
name string
mems members
}{
{
name: "two simple values",
mems: members{
{Key: "key1", Value: "val1"},
{Key: "key2", Value: "val2"},
},
},
{
name: "values with escaped chars",
mems: members{
{Key: "key1", Value: "val3=4"},
{Key: "key2", Value: "mess,me%up"},
},
},
{
name: "with properties",
mems: members{
{Key: "key1", Value: "val1"},
{
Key: "key2",
Value: "val2",
Properties: []property{
{Key: "prop", Value: "1"},
},
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
b := tt.mems.Baggage(t)
req, _ := http.NewRequest(http.MethodGet, "http://example.com", nil)
ctx := baggage.ContextWithBaggage(context.Background(), b)
propagator.Inject(ctx, propagation.HeaderCarrier(req.Header))
ctx = propagator.Extract(context.Background(), propagation.HeaderCarrier(req.Header))
got := baggage.FromContext(ctx)
assert.Equal(t, b, got)
})
}
}
func TestBaggagePropagatorGetAllKeys(t *testing.T) {
var propagator propagation.Baggage
want := []string{"baggage"}
got := propagator.Fields()
if diff := cmp.Diff(got, want); diff != "" {
t.Errorf("GetAllKeys: -got +want %s", diff)
}
}