updated linter

apis/health_test.go

@@ -1,9 +1,10 @@
 package apis_test
 
 import (
-	"github.com/pocketbase/pocketbase/tests"
 	"net/http"
 	"testing"
+
+	"github.com/pocketbase/pocketbase/tests"
 )
 
 func TestHealthAPI(t *testing.T) {

daos/base.go

@@ -93,9 +93,9 @@ func (dao *Dao) NonconcurrentDB() dbx.Builder {
 // 		}
 // 		defer app.Dao().Continue()
 //
-//  	return app.Dao().RunInTransaction(func (txDao *daos.Dao) error {
-//  	    // some long running read&write transaction...
-//  	})
+// 		return app.Dao().RunInTransaction(func (txDao *daos.Dao) error {
+// 			// some long running read&write transaction...
+// 		})
 // 	}
 func (dao *Dao) Block(ctx context.Context) error {
 	if dao.sem == nil {

golangci.yml

@@ -7,10 +7,8 @@ linters:
   disable-all: true
   enable:
     - asciicheck
-    - deadcode
     - depguard
     - exportloopref
-    - gocritic
     - gofmt
     - goimports
     - gomodguard
@@ -26,5 +24,4 @@ linters:
     - typecheck
     - unconvert
     - unused
-    - varcheck
     - whitespace

tools/auth/base_provider.go

@@ -3,7 +3,7 @@ package auth
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 
 	"golang.org/x/oauth2"
@@ -125,7 +125,7 @@ func (p *baseProvider) sendRawUserDataRequest(req *http.Request, token *oauth2.T
 	}
 	defer response.Body.Close()
 
-	result, err := ioutil.ReadAll(response.Body)
+	result, err := io.ReadAll(response.Body)
 	if err != nil {
 		return nil, err
 	}

tools/auth/github.go

@@ -2,7 +2,7 @@ package auth
 
 import (
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"strconv"
 
 	"golang.org/x/oauth2"
@@ -75,7 +75,7 @@ func (p *Github) FetchAuthUser(token *oauth2.Token) (*AuthUser, error) {
 		}
 		defer response.Body.Close()
 
-		content, err := ioutil.ReadAll(response.Body)
+		content, err := io.ReadAll(response.Body)
 		if err != nil {
 			return user, err
 		}

tools/filesystem/file_test.go

@@ -45,6 +45,10 @@ func TestNewFileFromFromPath(t *testing.T) {
 
 func TestNewFileFromMultipart(t *testing.T) {
 	formData, mp, err := tests.MockMultipartData(nil, "test")
+	if err != nil {
+		t.Fatal(err)
+	}
+
 	req := httptest.NewRequest("", "/", formData)
 	req.Header.Set(echo.HeaderContentType, mp.FormDataContentType())
 	req.ParseMultipartForm(32 << 20)

tools/mailer/smtp_test.go

@@ -68,7 +68,7 @@ func TestLoginAuthStart(t *testing.T) {
 		}
 
 		if len(resp) != 0 {
-			t.Fatalf("[%s] Expected emtpy data response, got %v", s.name, resp)
+			t.Fatalf("[%s] Expected empty data response, got %v", s.name, resp)
 		}
 
 		if method != "LOGIN" {