From 9cf5e287001c604bce242c5540595a83efac5392 Mon Sep 17 00:00:00 2001 From: Gani Georgiev Date: Thu, 8 Dec 2022 13:35:56 +0200 Subject: [PATCH] replaced QueryString() with QueryParams().Encode() --- CHANGELOG.md | 2 ++ apis/admin.go | 2 +- apis/collection.go | 2 +- apis/logs.go | 2 +- apis/record_crud.go | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6cb2d3ac..36c9579a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ - Added `Dao` query semaphore and base fail/retry handling to improve the concurrent writes throughput ([#1187](https://github.com/pocketbase/pocketbase/issues/1187)). +- Replaced `c.QueryString()` with `c.QueryParams().Encode()` to allow loading middleware modified query parameters in the default crud actions ([#1210](https://github.com/pocketbase/pocketbase/discussions/1210)). + - Updated the GitHub goreleaser action to use go 1.19.4 since it comes with [some security fixes](https://github.com/golang/go/issues?q=milestone%3AGo1.19.4+label%3ACherryPickApproved). diff --git a/apis/admin.go b/apis/admin.go index cf8354a3..39ba6f3c 100644 --- a/apis/admin.go +++ b/apis/admin.go @@ -120,7 +120,7 @@ func (api *adminApi) list(c echo.Context) error { result, err := search.NewProvider(fieldResolver). Query(api.app.Dao().AdminQuery()). - ParseAndExec(c.QueryString(), &admins) + ParseAndExec(c.QueryParams().Encode(), &admins) if err != nil { return NewBadRequestError("", err) diff --git a/apis/collection.go b/apis/collection.go index 861de01b..146a041f 100644 --- a/apis/collection.go +++ b/apis/collection.go @@ -36,7 +36,7 @@ func (api *collectionApi) list(c echo.Context) error { result, err := search.NewProvider(fieldResolver). Query(api.app.Dao().CollectionQuery()). - ParseAndExec(c.QueryString(), &collections) + ParseAndExec(c.QueryParams().Encode(), &collections) if err != nil { return NewBadRequestError("", err) diff --git a/apis/logs.go b/apis/logs.go index 7452fd65..079cd7ca 100644 --- a/apis/logs.go +++ b/apis/logs.go @@ -35,7 +35,7 @@ func (api *logsApi) requestsList(c echo.Context) error { result, err := search.NewProvider(fieldResolver). Query(api.app.LogsDao().RequestQuery()). - ParseAndExec(c.QueryString(), &[]*models.Request{}) + ParseAndExec(c.QueryParams().Encode(), &[]*models.Request{}) if err != nil { return NewBadRequestError("", err) diff --git a/apis/record_crud.go b/apis/record_crud.go index 5d25f8f7..dfb4a096 100644 --- a/apis/record_crud.go +++ b/apis/record_crud.go @@ -74,7 +74,7 @@ func (api *recordApi) list(c echo.Context) error { } var rawRecords = []dbx.NullStringMap{} - result, err := searchProvider.ParseAndExec(c.QueryString(), &rawRecords) + result, err := searchProvider.ParseAndExec(c.QueryParams().Encode(), &rawRecords) if err != nil { return NewBadRequestError("Invalid filter parameters.", err) }