build: modernize Go usage

This commit modernizes Go usage. This was done with:

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Then files needed to be `go fmt`ed and a few comments needed to be
restored.

The modernizations include replacing

- if/else conditional assignment by a call to the built-in min or max functions added in go1.21
- sort.Slice(x, func(i, j int) bool) { return s[i] < s[j] } by a call to slices.Sort(s), added in go1.21
- interface{} by the 'any' type added in go1.18
- append([]T(nil), s...) by slices.Clone(s) or slices.Concat(s), added in go1.21
- loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21
- []byte(fmt.Sprintf...) by fmt.Appendf(nil, ...), added in go1.19
- append(s[:i], s[i+1]...) by slices.Delete(s, i, i+1), added in go1.21
- a 3-clause for i := 0; i < n; i++ {} loop by for i := range n {}, added in go1.22

cmd/progress.go

@@ -40,7 +40,7 @@ func startProgress() func() {
 	}
 
 	// Intercept output from functions such as HashLister to stdout
-	operations.SyncPrintf = func(format string, a ...interface{}) {
+	operations.SyncPrintf = func(format string, a ...any) {
 		printProgress(fmt.Sprintf(format, a...))
 	}
 
@@ -97,7 +97,7 @@ func printProgress(logMessage string) {
 		out(terminal.MoveUp)
 	}
 	// Move to the start of the block we wrote erasing all the previous lines
-	for i := 0; i < nlines-1; i++ {
+	for range nlines - 1 {
 		out(terminal.EraseLine)
 		out(terminal.MoveUp)
 	}