From 5403e1c79acf96e7d42f86b5432af80bedef51d2 Mon Sep 17 00:00:00 2001
From: Nick Craig-Wood <nick@craig-wood.com>
Date: Fri, 17 Jan 2020 14:58:23 +0000
Subject: [PATCH] lib/encoder: remove noencode tag and update CONTRIBUTING
---
CONTRIBUTING.md | 5 ++---
lib/encoder/standard.go | 2 --
lib/encoder/standard_noencode.go | 9 ---------
3 files changed, 2 insertions(+), 14 deletions(-)
delete mode 100644 lib/encoder/standard_noencode.go
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 51c81d760..df4cc964e 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -337,10 +337,9 @@ Getting going
* Add your remote to the imports in `backend/all/all.go`
* HTTP based remotes are easiest to maintain if they use rclone's rest module, but if there is a really good go SDK then use that instead.
* Try to implement as many optional methods as possible as it makes the remote more usable.
- * Use fs/encoder to make sure we can encode any path name and `rclone info` to help determine the encodings needed
- * `go install -tags noencode`
+ * Use lib/encoder to make sure we can encode any path name and `rclone info` to help determine the encodings needed
* `rclone purge -v TestRemote:rclone-info`
- * `rclone info -vv --write-json remote.json TestRemote:rclone-info`
+ * `rclone info --remote-encoding None -vv --write-json remote.json TestRemote:rclone-info`
* `go run cmd/info/internal/build_csv/main.go -o remote.csv remote.json`
* open `remote.csv` in a spreadsheet and examine
diff --git a/lib/encoder/standard.go b/lib/encoder/standard.go
index f903d8f22..439437c79 100644
--- a/lib/encoder/standard.go
+++ b/lib/encoder/standard.go
@@ -1,5 +1,3 @@
-// +build !noencode
-
package encoder
// Standard defines the encoding that is used for paths in- and output by rclone.
diff --git a/lib/encoder/standard_noencode.go b/lib/encoder/standard_noencode.go
deleted file mode 100644
index 09c0f79ba..000000000
--- a/lib/encoder/standard_noencode.go
+++ /dev/null
@@ -1,9 +0,0 @@
-// +build noencode
-
-package encoder
-
-// Fake encodings used for testing
-const (
- EncodeStandard = EncodeZero | EncodeSlash | EncodeDot
- Standard = MultiEncoder(EncodeStandard)
-)