go/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-07-06 06:27:53 +02:00
Code Issues Releases Activity

lib/file: improve error message for create dir on non-existent network host on windows (#6420)

Browse Source
This commit is contained in:
albertony
2022-10-28 21:00:22 +02:00
committed by GitHub
parent 1fc864fb32
commit 65987f5970
2 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/file/mkdir_windows_test.go
View File

@ -128,3 +128,21 @@ func TestMkdirAllOnUnusedDrive(t *testing.T) {
errormsg = fmt.Sprintf("mkdir \\\\?\\%s\\: The system cannot find the path specified.", path)
checkMkdirAllSubdirs(t, `\\?\`+path, false, errormsg)
}
// Testing paths on unknown network host
// This is an additional difference from golang's os.MkdirAll. With our
// first fix, stopping it from recursing extended-length paths down to
// the "\\?" prefix, it would now stop at `\\?\UNC`, because that is what
// filepath.VolumeName returns (which is wrong, that is not a volume name!),
// and still return a nonifnromative error:
// "mkdir \\?\UNC\\: The filename, directory name, or volume label syntax is incorrect."
// Our version stops the recursion at level before this, and reports:
// "mkdir \\?\UNC\0.0.0.0: The specified path is invalid."
func TestMkdirAllOnUnusedNetworkHost(t *testing.T) {
path := `\\0.0.0.0\share`
errormsg := fmt.Sprintf("mkdir %s\\: The format of the specified network name is invalid.", path)
checkMkdirAllSubdirs(t, path, false, errormsg)
path = `\\?\UNC\0.0.0.0\share`
errormsg = `mkdir \\?\UNC\0.0.0.0: The specified path is invalid.`
checkMkdirAllSubdirs(t, path, false, errormsg)
}