rclone

go/rclone

mirror of https://github.com/rclone/rclone.git synced 2025-11-29 05:47:23 +02:00

Files

Copilot ee92673e1b sftp: fix zombie SSH processes with --sftp-ssh - Fixes #8929

Before this fix using --sftp-ssh with the sftp backend could leave
zombie processes.

This patch fixes the problem that sshClientExternal.session was never
assigned, so Wait() always returned nil without waiting for the SSH
process to exit. This caused zombie processes because the process was
never reaped.

It also ensures that Wait() is only called once on each process.

I gave this issue to Copilot to fix as an experiment. It went off in
the wrong direction to start with and fixed something which wasn't the
problem but still needed fixing. With a bit of a nudge it fixed the
correct problem too.

Co-authored-by: Nick Craig-Wood <nick@craig-wood.com>

2025-11-04 12:09:47 +00:00

sftp_internal_test.go

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

sftp_test.go

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

sftp_unsupported.go

build: fix linting issues reported by running golangci-lint with different GOOS

2024-04-22 19:29:12 +02:00

sftp.go

about: fix potential overflow of about in various backends