go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-01-30 04:31:00 +02:00
Code Issues Releases Activity

refactor: simplify with strings.Prefix, strings.CutPrefix (#1137)

Browse Source
This commit is contained in:
Oleksandr Redko 2024-11-19 16:43:04 +02:00 committed by GitHub
parent 93c6bc8636
commit 1425e2f44c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cli/main.go
View File

@ -189,10 +189,7 @@ func getVersion(builtBy, date, commit, version string) string {
if version == defaultVersion {
bi, ok := debug.ReadBuildInfo()
if ok {
version = bi.Main.Version
if strings.HasPrefix(version, "v") {
version = strings.TrimLeft(bi.Main.Version, "v")
}
version = strings.TrimPrefix(bi.Main.Version, "v")
if len(buildInfo) == 0 {
return fmt.Sprintf("version %s\n", version)
}

4
rule/exported.go
View File

@ -252,8 +252,8 @@ func (w *lintExported) lintTypeDoc(t *ast.TypeSpec, doc *ast.CommentGroup) {
if t.Name.Name == a {
continue
}
if strings.HasPrefix(s, a+" ") {
s = s[len(a)+1:]
var found bool
if s, found = strings.CutPrefix(s, a+" "); found {
break
}
}

4
rule/struct_tag.go
View File

@ -139,8 +139,8 @@ func (lintStructTagRule) getTagName(tag *structtag.Tag) string {
switch tag.Key {
case keyProtobuf:
for _, option := range tag.Options {
if strings.HasPrefix(option, "name=") {
return strings.TrimPrefix(option, "name=")
if tagName, found := strings.CutPrefix(option, "name="); found {
return tagName
}
}
return "" // protobuf tag lacks 'name' option